From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA27BC2D0C1 for ; Thu, 19 Dec 2019 05:19:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6742824650 for ; Thu, 19 Dec 2019 05:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="k0e84dPH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6742824650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD27E8E0155; Thu, 19 Dec 2019 00:19:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D80F68E00F5; Thu, 19 Dec 2019 00:19:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C96FF8E0155; Thu, 19 Dec 2019 00:19:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id B5DD48E00F5 for ; Thu, 19 Dec 2019 00:19:38 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 713498249980 for ; Thu, 19 Dec 2019 05:19:38 +0000 (UTC) X-FDA: 76280738436.03.yard67_712f8fee91a48 X-HE-Tag: yard67_712f8fee91a48 X-Filterd-Recvd-Size: 4386 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Dec 2019 05:19:37 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id k14so5589490otn.4 for ; Wed, 18 Dec 2019 21:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ebFIMmIFcRXMNWKUGHUPVzk5pgnyLGBQyisFaU/FwbA=; b=k0e84dPH4htoykVcj9saaY4VEZM4fFiDoj23iKL7NDpna4Dyr28UklvE4Qm1hEnppc 4EbUbfCTOn/b8lUfCNu2jNxUj1froCEK5Z8ZrX+n4cNMtHyy3HHVdQ4F0Dnz6W644vIS CoypM4ri8MnlsjoxJl6sNO2YIoAd65qi9vuKkshigdqdkOxib4j6DAXomkzWIUoKIo8T SMzh8t1qvWHtMDnhP1avLg6zE5zGJQFkYt3QsG1u0q3paSZqxZo4s2JqOmXvs03sYzR8 qqPl9RGItEiN72UPcuWzspy7AXHNrvdYBRk7bebD4oCBZa+e0MhCf52+QgTmd1tU/laL 8nww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ebFIMmIFcRXMNWKUGHUPVzk5pgnyLGBQyisFaU/FwbA=; b=Jjw0DjvGZfCzLhmU6DpDgtan8g0SRdQAh0GEj1/BSF3KreEN/kzn3JC3dMLidD1sTT RSzgrLQuAc/38nSXKGIntUuM45D72IPyAxfyS0erXE2iXutCOqfqWJ/s77Sl9o144zR8 y0HvujUjcQDRbTlGSl6KnLOYlGu7oiutCZ7gKsD982OEdKvH/rh9C1UXVUuPEUwuQc7e edeoZCZmo9oCFaZG1gPJcGXvFn7gkzVaKBd6s6Xu64+5Lrt60tKF+DM5PH72chVcvyjI Ifcj8y4WLjU3GohHmsU5BZSeZ8kGxviBscEHSdvP5UXDyr+gA+QIUHETjFVZ6mSV9WEg SU7w== X-Gm-Message-State: APjAAAXInMrolFijwwzcaneE0r1p6yjm/fjBm6NXof8llnAAS3IKNXOq Upa7O6oBb2wqJqoE5JNQCISPJZOtQyEVm85qItCsww== X-Google-Smtp-Source: APXvYqxhpUIvpLGge5tDFBoL23b9F+f851RUtQ3m9EXuu4PlCjXNQWpf9BjSiCVPHeeUOCcme8JMICpJQ2zNNvAoUtY= X-Received: by 2002:a05:6830:1744:: with SMTP id 4mr6553170otz.71.1576732776609; Wed, 18 Dec 2019 21:19:36 -0800 (PST) MIME-Version: 1.0 References: <1576728650-13867-1-git-send-email-anshuman.khandual@arm.com> In-Reply-To: <1576728650-13867-1-git-send-email-anshuman.khandual@arm.com> From: Dan Williams Date: Wed, 18 Dec 2019 21:19:25 -0800 Message-ID: Subject: Re: [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block To: Anshuman Khandual Cc: Linux MM , Andrew Morton , David Hildenbrand , Michal Hocko , Pavel Tatashin , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 18, 2019 at 8:10 PM Anshuman Khandual wrote: > > memory_block structure elements 'hw' and 'phys_callback' are not getting > used. This was originally added with commit 3947be1969a9 ("[PATCH] memory > hotplug: sysfs and add/remove functions") but never seem to have been used. > Just drop them now. > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Michal Hocko > Cc: Pavel Tatashin > Cc: Dan Williams > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > include/linux/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 0ebb105eb261..4e95a9eb8061 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -29,8 +29,6 @@ struct memory_block { > int section_count; /* serialized by mem_sysfs_mutex */ > int online_type; /* for passing data to online routine */ > int phys_device; /* to which fru does this belong? */ > - void *hw; /* optional pointer to fw/hw data */ > - int (*phys_callback)(struct memory_block *); > struct device dev; > int nid; /* NID for this memory block */ > }; > -- > 2.20.1 Looks good. Reviewed-by: Dan Williams