From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09CE2C43141 for ; Thu, 14 Nov 2019 16:35:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C25C120723 for ; Thu, 14 Nov 2019 16:35:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="wzDdYVXq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C25C120723 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 428F46B0006; Thu, 14 Nov 2019 11:35:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 400906B0008; Thu, 14 Nov 2019 11:35:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 315626B000A; Thu, 14 Nov 2019 11:35:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 1D7436B0006 for ; Thu, 14 Nov 2019 11:35:18 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id D90095DF9 for ; Thu, 14 Nov 2019 16:35:17 +0000 (UTC) X-FDA: 76155433074.13.back52_2e31ab60f3d1e X-HE-Tag: back52_2e31ab60f3d1e X-Filterd-Recvd-Size: 4877 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Nov 2019 16:35:17 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id m15so5378183otq.7 for ; Thu, 14 Nov 2019 08:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UNGw4TfqpfUCJ1fFVpttb7yfMciDUeoomP1skmq9jqo=; b=wzDdYVXqT4Ey6M67cJpE2V9RW05xslTchPTS/hgQLgzS1Adyn/SSVZe8h+/FV3+OEr 52aw9+G2ykaRfJ+mRf/qS93DqP/b1+Z7BIrrOLGGb96L9dS13FR/cQ5cJs76bWWlrK6W fqNBszqmuQdRuM/2GYczu5lSzGyKaI9xXrl4V/ZNMXYZfWwpYAi0lOB/oV28HZ7TjStS Zqfj2Avr6iBAu3jFnq7z/TQ870HCPlT3y93YEl4aHjCjK+JNpENeUdIZtSkOrBX6im9e w+lAIM11QP6vdr3x7EMoEeyf6fIy5ZiIpMHQUXkqsZwsodfqmPUjwrQgkGmNxSc/hft5 YFfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UNGw4TfqpfUCJ1fFVpttb7yfMciDUeoomP1skmq9jqo=; b=dhsZs+HsfGZMBz3xeC1zDNYt1R6+z7GBPhAavbVjwbjFvuVXGeQyfsBiE/zlzPTBrm f3Be3231Q365thkZdhm/TjM+PW8MIa6pKez8vQUAV0nCpgEbinOsIicekaWNCeQUv3B6 +ofXdY8/An984ioh9T4U0WpgJQmh4lVmujtBpBMSF0Cj6IqOV7N8BS5bNHW1W+uvbp0s HDBCebpc6SoNuUi4sBctaVfXl7jTBEGo7GFPVxKxfvwBEi9otp1x7ikYIUmPvdaJhLa8 CXBPqcn2s2LMDhBxyTyXSxHSmp6c+7p4KO64whLFV2Blooi2Iamdo22P0sM1g5qB3LS1 r35A== X-Gm-Message-State: APjAAAWig+USe3ucxrg8fT7/MkWVZOBA8cq/5V092f3UHGeemYeSm3YS 9hXo9YePoB/znJ1WAv/frM+UdUxmSxpGiuW68zZ/Wg== X-Google-Smtp-Source: APXvYqwhlbMIqVoDMtemn28FjHxtHG8v5mkLAQT8X9GpCHUizz0JFqeybR7UBBP0zJO9mCY12klfr97VHx+i97m3uhU= X-Received: by 2002:a9d:2d89:: with SMTP id g9mr7713217otb.126.1573749316381; Thu, 14 Nov 2019 08:35:16 -0800 (PST) MIME-Version: 1.0 References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-9-alastair@au1.ibm.com> <8232c1a6-d52a-6c32-6178-de082174a92a@linux.ibm.com> In-Reply-To: <8232c1a6-d52a-6c32-6178-de082174a92a@linux.ibm.com> From: Dan Williams Date: Thu, 14 Nov 2019 08:35:04 -0800 Message-ID: Subject: Re: [PATCH 08/10] nvdimm: Add driver for OpenCAPI Storage Class Memory To: Frederic Barrat Cc: "Alastair D'Silva" , alastair@d-silva.org, Oscar Salvador , Michal Hocko , David Hildenbrand , Alexey Kardashevskiy , Wei Yang , Keith Busch , Masahiro Yamada , Paul Mackerras , Ira Weiny , Thomas Gleixner , Pavel Tatashin , Dave Jiang , linux-nvdimm , Vishal Verma , Krzysztof Kozlowski , Mahesh Salgaonkar , Andrew Donnellan , Arnd Bergmann , Greg Kurz , Nicholas Piggin , Qian Cai , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Hari Bathini , David Gibson , Linux MM , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Some quick feedback on your intro concerns... On Thu, Nov 14, 2019 at 5:41 AM Frederic Barrat wrote: > > Hi Alastair, > > The patch is huge and could/should probably be split in smaller pieces Yeah, it's a must. Split the minimum viable infrastructure by topic and then follow on with per-feature topic patches. > to ease the review. However, having sinned on that same topic in the > past, I made a first pass anyway. I haven't covered everything but tried > to focus on the general setup of the driver for now. > Since the patch is very long, I'm writing all the comments in one chunk > here instead of spreading them over a few thousand lines, where some > would be easy to miss. > > > Update MAINTAINERS for the new files > > Have you discussed with the directory owner if it's ok to split the > driver over several files? My thought is to establish drivers/opencapi/ and move this and the existing drivers/misc/ocxl/ bits there.