From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id E6D9D6B0033 for ; Fri, 3 Feb 2017 16:47:07 -0500 (EST) Received: by mail-oi0-f70.google.com with SMTP id j82so28469135oih.6 for ; Fri, 03 Feb 2017 13:47:07 -0800 (PST) Received: from mail-ot0-x235.google.com (mail-ot0-x235.google.com. [2607:f8b0:4003:c0f::235]) by mx.google.com with ESMTPS id e3si11277314oig.8.2017.02.03.13.47.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 13:47:07 -0800 (PST) Received: by mail-ot0-x235.google.com with SMTP id 73so24373156otj.0 for ; Fri, 03 Feb 2017 13:47:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com> References: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com> From: Dan Williams Date: Fri, 3 Feb 2017 13:47:06 -0800 Message-ID: Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Dave Jiang Cc: Andrew Morton , Matthew Wilcox , "linux-nvdimm@lists.01.org" , Dave Hansen , linux-xfs@vger.kernel.org, Linux MM , "Kirill A. Shutemov" , Jan Kara , linux-ext4 , Ross Zwisler , Vlastimil Babka On Fri, Feb 3, 2017 at 1:31 PM, Dave Jiang wrote: > Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has > been somewhat painful with getting the flags set and removed at the > correct locations. More than one kernel oops was introduced due to > difficulties of getting the placement correctly. Removing the flag > values and introducing an input parameter to huge_fault that indicates > the size of the page entry. This makes the code easier to trace and > should avoid the issues we see with the fault flags where removal of the > flag was necessary in the fallback paths. > > Signed-off-by: Dave Jiang Tested-by: Dan Williams This fixes a crash I can produce with the existing ndctl unit tests [1] on next-20170202. Now to go extend the tests to go after the PUD case... [1]: https://github.com/pmem/ndctl -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org