From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Nitin Gupta <ngupta@vflare.org>, Shaohua Li <shli@kernel.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>
Subject: Re: [PATCH v3] mm: remove compressed copy from zram in-memory
Date: Fri, 10 May 2013 21:18:59 -0400 [thread overview]
Message-ID: <CAPbh3rsVnvEmH+sRoRYjGi3DERMkzFPmOn=a_Gt0uAMnLLmZJg@mail.gmail.com> (raw)
In-Reply-To: <20130510084413.GA2683@blaptop>
On Fri, May 10, 2013 at 4:44 AM, Minchan Kim <minchan@kernel.org> wrote:
> Hi Konrad,
>
> On Thu, May 09, 2013 at 04:15:42PM -0400, Konrad Rzeszutek Wilk wrote:
>> On Thu, May 09, 2013 at 08:41:57AM +0900, Minchan Kim wrote:
>>
>> Hey Michan,
> ^-n
>
> It's a only thing I can know better than other native speakers. :)
I keep on misspelling your name. I am really sorry about that.
>
>
>> Just a couple of syntax corrections. The code comment could also
>> benefit from this.
>>
>> Otherwise it looks OK to me.
>>
>> > Swap subsystem does lazy swap slot free with expecting the page
>> ^-a ^- the expectation that
>> > would be swapped out again so we can avoid unnecessary write.
>> ^--that it
>> >
>> > But the problem in in-memory swap(ex, zram) is that it consumes
>> ^^-with
>> > memory space until vm_swap_full(ie, used half of all of swap device)
>> > condition meet. It could be bad if we use multiple swap device,
>> ^- 'is' ^^^^^ - 'would' ^^^^^-devices
>> > small in-memory swap and big storage swap or in-memory swap alone.
>> ^-, ^-,
>> >
>> > This patch makes swap subsystem free swap slot as soon as swap-read
>> > is completed and make the swapcache page dirty so the page should
>> ^-makes ^-'that the'
>> > be written out the swap device to reclaim it.
>> > It means we never lose it.
>> >
>> > I tested this patch with kernel compile workload.
>> ^-a
>
> Thanks for the correct whole sentence!
> But Andrew alreay correted it with his style.
<nods> I saw his email a couple of hours ago.
> Although he was done, I'm giving a million thanks to you.
> Surely, Thanks Andrew, too.
>
> --
> Kind regards,
> Minchan Kim
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-05-11 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 23:41 Minchan Kim
2013-05-09 20:15 ` Konrad Rzeszutek Wilk
2013-05-10 8:44 ` Minchan Kim
2013-05-11 1:18 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPbh3rsVnvEmH+sRoRYjGi3DERMkzFPmOn=a_Gt0uAMnLLmZJg@mail.gmail.com' \
--to=konrad@darnok.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=shli@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox