From: Nick Piggin <npiggin@gmail.com>
To: mtk.manpages@gmail.com
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
linux-man@vger.kernel.org, linux-mm@kvack.org, mgorman@suse.de,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH] Describe race of direct read and fork for unaligned buffers
Date: Wed, 2 May 2012 10:34:42 +1000 [thread overview]
Message-ID: <CAPa8GCC7tHm_8Ks_=tM4x544+SEtkVk6TMAF3KPsVqzNOi-naA@mail.gmail.com> (raw)
In-Reply-To: <CAKgNAkjAOGM+mZLkXGiDFYsnMCpJsxx=Nd5pZfx-_f4B1jvh+A@mail.gmail.com>
On 2 May 2012 03:56, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
> On Wed, May 2, 2012 at 4:15 AM, KOSAKI Motohiro
> <kosaki.motohiro@gmail.com> wrote:
>>> +suffices. However, if the user buffer is not page aligned and direct read
>>
>> One more thing. direct write also makes data corruption. Think
>> following scenario,
>
> In the light of all of the comments, can someone revise the man-pages
> patch that Jan sent?
This does not quite describe the entire situation, but something understandable
to developers:
O_DIRECT IOs should never be run concurrently with fork(2) system call,
when the memory buffer is anonymous memory, or comes from mmap(2)
with MAP_PRIVATE.
Any such IOs, whether submitted with asynchronous IO interface or from
another thread in the process, should be quiesced before fork(2) is called.
Failure to do so can result in data corruption and undefined behavior in
parent and child processes.
This restriction does not apply when the memory buffer for the O_DIRECT
IOs comes from mmap(2) with MAP_SHARED or from shmat(2).
Is that on the right track? I feel it might be necessary to describe this
allowance for MAP_SHARED, because some databases may be doing
such things, and anyway it gives apps a potential way to make this work
if concurrent fork + DIO is very important.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-02 0:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 9:30 Jan Kara
2012-04-30 13:41 ` Jeff Moyer
2012-04-30 14:30 ` Mel Gorman
2012-05-01 5:50 ` Michael Kerrisk (man-pages)
2012-05-01 6:49 ` Nick Piggin
2012-05-01 14:31 ` KOSAKI Motohiro
2012-05-01 14:37 ` KOSAKI Motohiro
2012-05-01 15:11 ` Jeff Moyer
2012-05-01 15:34 ` KOSAKI Motohiro
2012-05-01 15:38 ` Jeff Moyer
2012-05-01 15:50 ` Nick Piggin
2012-05-01 23:51 ` Andrea Arcangeli
2012-05-02 8:17 ` Jan Kara
2012-05-02 9:09 ` Nick Piggin
2012-05-02 9:18 ` Jan Kara
2012-05-02 19:14 ` KOSAKI Motohiro
2012-05-02 19:23 ` Jan Kara
2012-05-02 19:25 ` KOSAKI Motohiro
2012-05-05 11:28 ` Michael Kerrisk (man-pages)
2012-05-05 15:29 ` KOSAKI Motohiro
2012-05-08 23:10 ` Nick Piggin
2012-05-09 5:35 ` Michael Kerrisk (man-pages)
2012-05-09 7:01 ` Nick Piggin
2012-05-09 7:18 ` Michael Kerrisk (man-pages)
2012-05-10 15:00 ` Jan Kara
2012-05-01 16:15 ` KOSAKI Motohiro
2012-05-01 17:56 ` Michael Kerrisk (man-pages)
2012-05-02 0:34 ` Nick Piggin [this message]
2012-05-02 3:04 ` Hugh Dickins
2012-05-02 3:10 ` Nick Piggin
2012-05-02 9:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPa8GCC7tHm_8Ks_=tM4x544+SEtkVk6TMAF3KPsVqzNOi-naA@mail.gmail.com' \
--to=npiggin@gmail.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox