From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225DBE77182 for ; Wed, 11 Dec 2024 17:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 971526B0096; Wed, 11 Dec 2024 12:46:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 948456B009A; Wed, 11 Dec 2024 12:46:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 810206B009C; Wed, 11 Dec 2024 12:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6425B6B0096 for ; Wed, 11 Dec 2024 12:46:55 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 066A11C8375 for ; Wed, 11 Dec 2024 17:46:53 +0000 (UTC) X-FDA: 82883408286.04.205433B Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 6BC86C0007 for ; Wed, 11 Dec 2024 17:46:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=raspberrypi.com header.s=google header.b=EGFimlXM; dmarc=pass (policy=reject) header.from=raspberrypi.com; spf=pass (imf28.hostedemail.com: domain of dave.stevenson@raspberrypi.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=dave.stevenson@raspberrypi.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733939190; a=rsa-sha256; cv=none; b=8hN+tOBlkbhZ1ws+evOQzyBLtk8SrI4GkZZowDtvmfWprXtNea/GTGZbbTFcoHIN/Cn40w Dj101jaA2bpenVlVhc8ZtAPZTONQMy6alxudn6BNrHrdCp89M2hOf1YCqmZf1dQidHGiU9 zhsh7Dzw28kz86rVVWQ34ehmbcmy+7s= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=raspberrypi.com header.s=google header.b=EGFimlXM; dmarc=pass (policy=reject) header.from=raspberrypi.com; spf=pass (imf28.hostedemail.com: domain of dave.stevenson@raspberrypi.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=dave.stevenson@raspberrypi.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733939190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XX4yF9JMGXX3II/VI0ICz4h+LN+8Yz44eu6TfJ04Ugk=; b=eGd2uba5ZKz6BvnYUKBN7bodUj9DzhttllMFCx2a4EYfPFwK6iyogAAMPJGIlRgIUp+Qpz JKwmcUYSWJATj2femsGC5JxkXwrE0vo+jAEl6x0q+WCgnGDNlpJ3dHAqooqbcoPR/GwN1f IXkQPDA7UKnM4iKYYnp0vUYLGQI8U7I= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-e3a0d2d15adso4808856276.0 for ; Wed, 11 Dec 2024 09:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1733939211; x=1734544011; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XX4yF9JMGXX3II/VI0ICz4h+LN+8Yz44eu6TfJ04Ugk=; b=EGFimlXMZI3x0yActV75aA+cgscaDAlynYNbcbBqrYNyPm0Zdv1iaAgT3CfgHryjM3 U8HAPlGArwD8JCX2KNvpdbVIrv51Fhq7wdUuuTcwGFdO06F3AFp3FLVEDDzKF9fZCN70 NsEyjsbR0JHXvHJeEvuIygr8/Dy9h932s3qldNXsMI8xLqONynJ2j3ZynXBs6n9s84iI DawJR3GHGI8GZqshraOADT0TIFOb90Q8+dpLYF/rlwOaLYYqyte7IqLcm91U/D6OKYgh WekE6aklVp46+wscthpLDgHtuKevt8o98a+HvvWBnQoPPodJcH+KVffS0MSotFidMi9Q K6eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733939211; x=1734544011; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XX4yF9JMGXX3II/VI0ICz4h+LN+8Yz44eu6TfJ04Ugk=; b=eOW6IZO0iK9V+IHigBr1wpJw/MAli3ePnay8BmPCjKMTjMMJs42iHbBLsEaDuLvKtH fzcNrn6n+TMONy5LCCqaWMApPUINBge9fTNF9pNlODEsLRkJ1DipHz9FnLEfmqadYA05 8SiuIWUVxYx0bROoFUG11a5fHtlLEssErNj6fyeIbpA+ItEcaVnLdgREdSgAdijqTgGp zG92jsWgvcYFTP+mCKDtcM6alNHObRD0x6NGv+CBbGa0HiqbwkFEF1Dwxmx1u4zz1rSy +uenTqFCJlVEbyWC+1EnWXhS7CpDE9TRPBlgVqUmanGtyI1VvPghfRzfho5ELWNoMAIq mlmA== X-Forwarded-Encrypted: i=1; AJvYcCW+E0ucKe56B14eAJOcZOit8jeoclGoe1j1hlNklM2/NNZmrEN+FF+sDFqtcjtvQHtspWR7gXNr1A==@kvack.org X-Gm-Message-State: AOJu0Yy2c/agNIlJ9mIl3DI6P/croo/QEry1VxrP30vhxUEGGYIrlJ9W s6z4AArJP7CnAeQSovZoQFI0PefuZjLbDftQpiqrZFnsEdg6Jef16EjErB6CObBjr1iti792VRL /MW1vPDW+7l7T5OLadp38+GD+mJwD0Jy3IkSpTw== X-Gm-Gg: ASbGncuUUJGqHl6pk9LpIbsliacJG+FOXmKzJuGBbXHIzYDSY0i75vcvwHQJ1faMwjk JTPYIKzMRD02zJOIA2AzVQljkId3xFR1HPAs= X-Google-Smtp-Source: AGHT+IG3lDp6pcc8WpN9DOxtNpymp29steFnShZFR78LeXrDU2v7lqz7zSz8oGrhbnT8m3jrCYcj2LxsZTVFVNmSQds= X-Received: by 2002:a05:6902:230d:b0:e39:8a36:5771 with SMTP id 3f1490d57ef6-e3da3158089mr228005276.34.1733939211006; Wed, 11 Dec 2024 09:46:51 -0800 (PST) MIME-Version: 1.0 References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-16-ddfefd7e9f2a@linux.microsoft.com> In-Reply-To: <20241210-converge-secs-to-jiffies-v3-16-ddfefd7e9f2a@linux.microsoft.com> From: Dave Stevenson Date: Wed, 11 Dec 2024 17:46:32 +0000 Message-ID: Subject: Re: [PATCH v3 16/19] staging: vc04_services: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6BC86C0007 X-Stat-Signature: m963bgru1gb3r7ozgzk1pcu3zwmtsz7s X-Rspam-User: X-HE-Tag: 1733939185-657185 X-HE-Meta: U2FsdGVkX1/K0noCAvpetpvP6pVWxRUFNDflOSFNUGqAr9W8n7columstTzi8NptVjilgazaFneh5k3b8zygUpRaRn6ELZ4il+DM3ce4MBkAQBsigAIR0nvscvrovn6KexqF4Md03t4YGl5C/oVbPXQvWugob/aFgYb7DzfZvdGdzZJzUve0o+LUSPLaN4lT0mmNDBAyPxkE2W10GPFQG8dQ/NQ/x9ME4O0P7QtHBhcYFT7tjNjvJ2V+3k5fFyr7AdBhC+X7mWZLhJJ6IkkAwu8AY8ubqcfqWr1a9VoZsBu7mhQzcMo7ZwOojGoXs/KftH/cdrhb9K8ZU0HE6TVhF90RqGjev8GkksCaNlJeSBlb7nRrPQBPCpOQ7SJfrVJ3TWCDLqmFBMKl2s9IiX3D3O46pDv6vU+w+YQ2abYlqoP5j3zIyshX7FtVlJQiHqarac06dLKfowFSv9Dm+7NL+y7Y0xvu0F6cbVDSf+hbHofjfgucw5O+CZFxff5POyJo+c5DWN/8C83KfuJHrKmLBGKaA2NuaDYc9fBRjVhEaKYmpN2excgsYXQjJcrp1p3CrmIIWd5akJk05go9iKTmOgBA4dXVxeopFDRfXO2y5K8exwrNpOQmtLCXZfSRx0IJuF48DynOkZLM/vucRfC2odxUhnax+WrXBYrsxXbYcykbGIOwTvWI4+VystPQfzsBK7Nuh1ndwOGDdTaLnljSRxS+AMoTkN0a/DtTZiN4tXkJw4n9jC7qNdAHdWbnLEfS0uvKGW06dmFuiDQuwImQC660Waof0KANcMU/DQmGpTMKWJ9GjT8Uw4QGu/zMb/chfEm6EYu7ghMUZFd/UZWOW+Qec9RFGRc2M38yiJOptG95xnGDlVSE7zQvKWENBk3xzhic6jHJ410GxpBLpWxOGbXAQHdQy9M4AQzW6MnkmjzKvcmIQy9XWV0uMqjHOoqoRTbKzgxgLeYmwuRH1A5 QUbn4GDF 9qvq92EzhvbVmfsGYl+506flzfvHR8PDDYGS/Jh+/rDYprOGBds7xcmjfdF9gfwkqs1B2wRmbNOdYDvu4STwIzwwjtL3BiR65m/ol+IYs6VCCNIeYone5dGoJ7JWGrOiFv2Z0euNYjz+F82Fh0sx0MEKQqFlF/8eFa6y+Aldf+U0vv6ZL/g4LTEtMogEpDqrWwD/mtDOAKFlHa/O/SvMHT0BBlEMavTLOKD6r0uULngVaUYbVtolMKiXzReIIN8qjjFqkmR5uBctbjsLxaMK7MnJqXCsAhE599cuKuyMVjetpabnYVoYF0LaDRKQ4aaeVtrw0WDiBTcIsuqIaWXBlGUBGqfrox5ROwVQn6NryVzsLnYMMFi+GzQUGp9KGl5HD7Glb/k83V6YWEOp72cX303fcPFCzT1/Gk5wr X-Bogosity: Ham, tests=bogofilter, spamicity=0.007231, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 10 Dec 2024 at 22:02, Easwar Hariharan wrote: > > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan Reviewed-by: Dave Stevenson > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c > index dc0d715ed97078ad0f0a41db78428db4f4135a76..0dbe76ee557032d7861acfc002cc203ff2e6971d 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c > @@ -59,7 +59,7 @@ static int bcm2835_audio_send_msg_locked(struct bcm2835_audio_instance *instance > > if (wait) { > if (!wait_for_completion_timeout(&instance->msg_avail_comp, > - msecs_to_jiffies(10 * 1000))) { > + secs_to_jiffies(10))) { > dev_err(instance->dev, > "vchi message timeout, msg=%d\n", m->type); > return -ETIMEDOUT; > > -- > 2.43.0 >