From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82D6C0218F for ; Fri, 31 Jan 2025 18:38:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD02280002; Fri, 31 Jan 2025 13:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37DD4280001; Fri, 31 Jan 2025 13:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DEA280002; Fri, 31 Jan 2025 13:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0347D280001 for ; Fri, 31 Jan 2025 13:38:06 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A131F1210DE for ; Fri, 31 Jan 2025 18:38:06 +0000 (UTC) X-FDA: 83068606572.03.E9F6A8E Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf24.hostedemail.com (Postfix) with ESMTP id C9C86180011 for ; Fri, 31 Jan 2025 18:38:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cedD3OKR; spf=pass (imf24.hostedemail.com: domain of fvdl@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738348684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eaP+gwH91Q/1lKDOcaMIFE2ox2Otd3KRnpWUugUIeqo=; b=bh/rewuEbkY8cAMgm40eKOzqVIJ9fo63DDyu+6xTAy+t+Nm1SaPAbIKlN7jd6dUWigf/tS GMk8Be5PHbwbjwf/CGd4Qvo8zpLkJMq/bws6l7azlAcAsS2JLVIWyBUCCQniX+NqW6Oxa/ Jwvk8IiiWXSrbIplzr9l/exx8hPopk4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=cedD3OKR; spf=pass (imf24.hostedemail.com: domain of fvdl@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738348684; a=rsa-sha256; cv=none; b=FCqvYp7gP52xuOK/GeZSnPBrMXnvWV2N6Wk5+08DgP217bPHWOOhnQ4Bnpk6H3+ecZOCI+ bZJ8GntLzBzdP50Kmka1rFPCSlAKxCrRj5yR2DLGQYAMMbu/lQ/uguFacXMcypVB4dTNK/ G01RZn9zYBQfzViWq/yWgkb7gSmpGXk= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4678c9310afso13161cf.1 for ; Fri, 31 Jan 2025 10:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738348684; x=1738953484; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eaP+gwH91Q/1lKDOcaMIFE2ox2Otd3KRnpWUugUIeqo=; b=cedD3OKRUVN9BH3W7EjBLqeKul0udNLxOJBe18ta24HzSE1j44sAWvPPMK2Xuaswa7 7CgFnbUh5WxwI0Y+DJzHMqPkrKL2YhwPpU77PY/8Uvc7cFMLJkR+l3RdZ/vBo83E3QFP 6/tDK8LB9z6fBt54xC3N19GZ1ehYqYKvyPjtfdkQxsPhhB6Omtas9u0KSuKvnBnYQcrQ +63G9e0l8Xm+oOg+w0HOgHaxLX+YtepZ9zFcnwpkT6K619xJGs6wQ+4zdcdEzX7pmdXz TIomXMdI5dR8J7SkoKDD4b+L7eXnvGtIv9+8yYnP9g90Fe4aliryWlb3bg/IF4eLcGYZ slBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738348684; x=1738953484; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eaP+gwH91Q/1lKDOcaMIFE2ox2Otd3KRnpWUugUIeqo=; b=C1rSLmbdwfc0fKFbA+oQn3XCUu+jBEl9LIfH089xrXervKdisqQvbpDWMcMQbA0+zO mV7GU92qH7pm+XIrIs7lgE7HPrMLALh51CTETergAr22poyYdpkLbDnmm594r1akWCzD H+J2oHOdcNbty01KN8Kc1sI3C1pH2XZbnZKJh5n9PeWiMW5MVvyPow4IlqnY9gSTLumk LYygV2v0kd/gpM1o9cb1plrraXfDCafACNMURFQ0nwAafBOM/+IJkPb7tApORId4yt8d 8OcPj/h6I1nxbD5f1fWgI4J7OV7563od6RcF0hbz1y73UA7wH5PzZefCYGksnBdy8pMH xOfg== X-Forwarded-Encrypted: i=1; AJvYcCWBjO2bM/kVbU9OQnXQ10PIjcphnDx+Tg3XQE0xPcRouf4vKIcBNOLlzoUsNc7tpFURRTqMxpn2hA==@kvack.org X-Gm-Message-State: AOJu0Yy95C+nwEea5ITQ1KvmpNtZrVd5NESR0+/n7ZQUzQMZVWuuGyAA wtLgmMmhJHBMOUBs8RNtodGCDIRvyVE57js2pjXM1QXbc4YqQQla1mhNxcK7jzK2NphMcAt+GdG zkeShYit+LOWPLv3JiTgWgxo/IoE/CTaZ6gLA X-Gm-Gg: ASbGncuHw0sA0+XHoO8CnYkmCvHVgGGJb20q1nodODW1jO2STcCQDWqQDIosIaomz/n FC/5SBbBpQGuWuWFyIuPRIKsSWKc9KyC2ey07C9gboVJsdjcs5OKw6GNPXyx4jnSC7nznxQ== X-Google-Smtp-Source: AGHT+IFfaSV3CSOcY2JB0IzV54oZf2MKKy9k0ECh507ihIxazJDlvUKza7HYseCU/0FJ4dopmhsO6GtaQc1CCNfapVI= X-Received: by 2002:a05:622a:1c12:b0:467:7c30:3446 with SMTP id d75a77b69052e-46febf30f42mr3845151cf.25.1738348683742; Fri, 31 Jan 2025 10:38:03 -0800 (PST) MIME-Version: 1.0 References: <202501311137.rMiQNfi3-lkp@intel.com> In-Reply-To: <202501311137.rMiQNfi3-lkp@intel.com> From: Frank van der Linden Date: Fri, 31 Jan 2025 10:37:52 -0800 X-Gm-Features: AWEUYZmCF6mTm_-9a24eBEI20BtKTs7mvKwXGfW_JcehnmBxcs5Y0h5Mx1o-V2k Message-ID: Subject: Re: [akpm-mm:mm-unstable 61/88] mm/cma.c:811: warning: Function parameter or struct member 'gfp' not described in '__cma_alloc' To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C9C86180011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pfrzpar1aoqmrmx3k3zpu685zbsbpibf X-HE-Tag: 1738348684-820996 X-HE-Meta: U2FsdGVkX19MGGItGSyIX611hKFvXf1m46hMGti2PRfMnCabU+EoYhYLx2+pQtLDYPVX4hl7z8IQnb3CVRWQySVBHC/u6UdAD/Ka5ns2RC03jERO/WHABKOp0PoPK/Q6fBcqYVSHhL6fd5uoSUhq9GE6bKqVFKhTvNyzb9WY4uyI1oRc3kTS+sLPL3dfL497K8ziVgft6vqpZyRqDbQsfvUEaiQO+59DX0+u6V7nEazS1BVlDDAhtn1R+i5jvxj65iioQWI31e8/kuagvUIX1zpA17r1y06mdERedv+ORB+3vwh9yhSmp8UkVr8yDjICmbNfTOvV/hU3krZzJmDoKU4yu66PE3SJIf4KZ+cAPSTijhadIqewqReZKI57+34EdAJAex6vkOQOoJNBKEbnrzcQ9umdC4vkycCjDCuaz5jU9YVL/1u4VaFZoUVpFZFeQfxbZ6H/Hz/KEXTUj4s4kqXFl2gilgdDs1mAuUqikYY8PWq5DXZGlmjiTIaY3MxqdsPX9n6BNvG5LTZN2PGHNQkZKZmA6tbu+IKN+yfAnIAYACBZV1gCTJ/o0uztUbSQF6BMPPya0l+tI5LmS6yOiko9iypcDow0moA+qHHE8Cle3Nlig70H56wsoRbrlAIEgUdxl6PdOLZkbeziexIATkO3q32pjXzbaUWyZiFB0pABgfFHlafQGnvRacZncJLchNRdtgrgtL/19hUT9cVFvd5TADgrJ2hYj412quMa1BhMm8jNNz+0qxD9wHxKFOoHnx6znyPmiZro1flKWpwez1cLZHDeXf8W0WVAIiHoIq3po4Oy/xqYqIPnuftJBwpCHsYv6Znt3FXBo+d9zHVLnLuFDWQJ6ZEmjk9ExC/LxWa/TkOYRdc6Y7XHU/B6NUu2FgjdlJy0T+czaP7PYwnl/Cb7cZA0ZHe1gl5HJ0qbOxHwIutJ2PcXmsr4Oeo/GY6Il2ayOFYXAeWaUWNFije YPCRK5Eo MYs5tCyztgulcDGKs34pSBnfKW9piHGM1Hu21LtJieoaBD6SIQiY5XxMHcVXKvM2roXOTyDacvl7nnTvElaT4EcwXdAluJNY+O72ItSDBDT/3XhTLrGeErJ5mmEDjKUOpS2PZ28KWnZ62uIzGweoQwMlX+qPurfZzZE30EbUDmxD8Pe8D1QahQABqfFJ3Ian0atc2dpFoatCGzWw09k25jfOTjUGgAeagUOMsmq348GJrJX1qNF/knqZ9UMSdNxJPZMFYl9RGaIGXzdWIZ0/w9DwHS6U+3C8q8yHwtf6KNvDQ9J8kbIDg4ViAjFO2x0OLRPJmmcEm0TXb+VoCAKqgXiUyDaCKP0JVyG8EXrYbbUGdqAJwas4ghpRL0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 7:23=E2=80=AFPM kernel test robot w= rote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: 495206a68b359eb6117d0860861578113bbb94e7 > commit: 77cbd63e91fa6c5f6157a30e61a380b6c47c1443 [61/88] mm, cma: support= multiple contiguous ranges, if requested > config: x86_64-buildonly-randconfig-001-20250131 (https://download.01.org= /0day-ci/archive/20250131/202501311137.rMiQNfi3-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20250131/202501311137.rMiQNfi3-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202501311137.rMiQNfi3-lkp= @intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/cma.c:811: warning: Function parameter or struct member 'gfp' not d= escribed in '__cma_alloc' > >> mm/cma.c:811: warning: expecting prototype for cma_alloc(). Prototype = was for __cma_alloc() instead > > > vim +811 mm/cma.c > > 798 > 799 /** > 800 * cma_alloc() - allocate pages from contiguous area > 801 * @cma: Contiguous memory region for which the allocation is p= erformed. > 802 * @count: Requested number of pages. > 803 * @align: Requested alignment of pages (in PAGE_SIZE order). > 804 * @no_warn: Avoid printing message about failed allocation > 805 * > 806 * This function allocates part of contiguous memory on specific > 807 * contiguous memory area. > 808 */ > 809 static struct page *__cma_alloc(struct cma *cma, unsigned long co= unt, > 810 unsigned int align, gfp_t gfp) > > 811 { > 812 struct page *page =3D NULL; > 813 int ret =3D -ENOMEM, r; > 814 unsigned long i; > 815 const char *name =3D cma ? cma->name : NULL; > 816 > 817 trace_cma_alloc_start(name, count, align); > 818 > 819 if (!cma || !cma->count) > 820 return page; > 821 > 822 pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", _= _func__, > 823 (void *)cma, cma->name, count, align); > 824 > 825 if (!count) > 826 return page; > 827 > 828 for (r =3D 0; r < cma->nranges; r++) { > 829 page =3D NULL; > 830 > 831 ret =3D cma_range_alloc(cma, &cma->ranges[r], cou= nt, align, > 832 &page, gfp); > 833 if (ret !=3D -EBUSY || page) > 834 break; > 835 } > 836 > 837 /* > 838 * CMA can allocate multiple page blocks, which results i= n different > 839 * blocks being marked with different tags. Reset the tag= s to ignore > 840 * those page blocks. > 841 */ > 842 if (page) { > 843 for (i =3D 0; i < count; i++) > 844 page_kasan_tag_reset(nth_page(page, i)); > 845 } > 846 > 847 if (ret && !(gfp & __GFP_NOWARN)) { > 848 pr_err_ratelimited("%s: %s: alloc failed, req-siz= e: %lu pages, ret: %d\n", > 849 __func__, cma->name, count, re= t); > 850 cma_debug_show_areas(cma); > 851 } > 852 > 853 pr_debug("%s(): returned %p\n", __func__, page); > 854 trace_cma_alloc_finish(name, page ? page_to_pfn(page) : 0= , > 855 page, count, align, ret); > 856 if (page) { > 857 count_vm_event(CMA_ALLOC_SUCCESS); > 858 cma_sysfs_account_success_pages(cma, count); > 859 } else { > 860 count_vm_event(CMA_ALLOC_FAIL); > 861 cma_sysfs_account_fail_pages(cma, count); > 862 } > 863 > 864 return page; > 865 } > 866 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki I see, I left the description block at the top of __cma_alloc, so now there's two of them - but it only describes cma_alloc correctly, since that is what it's supposed to do. Will be fixed in v3. - Frank