From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F08CF8852 for ; Fri, 4 Oct 2024 22:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5941B6B0325; Fri, 4 Oct 2024 18:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F57A6B0326; Fri, 4 Oct 2024 18:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3963F6B0328; Fri, 4 Oct 2024 18:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1084F6B0325 for ; Fri, 4 Oct 2024 18:56:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A7E631A0481 for ; Fri, 4 Oct 2024 22:56:12 +0000 (UTC) X-FDA: 82637429784.22.D9B139C Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf23.hostedemail.com (Postfix) with ESMTP id D2AAB140006 for ; Fri, 4 Oct 2024 22:56:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XXUaGWR2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of fvdl@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=fvdl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728082474; a=rsa-sha256; cv=none; b=RkDw+scj21BEr6sbNnoRV5MaJV4FCroBbZZo+enEt6OUTdVnIE9QYi72BTSHQbDQpzca7y Ad+Enz++VUOGyWKUDMvdUHvqC130wXyHE6p89sEgsLKLTArLi9rytQZ6VToRYToF6ykcAC QIST4iFQZ9qzkHGLLhvum5PZuDsm4E0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XXUaGWR2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of fvdl@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=fvdl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728082474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gQLY/bzdHQr84xbdr5RKXt6HWhOcNV2GLWNFgYSMKcg=; b=IVuw4IRlG6pnxynlDdiLIAJQFxnQmt1owuSVLe+lq3t1xOUVNwLo6hc0TM7826FmcH/Q7a SIoY+UwaQBmS646/69gfnOvtJB7VE/zqm2QDSXqRhJn8ZRaQofoYXwIEADDAhFfwgjjP/x m23tA+BRnO1ZKA+p/HfvJW4MMzcaY04= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c87a7782beso3750a12.1 for ; Fri, 04 Oct 2024 15:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728082569; x=1728687369; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gQLY/bzdHQr84xbdr5RKXt6HWhOcNV2GLWNFgYSMKcg=; b=XXUaGWR2ilZKIWcY0jaN9ik8zVOsXmx7l41qp1aGWB7wVuLKjqrQN3c80/8LDKwefF u1o5J1BdEuO5IjJDaYT+TsTfjYWG0/TieGEk5TSmzRG+BVejixpVGQi4xAaqUCGq8Xuo e0x7xkWT6uxx06YPUHXEOAPBccwyZuLoCY7Edi9tloyJxMur+M7ghdyab8UQ5OgYiAYh XDPAmgj/ug0HcIr2ofCxwKdjn0NX0MDEUknGvfgk93aH3mM6AOHLmCTo+ru9GfzMhTf3 QgztdZIORRo8okieRv3xXt1GQnQHpcya6qVQvfJQYQoJk8NZPKJI4fItBLHJPKB/3jXy 7YHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728082569; x=1728687369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQLY/bzdHQr84xbdr5RKXt6HWhOcNV2GLWNFgYSMKcg=; b=Zyd/WF3mK/4nuBJ+yS2bHkHvllMqo8Y5yGwgjBIQxsHo0m2x7MbU5A7/CG12ntQFTB EQPAHdwHgURvlaNEeRmrYRE1z/CQMMAjfksdR2ZZT/ev/wuGY6T3F4jUoex04tvSWRqr lYnm4Jom4VooGjoL+azSHhcX5dR9MHK3zyY74Wz7YRdGOlq1W6J1hCxpkWTCwuiBrPV5 Mwf1L25YgtJGJG1KNg14p3b966KraA4AArWgi0R5S6UTNaneq/DroeXZLDO12pOik3Vq EBF63lVgN0i7BopYR5zvaovEYFqulVVyBA3QrdzO9r+5muwEjsI+uoEPC6e8L9eBrLLH 54fw== X-Forwarded-Encrypted: i=1; AJvYcCVPkG6l/jXif4+3pG+ZKY5kgFV7/AOLutzNEkDck29FFpexW8OzyHBuh0H0eNHkRdON0ra67i07Gg==@kvack.org X-Gm-Message-State: AOJu0Yy8o0wqq4sJ39kssTCo7ZmGH2k2LSexUk6RV85TYhIA6strUR1a TY03GHx2zDrqLc+LVNTHfEUPGWSe0S8uJkTbgJaVmjfoKk2OoIKXhH5IfBfxpxM0MWGnZxaop2w 6+hL6x6BD6WdIQ1O8HmlzpXQU/9uCnnFwBcdS X-Google-Smtp-Source: AGHT+IHSO2el5qL9P674iQY9ZloirwLUiBzDbJUnWRKjEj5nvXFcgHqvTMo05KadChLcVL5eF6f3PkKFz/T79PcoJqY= X-Received: by 2002:a05:6402:4301:b0:5c5:bb25:5a9c with SMTP id 4fb4d7f45d1cf-5c8e1e989eemr51685a12.7.1728082568844; Fri, 04 Oct 2024 15:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20240929032757.404707-1-gxxa03070307@gmail.com> <2a7b7fc3a48d4bb9a6394e51af074017@xiaomi.com> <20241004153947.43c5b16b7f75b0f60e918019@linux-foundation.org> In-Reply-To: <20241004153947.43c5b16b7f75b0f60e918019@linux-foundation.org> From: Frank van der Linden Date: Fri, 4 Oct 2024 15:55:57 -0700 Message-ID: Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW0V4dGVybmFsIE1haWxdUmU6IFtQQVRDSCB2Ml0gbW0vY21hOiBwcg==?= =?UTF-8?B?aW50IHRvdGFsIGFuZCB1c2VkIGNvdW50IGluIGNtYV9hbGxvYygp?= To: Andrew Morton Cc: =?UTF-8?B?6auY57+U?= , David Hildenbrand , Xiang Gao , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D2AAB140006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: trgujy1c8r7yaqrg3z1zsdyg9aq4sast X-HE-Tag: 1728082570-779439 X-HE-Meta: U2FsdGVkX1/4BP4qKjHeO5m8gt4HUgewXcl6Q0CEJm5RylYv8Y5vIiN+XhFzqK2+hPOj6i+RXk9EuQxBonZSH3nJ70rJ2vM4Lmj+MNJokY9P+TvORHCNfN5iUYjs6UIXbMn8U4pFifwTM/os/jafYHrtRFZpNvCAJRNS2CBlhPrlECoyRp+w0/CYSwWSdoe/8KED2LscYS5GFVZ8nh88wozfxyW4Vd46qA0uVY9ChDbJx306OirPkYhkoSKYUChDNVNGEryYhUZC2m7BQefAMe3El9fYKrNrutIw2AHWV3VRNrG68lymAx3COQ1MpSRx8Af+b37IfvYVcd+l6KYwlFHe3Gb/JIxEYNpx/HqFLt3P3BDDsC+pwtnLJk+8B0l4arzVg3yE+VdXs9n5NMlExIubcK9zOX+UuFWH0NYeVrOqzYXeEiersNby7eshgU0y5ue3zDrWYPieAoOLSHvBbQBlOABNmuO2gJbAnwQPZs3YLbIWu58PHoxJgNfyPI2MXnkStG2jLGdefETnSCimrB1vnNKfRarnGZgf8+1X0CH/jOLmlq3u6q9sfN73PTZ926TjRVQbUJrQU8nUDHg1XyHAMEgBI11KecPoLyNgIyVspxFMVmtOTLt71C4pI386PKK7q6/LXE8dNbInuSpNGuXxELDHTciHWmw4cMG7XxH6p9fnCdOoDBXZNYUWXh9scKBdeqduz+Hj3PcqzB+NhsHi5bsJQbaj0nbGiz5fGx1+2sHFfr8/LC6s6N3KjMmuJpkQ3mDmxLHxWXMRId9MXtCsEVrUpAWMMzieYaD6MzMB6knIO83pxhVGaRDPCbXMY9IC9LpUmkU9brprH+5bxA7CsP027DcE7FrNZaFeIlyW9NoqDG99OxYmTerJZAplfPwVWm2x9upNsc0ahmKfgIz92AexwmezAS8jl6xxMR0KE8zj5D17/MtjeuVFf1A1CakXonva+PR2tvZrteh /uliWFLF 0uw+McrpKrtFDWsi+ccT17j+yoj5p+eH2GxXNf9yiEhI1gnA+D4kwrnTnwVGQYCJwtTDKaHTMUanCBKIkrmc4CuZD3oxSKJC3KqMIihLK/o4dUx+DM6a7U6uUBlsdlvc3HvOO4dAKxn5eud5npCvHdtDZ3MP54uqD3NNy1sLuFry0Q7Rt3WuFQOG8ApusEQ28VO5eq9HP3rXR/1HKX7FMkC/84C/gMjTnS3kqd251qvFZpszRfvGZU9uL8a9ozZJMpJdcOAYSbVj5xoIERdQ6WpyWiLtiUTqtR65aygQILAvtnM6W9e4okJVTIY/fr4MAmsvofNFWjOVTmzNs11KZGkua0khvUZ1MLd2FCnzdTAmaTwKQo/sVUk3hPaLZNJ7LpnMKJzjSQtYvWhvhsUXUAcD/KO09A0FesNteoBC7F1eEu1sEX35tkAG+xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000517, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 4, 2024 at 3:39=E2=80=AFPM Andrew Morton wrote: > > On Fri, 4 Oct 2024 12:23:30 +0000 =E9=AB=98=E7=BF=94 wrote: > > > > > +static unsigned long cma_get_used_pages(struct cma *cma) { > > > > + unsigned long used; > > > > + > > > > + spin_lock_irq(&cma->lock); > > > > + used =3D bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma= )); > > > > + spin_unlock_irq(&cma->lock); > > > > > > This adds overhead to each allocation, even if debug outputs are > > > ignored I assume? > > > > > > I wonder if we'd want to print these details only when our allocation > > > failed? > > > > > > Alternatively, we could actually track how many pages are allocated i= n > > > the cma, so we don't have to traverse the complete bitmap on every > > > allocation. > > > > > > > Yep, that's what I did as part of > > https://lore.kernel.org/all/20240724124845.614c03ad39f8af3729cebee6@lin= ux-foundation.org/T/ > > > > That patch didn't make it in (yet). I'm happy for it to be combined wit= h this one if that's easier. > > That patch has been forgotten about. As I asked in July, > "I suggest a resend, and add some Cc:s for likely reviewers." Indeed - I certainly wasn't suggesting that anyone else forgot about it, it's up to me to follow up here, and I haven't yet. - Frank