From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B86CD1284 for ; Thu, 4 Apr 2024 22:02:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13BBB6B0099; Thu, 4 Apr 2024 18:02:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C52D6B009C; Thu, 4 Apr 2024 18:02:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E81306B009D; Thu, 4 Apr 2024 18:02:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C714B6B0099 for ; Thu, 4 Apr 2024 18:02:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8A07F1A00EC for ; Thu, 4 Apr 2024 22:02:48 +0000 (UTC) X-FDA: 81973224816.18.665F9CA Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf04.hostedemail.com (Postfix) with ESMTP id B14AE40011 for ; Thu, 4 Apr 2024 22:02:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fHWHTtwU; spf=pass (imf04.hostedemail.com: domain of fvdl@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712268166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q44r8YNnwBBzcVeMvOuZdTWviDpJk8KZC7XRWs+Uvvo=; b=QEOD0adIEDz8g4DIDw2Hr5oTwscFxrFM06I5HMRF2GprJ4Or0qj163dsfpXfN6mrNvD+jG 9M/7y+djNi9+t+PnCBMavHI7HK43/97bBk6rNwYGFzsZNWPV41uE6ZHPNiqyVG6Dundazl u0RaZ9T2gyFaBwdQIXS6FBwJGg7KZ8M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=fHWHTtwU; spf=pass (imf04.hostedemail.com: domain of fvdl@google.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712268166; a=rsa-sha256; cv=none; b=ccOg0dWUObBk61AgO4aQ1ECoLhpKZbD1tUJYDzi+EuHLkWHLtn1oHHwIMzjnwluNO5SHUL PuZAX9x3TqBvR84XCUc472Qa7RcO7Ldr75FNYZfqKd9/wRGZHUgWlPvLnl3ovpzhUjN7ix C0aTZ0Ig3wrhwUNYEhF8IA6hVc6ysLM= Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3c396fec63aso624958b6e.0 for ; Thu, 04 Apr 2024 15:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712268166; x=1712872966; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=q44r8YNnwBBzcVeMvOuZdTWviDpJk8KZC7XRWs+Uvvo=; b=fHWHTtwULsiyTma0sG18Uq3u5db2lsMWAkaUnMILZiXyBqu7TFvDcBKwA24xFeMM1y xfXZC/VBnj8M+F65AtNN2Nl9Qx24ojefJ4r7zkG++mahRCmAw2hGJIsUAjqPD5Ul0nFu dqY8sfoTOjduzmcRKmIohMHI+WYoDUWwEYG7yXUKG8fH2Wm9QQpeelFYulSDOof/B+hx QJLKh57vPUSXM1cY1aqVGdvjZ8xyw4/6j0OvNmwqaHnG5FKpgq8Ee6+WE3QwQgZ/7sRq hSrYsaCorgpdjp8hTxbfO7F68JWflJFjniUJ9+4QcJgmQ9B4I3DExTLlylOWrJ3T9LjB g5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712268166; x=1712872966; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q44r8YNnwBBzcVeMvOuZdTWviDpJk8KZC7XRWs+Uvvo=; b=v5y/U1d80W4JrxOXpwSz7/77TFWKiv9AY0zDI6Y6ZaFn1G+GctFh31D84iF6pNs4B5 QpsJ7fEZhPmYGcIoV+tZrmOub9nJ78YEpIyihfXo3Vr/6Hg0RYjq2NNVVQlxfPlemhQ0 91eLdO24CvdEt/F4W1zzpVdXhzSEb6rJRaj2VBSfFZxoSpMxO0ZC3GrnjsWIYypq3+MO kebNGncBS1hFTmcligPkLzV9BQty3KhdkjBlXu7/ZFXwU9IYQNd21VJ6vdmC1bGlvW22 4E2kgMMTY5KixtMcv8panJQ6RzIU/y6+EKQyvRYp1KeRkwAH50xYiuSRKDkdjn0Gkpte rEfw== X-Forwarded-Encrypted: i=1; AJvYcCWKcwHaT0uOVPQ8VZFqZJOLssTwYJxnYKmEPTXJJTfg+3rkYw+6N2wraONSrZQ6y87TNxWLC75h5BajAPUegWUGRpU= X-Gm-Message-State: AOJu0YzbGfI+Npez4ZT6wSFeaIP+memYnN6PhTwX0Tzuu+mqtKW29fHg 27FKu6h+mOARylxtphAMN82QxGhZv6fi/AWlVQppwYjOTrkBblRi1dp+EJKfCsqXDdpsniBkE+6 EhfUe8a1kFlAz4uiTqOtc9sEI06xGf7Har/CI X-Google-Smtp-Source: AGHT+IEjJYsFfUC6UHXPnJ7kUCMnskRfiGpUt22qAed2sk/omt+vEb3Hpy6oxbJiGfjW55DOs4/dXz1SruMUHW4e7Ic= X-Received: by 2002:a05:6808:23d5:b0:3c3:e03a:d7 with SMTP id bq21-20020a05680823d500b003c3e03a00d7mr4175624oib.11.1712268165643; Thu, 04 Apr 2024 15:02:45 -0700 (PDT) MIME-Version: 1.0 References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> In-Reply-To: From: Frank van der Linden Date: Thu, 4 Apr 2024 15:02:34 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid To: Roman Gushchin Cc: David Hildenbrand , linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B14AE40011 X-Rspam-User: X-Stat-Signature: 143rfkrsjqw9e9kgxiew1549mpundads X-Rspamd-Server: rspam01 X-HE-Tag: 1712268166-846133 X-HE-Meta: U2FsdGVkX19cQonx9CMwVqCLAPD2PcaAzjtiPbkX9X8GzLavyYp4SVYk21kFtHkj+6LfJ+YQ1w5YMxP2HpI+r+IttfGo+KoAfqTuU7D6cEJoguGlM1x1uQieuQkhWQEld7iHCJzvUMLwQx+ULagwbBxP0mlHktZN3zmyCN+GIuPe3NXmaLY3uESCgv4KqPQu1uts6w3a9Sch5e+6PDe7OzImMDPiCJp1o8AJv2ySE3DlQWCjA+FwrA8H9IWwH8fK6Ivg/gJyXDcJdTpKxzOGVbNoAI5rCLFNyRGEXXpf3TUifwjTQptqCG9jsxYNgyVt6ZykS1b7nhSjIPPljxRrrxQy9eXurwcJaKQuLCYk++D4a5HOM9QHW0vLZyBDWWsaZT+52/tgi8dUiJIwtJEe5bCGVmSgV6dtrSmv/qSP+yFcouaxaJYJi7yuZDVOHy9kbTjagFnbZKD+PCtlVxzPr6NKnwwI0BTXcuBKfs20z7IayJjo5ER9OOyel/u4VCdPGefYQqldpz6gsUn3YpSWBmIZCrm/JiIJ1afyDiVVbnM024j3+c3Ic3pIeStnhSAR3lyhi+1GW8yzDhz2erLfXoAOr9v/Ra0ms7r0P8vAMANe1R8ocjvNE0tDXuPbyOd5xl8ODjEwS2SRJJbYozM9sSFxRI1yCT+cPs/VwzZfyTo4slHOTOI6UxRROC0SvXXySDJ6fQxIxUNbC2/yGg6udbhM09NrLCx5WGHZiBEY+3BfKRiWHVZ1nvnGtP4PeFNNpBn4E8zjONio335ZBoOdb0dnPSlPhcf3Pa3u+8Zsd6KBswnsw7cl0FhjjrsLt3mVqcJUSc/B/l6zXiuPfOzUHxIYLKz6PCihyv9RF9My84znEydwa2LSZoWChszP403QNTl+MU0zjUbyHl4aNjx0HkSWnAkMzUC6U+PIFpQLvmyH1ZHndFW76IJXGJAI4xoX9aKQ832wG/w/ETZY/FE XUf5o5F8 LmI8chGpg+MyKUq4EZBg2pJBZV689WVGjnW27PhlzdLjITDvd2xuLXRjL2Yvtuy16oU/evzm3t8bKm9d8Afa2yhebXxqxCCVNKeKPzKLeAYtrHwmBGiMn2aFtBVXYkrziTMshrn7mmNFlLMJW2yeU3Tj8oFpBhDkYAtSeWbG3bVVTmbZq0ST4QFW43dk2/7TjhJhLh39ORFHHcZ13IJ3FU1zx1zgJqw3Kjh/ddEuS7jeBBRK/mE5UJ36XRquvy4NiUzENnv7lawv418DJ9DW5Co4Hn8S6S4Lnj8XMCQ1PlkEua18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000050, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Rushing is never good, of course, but see my reply to David - while smaller hugetlb page sizes than HUGETLB_PAGE_ORDER exist, that's not the issue in that particular code path. The only restriction for backports is, I think, that the two patches need to go together. I have backported them to 6.6 (which was just a clean apply), and 5.10, which doesn't have hugetlb page demotion, so it actually can pass the full 1G as order_per_bit. That works fine if you also apply the CMA align check fix, but would fail otherwise. - Frank On Thu, Apr 4, 2024 at 1:52=E2=80=AFPM Roman Gushchin wrote: > > On Thu, Apr 04, 2024 at 10:13:21PM +0200, David Hildenbrand wrote: > > On 04.04.24 18:25, Frank van der Linden wrote: > > > The hugetlb_cma code passes 0 in the order_per_bit argument to > > > cma_declare_contiguous_nid (the alignment, computed using the > > > page order, is correctly passed in). > > > > > > This causes a bit in the cma allocation bitmap to always represent > > > a 4k page, making the bitmaps potentially very large, and slower. > > > > > > So, correctly pass in the order instead. > > > > > > Signed-off-by: Frank van der Linden > > > Cc: Roman Gushchin > > > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugep= ages using cma") > > > > It might be subopimal, but do we call it a "BUG" that needs "fixing". I > > know, controversial :) > > We probably should not rush with a stable backporting, especially given y= our > next comment on page sizes on arm.