From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA9EAC021A4 for ; Mon, 24 Feb 2025 17:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60AD228000C; Mon, 24 Feb 2025 12:00:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BADD28000A; Mon, 24 Feb 2025 12:00:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4836828000C; Mon, 24 Feb 2025 12:00:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2744C28000A for ; Mon, 24 Feb 2025 12:00:48 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B996D1A18E1 for ; Mon, 24 Feb 2025 17:00:47 +0000 (UTC) X-FDA: 83155452534.26.3060FD3 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf02.hostedemail.com (Postfix) with ESMTP id 59F4E8003A for ; Mon, 24 Feb 2025 17:00:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UoNMxr/Y"; spf=pass (imf02.hostedemail.com: domain of fvdl@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740416442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aCDPYfQc9hPFOiWzrMrQ09gp/CGBhAXiyMFfJAzvH6I=; b=S6FaXYso5iaCLDqm3im0jR1qvNyYuOIImyvP65mMAeI7p5MMWoprURnq/GNv8ehd+weUWW uScIM5ZiNPz8+cH9MsYMjaf91IFp6XbQEzz/8/AI+yxEBGz3MX7SnpjoPMe74CJWP1ZpLr ZuLhlBhAWUssuqLMC4ZYkayN7PVxzTA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="UoNMxr/Y"; spf=pass (imf02.hostedemail.com: domain of fvdl@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740416442; a=rsa-sha256; cv=none; b=ZEoMxzbOcueNfgkjd90ypyTtiN1BYlkudM8WgoM1c64skuS9G5BRC6/XMjVQTh09cQ+LRB VaMi9F0ispKIQa0G+j3xixy/EM4gk5Ny0/KnaVKSQHP5EG2t1uGHjHS7Mddzhzy0S5acRL l9a9kNCUQZo+To+oYPmbagqmhDqgMCo= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-471f1dd5b80so423821cf.1 for ; Mon, 24 Feb 2025 09:00:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740416441; x=1741021241; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aCDPYfQc9hPFOiWzrMrQ09gp/CGBhAXiyMFfJAzvH6I=; b=UoNMxr/YYeXFHvr2wPBUA3HqdF+1tJUCTx2RM1YqvJHsISPxOuIGl7T6wo6qz4TXj/ LLA3EysXElGQEkMp4wnTzlj9xd51z+vtR7aL0b/75YSQWQXkm+zoKmE7qmCrd6R2kdw4 RZevQFa/R6eFSC6t1/ycD+DjhPaSjQHKvKl5VcmGy7GuCUM5V9Mx2trRarLEwr7b+/ee zWfZl8RJoPm+4zW3AYrj/NqY3LCpA5xv2uPfQ5KdF61q0Xp1Zki9Sdn/HYLLOcFBiaaz 6/mE8n6zAknFPGO7kU5JJsH/8YPB880U1qHevVrbm8t5ArjpUTlWE2kLmxdKnBno0Y2f PTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416441; x=1741021241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aCDPYfQc9hPFOiWzrMrQ09gp/CGBhAXiyMFfJAzvH6I=; b=nit0LE1e/yX1DC5EzBAuPPSYr4C8ScxOp/o3qtFlOvOPu5yOGSOnh3Ssna+1d4EWhj Z2830KzmUab4zbbfKt3ZbNIi9815zNamj2Hm+a/H0v3IivJWnY8nqeD9Lc6dZ708YDaX bhLQffQvxgXbH24L+34mB1G1qIUJHLRg5UymyFEPMPFuCG3C89fR/z8BA+7F2g5ndNyD z3f1c8Eq9IhaoLWCc5/UwheeQNoBvChQuYa/JbHKJBMWi/fdT1mh7yzoAYTd0dKmniEZ 7dyorsq5lvEvYGOlEn32VwTTco87laflnCyin3S8RYEaVwfyKwEj4rU8IAX/8y9TjK6I d1MA== X-Forwarded-Encrypted: i=1; AJvYcCXsq+4WT+31iqzC7iUdForwLLu0k5lF19sKclWTLcEnUBnkIb3RD+FtBp5sZSNaR6grEFhH4YYlyw==@kvack.org X-Gm-Message-State: AOJu0YzzBDfQwO/01urqdCGy29x+OKcZUa2/LWivAANcI8+emRYBHoye F4qWg/AGLVKfBhbRuQ4kxfHwfX8uDU1PfOefRRQ46DcCtmmv5aUWlY8mBQ9Bt0C8nZ4lAeeGobd W+2ILBoS6RTutGhiEx0yMdFtGv3Gxwt+ivusL X-Gm-Gg: ASbGnctL4QlAFeW4fXkmXdmCH2Gi9SnyHPt6TR2EIkrRt9NlAR9zb/JiRq4IXkE4KDQ vhqL6IUh0hFwyC8W+U7P+VtRJ04YlV4IMaNchjK7yutHfMHhKN7zpuhFhOw9vd+Sr3MeMx8F4Og 39REdv X-Google-Smtp-Source: AGHT+IGDiL/NzinuvOUr3+fEdY5ydwqjWixBjK5chxqAB4cgY6b/E2u3NNO77Wm/fNagSnSSnlNVN6JFC7ja6T0wMdw= X-Received: by 2002:ac8:5dce:0:b0:447:e59b:54eb with SMTP id d75a77b69052e-4723358478emr7710481cf.26.1740416440442; Mon, 24 Feb 2025 09:00:40 -0800 (PST) MIME-Version: 1.0 References: <20250224141120.1240534-1-arnd@kernel.org> In-Reply-To: <20250224141120.1240534-1-arnd@kernel.org> From: Frank van der Linden Date: Mon, 24 Feb 2025 09:00:28 -0800 X-Gm-Features: AQ5f1Jp7zC3xCebv78f9PiKcuUbXObQC3P1hoiW3UFkiO3HxC8Bls2jmj40XTdI Message-ID: Subject: Re: [PATCH 1/2] mm, cma: fix 32-bit warning To: Arnd Bergmann Cc: Andrew Morton , Nathan Chancellor , Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , David Hildenbrand , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 59F4E8003A X-Stat-Signature: 5mqsgtrq7s7dujkyh1yjq341fxsrmihk X-HE-Tag: 1740416441-963875 X-HE-Meta: U2FsdGVkX19iv3rffCIHcYb5n0C/hJvz8is9+elOrychPao8j9iUUhYyjb/aw2uM6Ru+u34kNINRhcy56rR04fOygk9Y+/4VcSrs+vMARRRn6f6CqQB621cN27e7+bcO8kCzHHsFWUlOGoa0rhKJEvzyCwe5EAW2ynLG56AM76CYs2VwPTkLIJlSxWy1YQt2jEtticWQvHY7BtdvTWv+hPTHMgxdpmEMsYFJ+GdC6WDYxQlBbdQl+esbT2D3eDkNWdrK95+RXNl7Xwb6XBAsyUrGEJ4j3m/jzmuVwBFkLFA65p06XDx+oeZciytoZ4ji92/crWxE969c7Kpn6rrTWun23OKZX3k9+vT1IeYsUEcxC9ukYe0Jha0+P8c4xwy57VoyO6UcfZm+NGqigKUHaY5HJwOJpOZYudshLr+emrPOoN3py3tB6cTfI43ka61D5iMCTRly6tyWpYlX/TolchmelzC4/adCxazK2E5uiDtE1m/lc0TzRcGE7VsBYbpuXPZH+rA1GaOTdyD7GJ9R9qJg/qydCRodTL0YyZLfGPuAbWr64wxCi5qOLl7+J5JNNIZDwzHBz12GmECZ84KoCBZHXvYiDDRI0GzaVQB2QaZRk3JRk0UPkyc0N4pzt4GenuI7ITY55Q7M9GHsrrxE08WWcoty9lMiwow0B9stXTDLY4C25txfH/+d0Vkzel9/WvQ627guM4w/Gv/syrSIJFqEo41T6RtH3Lg6h8BlPrfVklvg/Cn78yqqhr9VMkAxOh3iJGqvHrb8RUAEpdxkolalMM3cPNQ2g4fjNxEWNKd26mWd3Tn/4XuscWGI1B+3mm/LpmHyVHXJ5BTeqTzp4Rx74hd4NB7u2Kc6VeKyKf6+5uOwgfXYqb2/N6hl/ssWga4dAo3DczCH19lKgN1VMoYz60pFfH7mBcpI/zQ1sOM6mluAzXEPFG+E14AzHW0mX4UX7hw4n0VwuL1W5B3 7QXBOuuv lJ2nnbYulz1QR1Zc4TLsdvlYYaHWjWaZ1eIPLKK59qj2JVIVlr/Og54eihKuOQLVXK8jhvqC+y/ZxCMZ+6DFLV6js5MpgvdNbByvywaJkWX8KvFEtBAVHPrXEWjInL4LcCD5zVz49R0piabAvUdtOCq1OPODydvjzuKhnbBcpD184Os5/6aW0wvXoI9vxkVadxLzEQY8TLGVEmHgrm1hdE2zH3k4IaIBL4nqYjBU+O3LK0eB7vcbbIHhLnvB1RRyNCzIg94KF2T4eF9ykgVcLtlOOKuuACmruR4qwccsoDKwnn9QDOju6b+pv+GSFShmySfjS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 6:11=E2=80=AFAM Arnd Bergmann wro= te: > > From: Arnd Bergmann > > clang warns about certain always-true conditions, like this one on 32-bit > builds: > > mm/cma.c:420:13: error: result of comparison of constant 4294967296 with = expression of type 'phys_addr_t' (aka 'unsigned int') is always true [-Werr= or,-Wtautological-constant-out-of-range-compare] > 420 | if (start < SZ_4G) > | ~~~~~ ^ ~~~~~ > > Replace this one with an equivalent expression that does not cause a warn= ing. > > Fixes: 4765deffa0f7 ("mm, cma: support multiple contiguous ranges, if req= uested") > Signed-off-by: Arnd Bergmann > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 34a4df29af72..ef0206c0f16d 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -417,7 +417,7 @@ int __init cma_declare_contiguous_multi(phys_addr_t t= otal_size, > * Create a list of ranges above 4G, largest range first. > */ > for_each_free_mem_range(i, nid, MEMBLOCK_NONE, &start, &end, NULL= ) { > - if (start < SZ_4G) > + if (upper_32_bits(start) =3D=3D 0) > continue; > > start =3D ALIGN(start, align); > -- > 2.39.5 > Thanks for fixing these nits in my patch series - which, btw, needs more reviews, if anyone's reading this - please :) Reviewed-by: Frank van der Linden