From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E3AC36010 for ; Mon, 7 Apr 2025 15:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3A7B6B0010; Mon, 7 Apr 2025 11:52:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D11CE6B0011; Mon, 7 Apr 2025 11:52:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD9E76B0012; Mon, 7 Apr 2025 11:52:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A148E6B0010 for ; Mon, 7 Apr 2025 11:52:55 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8491B141345 for ; Mon, 7 Apr 2025 15:52:56 +0000 (UTC) X-FDA: 83307691152.28.02C50AA Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 98793180010 for ; Mon, 7 Apr 2025 15:52:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7PkvreU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of fvdl@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=fvdl@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744041174; a=rsa-sha256; cv=none; b=6uCT9W+iW8/4H8AyGJEBtZFdqQJOHt24nTAkWfO/9iEsJNHxFF0lIuyKwjhIfEkk3sJ44x nIeUjG613mxuaodL73Uoh/s7WfUhbFSp7m/PM20PqUJHlUBEwyX2x1O41NoMxC+I35VkP2 y9yGN3K18BIYBTszoM+euJkXjQm/r0I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=s7PkvreU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of fvdl@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=fvdl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744041174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6xXXoLwvzZrukEdlx3X/HwLUc1KrRLOBJumxqoeXr2k=; b=AKXWotTWOpbFGnZiMD7Z42a2zrgkaI0v9FIEjjLeKcYR4Ya1smqqcuNjx0q2nblca1dAR4 gc/k84Y4Vk1CVmpGpdJKd3KZ7aEej2dc6zKI1V5BaMtPLR9rxI9W+aEyJTNjxmavI74kqO lvddMjB7l6uYkUXCCaX7ECbznpnIHvA= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4774611d40bso652021cf.0 for ; Mon, 07 Apr 2025 08:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744041174; x=1744645974; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6xXXoLwvzZrukEdlx3X/HwLUc1KrRLOBJumxqoeXr2k=; b=s7PkvreU3qIOahiGmNaJSB0R7HY/PIL03kPW1DO6zN2R9Y8cK6pWX72s8tyiRuZc0s r9kjlznuXKFYCuu6AyNL6u/tvrHbh8Vy6tPXXrUXIXV42/DwsaTioqYjXxD5N0HXAKhT QFERK8tbuj4AC8Y8ewJDTrhIYgqgieSu0q8LNNPK1Yq3aJhtRId+YCRKmLQXxSxlN0x8 chiOw7gYaqwhD7TSQtqEQxGReph5hk0XeaQ5kY+V1Lfm0q3X1i+UctQ122sp0+aaaW9S Q5sFOWWhCMlIQMf6b49Ez8u3dyyZyV2WIfOaeFUZYtMEn4LrkHgzHZ3B8w2VAoI68AAy pRVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744041174; x=1744645974; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6xXXoLwvzZrukEdlx3X/HwLUc1KrRLOBJumxqoeXr2k=; b=uZM4Mw7rFe+aEImJ6z9q9HObQqSZ47eZiuQummAwQOxLRP0LZxL9SqzBQPebI0b0tx t3AtBVoPeWjbnXFAIkEVOUFuZShhaAW0AH5eW8FElO6kKUDgEDGbg9ar2VLeKwOKGN4r zwWQoJg54ww4akwo8eMM96Z9FxgAvL7g3xhVRcZe6dvPR2AZglVVgNEXDtN+eUTdC+PO RhFqji9M4RZzpC2COIMhgfdTA7+IWxfUA4YJwByVGpgQ7B6qNtHgwKDruV6S3Fs+RC0K pMqmeTkH7MkqBzcjDz5+5qFv9CzTtOovgjuKDHc8D6b5fCRjCsJP/olrXsTNvFDVAvJ6 xqdA== X-Forwarded-Encrypted: i=1; AJvYcCX2FneUXnhZ0kkWfpbZ3V2D8EZ0thWkGNZ74FivVSSWJEmnThGFyk8lDA7DlXKXZMG+rbmZqDhVGQ==@kvack.org X-Gm-Message-State: AOJu0YwMeb5Kr9LDbuVruu3DcRvO67BB6DSOYrGJVjF9cPOntpuSPywV q5K6gkUPOQEz9/k+NVsYTdTs/Oef3w4JMqfQG+4vBWRErkR8fqJ4Rh+VzrDXGPxjgAuuvhaH9ji hczK1cYExnAx/w9FN4PMs/Sob8ttQeMVieuwHsap9kdRKzqHpDA== X-Gm-Gg: ASbGncuNg7i0KKLIqm0+ZIrcVX6mdvUO1r2HIGBO54bH7Fpz5xgPf73KqqglUi2FmOM UM6BPtckwbBVuBYffMeiCGMqdCGk8ZYzyoEottxx5v+/Waa207zfinwO6xz1MYHUQ4fa2RlwF+T 9I7Fc65p3KsZc2SqOuuGMIX6M= X-Google-Smtp-Source: AGHT+IFIBgZaC437wC6LFI2WkYOyO3PJh+Hp0KwQwHgd7KVbv0KJT81vcrxyQeuTbHfu7nS8KoS+po1riLdnTGeL6ck= X-Received: by 2002:a05:622a:110c:b0:477:1f57:38a8 with SMTP id d75a77b69052e-47953704448mr313851cf.8.1744041173528; Mon, 07 Apr 2025 08:52:53 -0700 (PDT) MIME-Version: 1.0 References: <20250228182928.2645936-1-fvdl@google.com> <20250228182928.2645936-3-fvdl@google.com> In-Reply-To: From: Frank van der Linden Date: Mon, 7 Apr 2025 08:52:41 -0700 X-Gm-Features: ATxdqUF9nwle-L2yhrR-TnrIw4GPykG22raNMPvcz2hBIWJJmX1JDxamArUc2zI Message-ID: Subject: Re: [PATCH v5 02/27] mm, cma: support multiple contiguous ranges, if requested To: Geert Uytterhoeven Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev, ziy@nvidia.com, david@redhat.com, Arnd Bergmann , Linux-Renesas , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 98793180010 X-Stat-Signature: 4ud9n1xkewngppc9r31dsorduhrc9mo3 X-Rspam-User: X-HE-Tag: 1744041174-356350 X-HE-Meta: U2FsdGVkX19Y3jX84lf2FgMieiaj5fE6Ia6y0IZ7eGCm9jXwrkkhQDHJso/9kU1OJkjWl175ZXi+DnQxPsWeuslwAaw2oj0eR0iJ+hi6ZqFRm38iK5uJSIwRXJ5i0R1Cm8yCoQgWWMZuAq9a0st88ZzgO2Et4ASpgQe/MrYlF2kPvwsSTdXTBk6cNPHaozc8/k2pcLbRFaLrE22veI/XoiBvJN0fg9FW1Sks8NqJ9Q1dgl6H0ZMIiCw/keJieAp/LRhkPL2DiLaPG+fhuejjYhAy3rXy70P2TqQiTRnMQkRKHW+HBZJhrysNydNVPnhszc4Z1YM/fTBt3+BwsQ8O3X0wmGg8/mEjC/h2QTGnKjmKFBwbvmuoa6bOkeI92i9+SfHd7BoDLxiCh1zp/INRvqbWYhAUCuTpVhT8fIFYnJMhcDELM8c2ivpVqpLqUFjCjQqMyKbqGGt4SLCeTp1q2MdA9DElqzg1af9hDA1f6h4OVJCBghb+pqFOvq/p6Xl82izZ9NaVUf7hTzpy6agELPywSutKamcFZ4iwHy7FM3Utnuyoph4p23g2b399RUiEj9h6jC+r9RESGnTa2KTwoFWf23Y52d+TfE7tv4DkziNgXj3h47QfoEEg4ITiZN7lSikCise+DfM2OKJpopKLn9yGR9R+UFMnWSR4O+EW2tSNTHzPjeoTbjrnKEfCEJBrkm5xqbQrjuRZdcnBX6wuoxcE1dLjK5xkyqdTqR25pK4hpKsDloGnRRgFtwy9SmGkDx1v4fyCagTGYu7+eX8l+U97m6TWij7kZaKUa8wCEwZ2kbBe5DTP4AiljTW4Ab8zhAOW/dmAYoof+gkrjqUOStv4651eFw4e+/QWiqtuC+fx9fDl4U9eUxnKQdPz7srRfOKgsz84rXJW3McHaeeTfe3/LutY9xGc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 7, 2025 at 4:50=E2=80=AFAM Geert Uytterhoeven wrote: > > Thanks for your patch, which is now commit c009da4258f9885c > ("mm, cma: support multiple contiguous ranges, if requested") > in v6.15-rc1. > > After this patch, the printed base address becomes zero on several > Renesas arm32/arm64 platforms: > > - Koelsch (R-Car M2-W): > > -cma: Reserved 64 MiB at 0x7c000000 on node -1 > +cma: Reserved 64 MiB at 0x00000000 > > - Salvator-XS (R-Car H3 ES2.0): > > -cma: Reserved 128 MiB at 0x0000000078000000 on node -1 > +cma: Reserved 128 MiB at 0x0000000000000000 > > - Gray Hawk Single (R-Car V4H): > > -cma: Reserved 128 MiB at 0x00000000b8000000 on node -1 > +cma: Reserved 128 MiB at 0x0000000000000000 > > None of these have actual RAM at address zero. As I haven't noticed > any other impact on system operation, I do not know if this is purely > a cosmetic issue, or if it can cause real problems. > > Thanks! > > Gr{oetje,eeting}s, > > Geert Hi Geert, Thanks for the report! This is just a reporting issue with my change, it's working fine otherwise. I refactored the code slightly, and the !fixed && !multi case will now report base 0, because it doesn't 'see' the actual allocated base. Let me send a follow-up patch. Thanks again, - Frank