From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC6DC0219B for ; Tue, 11 Feb 2025 17:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 542D1280001; Tue, 11 Feb 2025 12:22:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1A86B0085; Tue, 11 Feb 2025 12:22:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B94C280001; Tue, 11 Feb 2025 12:22:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 202E16B0082 for ; Tue, 11 Feb 2025 12:22:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 22C851A076E for ; Tue, 11 Feb 2025 17:21:47 +0000 (UTC) X-FDA: 83108331054.25.28F5D1F Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf18.hostedemail.com (Postfix) with ESMTP id 1B4F11C0010 for ; Tue, 11 Feb 2025 17:21:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=caiTeuhf; spf=pass (imf18.hostedemail.com: domain of fvdl@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739294505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JQU4kCb3JDQS3HCzC0AuWPhi/mIN8ce8zfOQVORZJ8s=; b=bsepsLX1tpWIXFWmdsxDd21TakI/di70kxwyJnIcAG9FmnzOXoB9WdFxmWyDH3GzmfFmiC TEKbEuzui6jcLYombIN+6ljDgacOThDXkOC45ajk/JS9JTulq9wIFha4iCMB3605/Av+UF HUuz/Th9HKCSvF5wdjxwcrMAR3eMmf8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=caiTeuhf; spf=pass (imf18.hostedemail.com: domain of fvdl@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739294505; a=rsa-sha256; cv=none; b=xptjbhGudXTLaGGTNrg9Lxh9idpGXr+w7AG6NtGX+OG0idkg1CtT0MeRfsl4/y60SvxjZO UZ1j/2IMf2cFrxsRxcu1U5EhrRbxM/SfvFtTzDxseMwoOV5R4PpQJKdbmVPTWv5mGCi/0t bYVvlTwWny+JN3+L/KWsovp6CkBOgBU= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4718aea0718so418381cf.0 for ; Tue, 11 Feb 2025 09:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739294504; x=1739899304; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JQU4kCb3JDQS3HCzC0AuWPhi/mIN8ce8zfOQVORZJ8s=; b=caiTeuhf5Q4/ePQ2RWwMSls0xg/osIDQ7LSbFU0w+dAloF+Nalg1YhjiUGb5m71FEQ ZRjlBlDrFZrlCq6//bOluWC/yelL1R9e1EgAAmrTo7WnbAEQUhCQHQPGo9ttvJerEOxN d2jW2jA2F/Qzjlv/eQbJQUOh7x2cIxkgktD/PbOXRJaQhVjxb1lJjgyMVZ2vM836LECq 9g9IqhK777/qdY8n47WPLcYZMlAZG/OiIWlbYXLbel2M4ERoR5YZpA6ovRYahqUzB5Ud MY0XOFezrBp8osEjSXpBy87ebc2QYz/u1qjJ5CvTwSCESoi46vo3LLZOi54n7bMBRpeF PG9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739294504; x=1739899304; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JQU4kCb3JDQS3HCzC0AuWPhi/mIN8ce8zfOQVORZJ8s=; b=t15mZhq7JQYgf8a2DqbkRX0+Ytx08tbj4bvqHqd2dURA7/lnONOFTMb9TnhhhUzMTh 4GpI01fEIyIfpozojfDoLuu+OSelRHhcyLe1WXWSqmch6XLvwxYe2spQ7YSYcPlMKKKu rjIqP6zZrqTV4oEgRLxoLuy7eZqKJ/YdJugDLUsc4DTDl5fbLoDivjHsAoKhQteC7VO9 c6HrVovu9au4LChfLwMNL6t0QRNqNQ9yge8v/d7UpneK/V1Lm9xB7qdRVgbcr/v1D2ZF nZ4mr58BIMNeF8ckDBUHU4k3kJYxcVbiTpRuVVuKW7h7v40tKMS+SHOtb1pvLtY5Ka+c xARQ== X-Forwarded-Encrypted: i=1; AJvYcCUgTUp2Xfgy9983nCD4r3kX+TGhREd+TmiE0vtd2Gr3PEamRz7cAj44CxJs+IfphoSM4eknClw7lw==@kvack.org X-Gm-Message-State: AOJu0Yy4GxYWeAX/VbCOBL3onoP3lt9WTPijP3zZ2JR3Mp7Cti1Wq7dw +e0iYTEN1rUxOxKGT2ijWjRGAnnfBxWhoiWeLb9jydE9xjCsP+2q6LwydlmBpJeCtaMxA9pD+6r qWSZNFuoeDvyLRBDAZ7UoTWracC/zaM/8V6GX X-Gm-Gg: ASbGncs8P4snbBJQrXEQbB2ED2r36kbjYoG6BoMq3mrtTovRX+BdMx8yaB/7YZ2/Umm LUcLPRklVunA9japB2ygC1gtxnTV0O7popVqJM1ejFzlQCxR/HJIc0QlgvFU2age6So489A== X-Google-Smtp-Source: AGHT+IGOEFH7664K9RlNpVES6sDxn8gX1Ls9BZ79xJQxYziPDxioUbrCegncHzSc4ClUTc63c5nWi+UY2RfjDX6kyag= X-Received: by 2002:ac8:5dcb:0:b0:471:a0ae:7e3d with SMTP id d75a77b69052e-471a2611629mr3841661cf.20.1739294503928; Tue, 11 Feb 2025 09:21:43 -0800 (PST) MIME-Version: 1.0 References: <20250206185109.1210657-1-fvdl@google.com> <20250210152858.58e6ac26b9cd6e2a36aaac8f@linux-foundation.org> In-Reply-To: <20250210152858.58e6ac26b9cd6e2a36aaac8f@linux-foundation.org> From: Frank van der Linden Date: Tue, 11 Feb 2025 09:21:32 -0800 X-Gm-Features: AWEUYZk3xVLMBtUXNyUTcyykqkTjpJHTLzYu4NG1RcZKt9p7J4QDT-B2dpP9DTo Message-ID: Subject: Re: [PATCH v3 00/28] hugetlb/CMA improvements for large systems To: Andrew Morton Cc: Oscar Salvador , muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, usamaarif642@gmail.com, joao.m.martins@oracle.com, roman.gushchin@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1B4F11C0010 X-Stat-Signature: wbfqcwa49ukrztc8oz4jmokkgyz9j6ad X-HE-Tag: 1739294504-753526 X-HE-Meta: U2FsdGVkX19+F0tV6KjhpAjKWKsRirqowAc7faDngLYb7Td3fSmmt3rYg8jF5HQOFF+om3+yoA1c82zD8uRFtLFtPxFu/uPelw1SYLDsCHrhRgFGLjbou96fpbM2uu+d3MKCvFbGNPn/exWU90PcyC04SFotRvOpd40aCzKN7A2nJKCrV9VO8zohZDCPAQJZi+QAqAjFaORFQevPl1vMi19mdlZtDcZ6AKaiXGeux+zQN/DKWKccRlhVWoAhED97LFCSQ1P0BJsh2f6+630KkX3s+smZhpqSg2R5MYMHcrh32VXpbGH3HUw+7pCOcu3DjDrHBY6XiO9wkSCIWrei3Zs1Uu0YS6v1h9n0buPiI3fG1DhgL9sFsvd9ovTxwB+2SxSOcw4f3citfzWJ+LtZN0Ezmt8mvIJLv6oHCeSP0CMqpvQrNrKQh+4MQmU1rAe2uJlXNiHii4dAtApmJXteM7GmfucDZfOL9nAB1InW2C9sdmBAaVWFOJP19EezieqzgCczQv3ooziYReDF0ikvErZyLl46I67SjjDJAwHBEd4wlUpfj9ivY5+A+x0FbRKH/g/GU8u5NXCZfEnCH1fVNRxyJeiTqWF3LsaFwpDTo1VOipwaFWJF7i9oKtzZwP+kW6AKLdbnndfCd7TnmRMh+TWSy4xSgO8OdRYxfKVDXH7DIncKv07s+ZENBGyIR+zRudwDRf4bdnj0M3qpdJnffEC1u+++LBDYScjsleAc9HQbDh/lq/1WQZjeHGbUKrPu3j3a3rVbNK/D4rGe/6LWIiwR6pw/Ln/aRT4rCeZdEfMqgKDESzpLG7QbnLhaALWnwICAGsVIYgVxuXHjyvJbvOYSRnaOuH0WwHhC7TdYbIOk20Ch77ylbZBAvaxwU/IXvfWsJ4Oy8CKNhrP3Lf66KjzKJn3EdyNkGRFEe1fkDwKqAmACAVSDhXkC8CijiWzLAGN2Uli5/nLdfEXKLNn ki16wpck cfiKuG0W0QHT3Da3swYBm+3NSI5C+nG2FwwdU5EOic/1rULEBXCIgQfeELD94vUcrXcpMMC/tu6pNUogRJTKGDqcX0jDBW960vZI54n0bTmwNffdMI+d81YKsyu6RBbKc+wQmdo/G1r9KV/Rx+7ZOfnkVXL6JfMK5FJeNlg6NIKtJexhSup9jnrOnSC7Vu5v76LXF8GAH7RkG/Dj8w0vVcIVsjghe3W6LEK72vFcO/rqfFoVZDEsivGspWbjdQlJendaDXO1qOIuFqBHSTCipUwZoZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.029211, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 3:29=E2=80=AFPM Andrew Morton wrote: > > On Mon, 10 Feb 2025 10:56:50 -0800 Frank van der Linden = wrote: > > > > Hi Frank, > > > > > > While I plan to keep reviewing the series, I think it would make sens= e > > > to split this patchset into two smaller ones. > > > The way I see it, we are trying to deal with two different problems a= nd their > > > solutions. > > > > > > 1) pre-hvo at boot time > > > 2) multi-range support of CMA (only used for hugetlb) > > > > > > I did not go through the entire patchset yet, so I ignore whether the > > > respective patches to tackle these two problems are really dependent = on > > > each other, but I think that would be very interesting to consider a > > > patchset per solution if that is not the case. > > > > > > IMHO, it would ease review quite a lot. > > > > Hi Oskar, > > > > Thanks a lot for reviewing this series. > > > > I certainly could split it up, but here are the dependencies (it's > > actually 3 parts): > > > > 1. Multi-range CMA (used by hugetlb) (patches 1-4) > > 2. Pre-HVO for hugetlb bootmem pages (patches 5-22) > > 3. Enable hugepages=3D (and pre-HVO) for CMA (patches 23-28) > > > > 1 and 2 are independent. 3 depends on 1 and 2. > > > > So, I could post 1) and 2) simultaneously, and 3) would have to wait > > until 1) and 2) are resolved. > > > > Andrew, do you have any thoughts on splitting it up? > > I don't see much trouble with the above dependencies - we can consider > the three series to be an all-or-nothing thing. > > Such a splitup would be the same patches, packaged slightly > differently. The main difference would be the presence of two more > [0/n] cover letters, presumably also repackaging existing material. I > don't see a lot of benefit personally. > Thanks Andrew. Here's what I can do: keep the series as a whole, but note at the top of the cover letter that parts can be reviewed / applied independently. I hope that works out for everyone. - Frank