linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Frank van der Linden <fvdl@google.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mike Galbraith <efault@gmx.de>,
	Alexander Krabler <Alexander.Krabler@kuka.com>,
	 "linux-rt-users@vger.kernel.org"
	<linux-rt-users@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	 Dennis Schimmel <Dennis.Schimmel@kuka.com>,
	Daniel Braunwarth <Daniel.Braunwarth@kuka.com>,
	 Hugh Dickins <hughd@google.com>
Subject: Re: Realtime threads delayed due to kcompactd0
Date: Fri, 1 Aug 2025 12:27:18 -0700	[thread overview]
Message-ID: <CAPTztWZpnX1j8-7yeppVUsxE=O9hbVeqricDjZt8_pnN7a-kBQ@mail.gmail.com> (raw)
In-Reply-To: <25ba0d77-eb61-4efc-b2fc-73878cbd85c1@suse.cz>

On Fri, Aug 1, 2025 at 2:58 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 8/1/25 04:46, Mike Galbraith wrote:
> > On Thu, 2025-07-31 at 20:41 +0200, Vlastimil Babka wrote:
> >> On 7/31/25 20:34, Frank van der Linden wrote:
> >> > Not sure what the right thing to do would be. Either explicitly boost
> >> > the priority of a thread temporarily during migrate_pages_batch, or
> >> > mitigate the issue by dealing with 'busy' pages more quickly in
> >> > migrate_pages_batch.
> >>
> >> There's a workaround for realtime tasks. If you mlock[all]() their memory,
> >> setting sysctl vm.compact_unevictable_allowed to 0 should exclude these
> >> pages from migration by compaction.
> >
> > Hm, per documentation that's done automatically for PREEMPT_RT...
>
> Oh I see.
>
> > On CONFIG_PREEMPT_RT the default value is 0 in order to avoid a page fault, due
> > to compaction, which would block the task from becoming active until the fault
> > is resolved.
>
> So it's probably the mlock() part missing since that should otherwise apply
> to kcompactd.
>
> > ...but rummaging, seems other stuff can step on it (contiguous alloc?).
>
> Yeah, there was time CMA was just something for mobile phone hardware. As
> usage increases beyond that maybe we'll have to tackle it. Ideally by not
> having mlock'd pages in CMA areas at all. And if contiguous alloc is
> attempted outside of CMA areas, respect the sysctl there too.
>
> There are also things like mbind() migrating pages for NUMA locality but I
> assume people just wouldn't try to do that with realtime workloads.
>

Another idea is to minimize the time that a migration PTE is in place
for an mlocked page, Hugh (cc-ed) mentioned this in an offline
discussion. E.g. skip any mlocked pages in the first pass, and just
add them to a list. Then, do that list separately, but do them one by
one. There is somewhat similar logic in migrate_pages_sync for pages
that might need extra work / locking.

Not sure if avoiding mlocked pages in CMA would work out. I mean, it's
not hard to implement, as it would be pretty much the same as for
pin_user_pages: just move them out of CMA on mlock. I'm just a bit
worried of scenarios where the kernel might run out of space for
unmovable allocations if you have a larger amount of CMA, which would
be made worse by moving more allocations out of CMA. Then again, the
amount of mlocked memory is probably generally small.

- Frank


  parent reply	other threads:[~2025-08-01 19:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25  5:30 Alexander Krabler
2025-07-31 18:34 ` Frank van der Linden
2025-07-31 18:41   ` Vlastimil Babka
2025-08-01  2:46     ` Mike Galbraith
2025-08-01  9:58       ` Vlastimil Babka
2025-08-01 11:23         ` Alexander Krabler
2025-08-01 12:57           ` Vlastimil Babka
2025-08-01 13:40             ` Alexander Krabler
2025-08-07 10:48               ` Vlastimil Babka
2025-08-07 12:21                 ` Hugh Dickins
2025-08-07 15:49                   ` Alexander Krabler
2025-08-08  7:37                     ` Vlastimil Babka
2025-08-20 14:29                       ` Sebastian Andrzej Siewior
2025-08-01 19:27         ` Frank van der Linden [this message]
2025-08-05 14:11           ` Alexander Krabler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPTztWZpnX1j8-7yeppVUsxE=O9hbVeqricDjZt8_pnN7a-kBQ@mail.gmail.com' \
    --to=fvdl@google.com \
    --cc=Alexander.Krabler@kuka.com \
    --cc=Daniel.Braunwarth@kuka.com \
    --cc=Dennis.Schimmel@kuka.com \
    --cc=efault@gmx.de \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox