From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749B6C02194 for ; Fri, 31 Jan 2025 16:41:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC25F6B007B; Fri, 31 Jan 2025 11:41:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A72FD6B0082; Fri, 31 Jan 2025 11:41:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93A216B0083; Fri, 31 Jan 2025 11:41:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7692C6B007B for ; Fri, 31 Jan 2025 11:41:09 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5563F120F1E for ; Fri, 31 Jan 2025 16:40:53 +0000 (UTC) X-FDA: 83068311186.08.DB4C030 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf19.hostedemail.com (Postfix) with ESMTP id 662841A0016 for ; Fri, 31 Jan 2025 16:40:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gz6vkmG3; spf=pass (imf19.hostedemail.com: domain of fvdl@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738341651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IdxBuZHfYMpiuPPvivE+mj/S5KS/kuYJy2WfQwwjP1Q=; b=VcuhcR5S+vWhTGc0tcOaOO0+3wb2QaqP7UXpl+hTnF7HifjLCYdoui+C63OunBNev9GgSB AwZ0LlfthwwMtffH/Bz2gu7aSs2QL2c2EOHDJGpHWfxana5CDQAp4/qPJ6gJOc3JCiN8Fh egXo7fgdlYA6rfwyHcbFm53bgvyt3w8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gz6vkmG3; spf=pass (imf19.hostedemail.com: domain of fvdl@google.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738341651; a=rsa-sha256; cv=none; b=awZUKlEtcVZGbt1LswAufNy5PmpleArsdWvpBj9p+hnsQzdShdj2+eLo+3X68UyUGKO9Zu f6K8Me0xSkRm841XreuGqHmIjLZp1E6ocM2pQT4KP25S7Cmi8pZYulcFV3/0wXHN7viV1J rY0Hg6e4i/Rjrelw6yKABNhtEG+d+M4= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4679b5c66d0so231341cf.1 for ; Fri, 31 Jan 2025 08:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738341650; x=1738946450; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IdxBuZHfYMpiuPPvivE+mj/S5KS/kuYJy2WfQwwjP1Q=; b=gz6vkmG3Ob6pDZEaXWOYsUXVhpqaDuwOwLdH597Z5P7LprRArVS06BZ1/fw91O8Xqg 7zI2Ht0y+HXqkzjzE4qToP5c/GXndSbFYyn5+AdAtSeODlumKMw5i+nuTorhe5WZMTv9 7nrhMVxoVgZYG1BjKWJ+7H7Oexj+99zEu41W4adi1gjB2pHytg3zmu4r8RbXW59BVi6k ELLZc+ErQotws8kK4goGdDhOBRVHKLRl0NnxKVhTWvQvJnpNxNvZiDb4NIferSFGkLn4 IshKiCOlzBqUqMXc6D5DcqKWfc77aBJ+5A8Z2102aEF0k9iB1cHUQSHFf5Tus+atV4+d GiLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738341650; x=1738946450; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IdxBuZHfYMpiuPPvivE+mj/S5KS/kuYJy2WfQwwjP1Q=; b=A+IGnY+9nYOPBNlU7aGpaGgcc48PIxlSMd9/P5JAOq++2t8NA1sPB3NuP2EZkXtB+m VcaLTwpeZF4PXGH7iDTDU1XZ/ZLjdBBALvnqKNEpnIWaRWZAUfaQ8sfvurEvyk2ibfgS qJ9Cl/HtSbsiP1KQzEKSnqMrMoEvCWvhuenhq2fyJgZL8tUGcBvnHsSQuHwgonCqfGEG 5R/FgEK28Rmhx7/3X+YolqMb+HGbV5eYWPFLQfmbIBZiFDyEhgw3VdHxfVDbNcCZRkJb WqicnD6SOsP5iYdMM/85nZFhJ8GRQTzICcKWmbwRbNRWctxa3S3GwwjhpRZswx5NS12n 405A== X-Forwarded-Encrypted: i=1; AJvYcCX1X3/zNoEYjiqIRpTK6FjEMn2vSkZeqddY6LjX1/IjqpN7U41UKYhZuAQrnF+pPektEMVRe6fiyQ==@kvack.org X-Gm-Message-State: AOJu0YweopkiPeeJXcA0iGpRpwvo1JtJ06YWGXoDyi6VV3cZ4iFuxYFQ 9cqxDFfl/4TemI8F3hWQQgaSkoxSGB9zlP1eG6WLopAkqrkBUspmZps32LjH/eeiuK6oQK26q0l v/k5XnyRrVYMnY++ODAQ1aB7Bt7kQ5ni7mPl+q+x5ga0WQtAiF/Si X-Gm-Gg: ASbGncub3n9wKIm0WF0WN8rLcNlTRLNaLaU7NRaWX3Dks4yadTmTbqoNlGGx88/CCAW 0eeNGyg82dNZXjhiY7XvkBj3m4ujIzB6ALrPXqv1SqxULQ6TzasEUWyTJ/6w6C4M5lhP8qw== X-Google-Smtp-Source: AGHT+IHVZupShShMQVvFrTsj/qwh4zWX4r0XFuj2/CNc2c2zC9hpNvltw2cpNnEQ9tTH9earWU2PXRQM3iRt7WcTeRI= X-Received: by 2002:a05:622a:1a1c:b0:46c:7cf2:d7b2 with SMTP id d75a77b69052e-46feaf31710mr3533471cf.18.1738341650365; Fri, 31 Jan 2025 08:40:50 -0800 (PST) MIME-Version: 1.0 References: <202501311826.hU85Yygn-lkp@intel.com> In-Reply-To: <202501311826.hU85Yygn-lkp@intel.com> From: Frank van der Linden Date: Fri, 31 Jan 2025 08:40:38 -0800 X-Gm-Features: AWEUYZmNCfVOeO6J90nfUdQZ5ICG3gnC-a2IZ971btT0oRVQZsMy0WIgHJTtie4 Message-ID: Subject: Re: [akpm-mm:mm-unstable 69/88] arch/powerpc/mm/init_64.c:390:6: error: redefinition of 'register_page_bootmem_memmap' To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 662841A0016 X-Stat-Signature: 7z5aub47pn7o1gmrnej7ypqm7rnxp8xp X-HE-Tag: 1738341651-735040 X-HE-Meta: U2FsdGVkX186Z1RuwMzIVUkTBJtDgcAAMh22bzND2q/Ar5q8aubV/8JjbtHohNqvV6FSpTQutr3sXL/GbqOJ3q4AIm/nP0e6t1qYOoA3fi8+t9x/nnhXjMCGt6tk9hAnombQ35kK6WJcLNVGk4bAoajpE0pMmMphi9N9+kFFgW5YLwmAnmWxFcnPbbf/i7o56Q6le065Vw49Ac5avKHYt4IBht6OYJgmXFAcoT0RaSft3yHcjvZta8IM3CEBlPMVMcDqNkA5VcMBBkOHdfcuX0OzadqWo3s4hucgBe3Ue7m2U15LVqYqTj63zDOkJU0Nq72Q+3iU0C/S850IijUSp7vBFc6MqvxNmnnzZ4fvWGgHiFPuR4rP4ZN7omVSGhgFu4Tp69+iTIvEwNxh8CQa4CRcJyA9DQu4MIBA1joQI25xNxA2cMUCQd23GoaUkTmwqxC/QZzeTiJpnsQtlIR6d9jjGA9yNKUfl6MRv5OZxHtI5ppQBIYgtq4n05bOOX/0VDHuGj+xql+9MoCPTmEVGEhPN7JqzZ27RWWG7XptXuURFmZDjtQu7DB0RxndNXs375OELk9YsI3BeNBjoJNiLD/0Jf8tCOlZaRhQTxDF29FOnsfr+MRy6ZtKtF/2c1RoxiEtvtBAfSuJo4bXSzIqG35IYBx910hVcB+9Y9wRD8NIxeQJlSSii+ER8DIRtJRAPa0J64IthQqnXHsbS3hPXNeij4yYRXppRb8tQ89WYPbJsEC6jMz9YOOOb46kBHFTiedzF/S4YmF7EP8yo+nLlYage5Ybehc4R2SPNaxIsKnsRDhHuQpb/JhFZzAwscGgZslK7JM7lBbD9R3vbS5F3O3pNBqvkDISrnWPUjpLkqdMQI/D2C6bK+v+ASPGjLgDG5brgTuJOgQ+quClvtXKeg1re6fEvIX4Tt5C61CgllcUo8T3p1mVHi1T3nM4SHXGmuu6oU0IAsLcKhBMp0x /egkWXEx M3eH0D66p+oWix00ymLMrUQqmUkzNBjj9sAIpOQVmNmvIGVni6MVHGgbsE85fgB+0C1scygPbCd1QeOko6CZ50uy3b0H1cKR11JGjfEBDB1MO6xAX0Ge8w8JwRA/zTK+tBnwIKcmNe89V5M0zAu0PTx/fPoaCFaBUjFXzvlDKulpVVG9LbR5kk63sm9JoqJxuG4sgo7YUk6jLZ7qfReIpayES6+5F9MGgeviLSNuyad1taVTcz1ktwzh1CNEr0syzK4TMQK6dCI2rScBC/d4t5WUSTKrqOo0D2GnpqIAa3jvygmG7auyer2jU6TyJFRvdusXOLbrP2Bb7+3QSz6lnFoB6+UBUcakfb74josMfoGDvFgxes1TtgEVpTDpKqYRebQ3xTD1pQlElmQCV++7hvI8Uxtd3eg6sb4dIf37zolx5Qng22xc78fiYGtmYeTpCzpau X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 31, 2025 at 2:16=E2=80=AFAM kernel test robot w= rote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: f5604ad70091eabe663ea7106ced99449d653320 > commit: 2acfe4c72e4e3a50a685652d89c927335b90c947 [69/88] mm/bootmem_info:= export register_page_bootmem_memmap > config: powerpc64-randconfig-003-20250131 (https://download.01.org/0day-c= i/archive/20250131/202501311826.hU85Yygn-lkp@intel.com/config) > compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfd= cc7b7bf66834a761bd8de445840ef68e4d1a) > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20250131/202501311826.hU85Yygn-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202501311826.hU85Yygn-lkp= @intel.com/ > > All errors (new ones prefixed by >>): > > >> arch/powerpc/mm/init_64.c:390:6: error: redefinition of 'register_page= _bootmem_memmap' > void register_page_bootmem_memmap(unsigned long section_nr, > ^ > include/linux/bootmem_info.h:63:20: note: previous definition is here > static inline void register_page_bootmem_memmap(unsigned long section_= nr, > ^ > 1 error generated. > > > vim +/register_page_bootmem_memmap +390 arch/powerpc/mm/init_64.c > > 368a0590d954a6 Aneesh Kumar K.V 2023-07-25 388 > 71b0bfe4f1608d Li Zhong 2014-06-11 389 #endif > f7e3334a6bcb42 Nathan Fontenot 2013-09-27 @390 void register_page= _bootmem_memmap(unsigned long section_nr, > f7e3334a6bcb42 Nathan Fontenot 2013-09-27 391 = struct page *start_page, unsigned long size) > f7e3334a6bcb42 Nathan Fontenot 2013-09-27 392 { > f7e3334a6bcb42 Nathan Fontenot 2013-09-27 393 } > cd3db0c4ca3d23 Benjamin Herrenschmidt 2010-07-06 394 > > :::::: The code at line 390 was first introduced by commit > :::::: f7e3334a6bcb42e7295a9bd9cb36ca4e6e4e66b4 powerpc: Fix memory hotpl= ug with sparse vmemmap > > :::::: TO: Nathan Fontenot > :::::: CC: Benjamin Herrenschmidt > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki Looks like my patch "mm/bootmem_info: export register_page_bootmem_memmap" exposed a (small) issue in the powerpc code: the (empty) definition of register_page_boot_memmap code is not wrapped in #ifdef CONFIG_HAVE_BOOTMEM_INFO_NODE, like on x86. That causes this compilation failure for this config which has SPARSE_VMEMMAP enabled, but MEMORY_HOTREMOVE disabled (so no HAVE_BOOTMEM_INFO_NODE). I'll add a fix to wrap the definition in #ifdef CONFIG_HAVE_BOOTMEM_INFO_NODE, like on x86, in. the aforementioned patch in my series. I'll spin up a v3 with it, since there were some other things that needed changing (checkpatch SPDX warning, and missing debugfs change documentation). - Frank