From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 045B3CD1292 for ; Thu, 4 Apr 2024 21:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B2736B008C; Thu, 4 Apr 2024 17:58:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863CD6B0093; Thu, 4 Apr 2024 17:58:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A2F6B0099; Thu, 4 Apr 2024 17:58:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F0F06B008C for ; Thu, 4 Apr 2024 17:58:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 12BE5A03D6 for ; Thu, 4 Apr 2024 21:58:29 +0000 (UTC) X-FDA: 81973213938.02.7035E92 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf25.hostedemail.com (Postfix) with ESMTP id CF0A3A0018 for ; Thu, 4 Apr 2024 21:58:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3y14aaeD; spf=pass (imf25.hostedemail.com: domain of fvdl@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712267906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MXA1Pawcw6q7MhE7VT/TIjcbej+/bkiKTDfv32P6Hrg=; b=Cw/cjit+q+OHQBMWltWstLYfRa7S6r2rrDvLyIBnzFFeHkTrup/KSx47roEOg3w0/xudtF 0f75ddY55O+9fWazO17zLSQD2C3X5W+1MRylePjrNN+bDOMzGi7yx+TeW9KtJ8qbqBrNqI HUzBHDBzHLaZCkFDdlPeu4JyGOMcrrQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3y14aaeD; spf=pass (imf25.hostedemail.com: domain of fvdl@google.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712267906; a=rsa-sha256; cv=none; b=2AK4GgfITuFapecrxrujerBsqRTI2o+Lp2lyGGRab2wTkDz74AAw7x97TjfTauo0QfMHa5 NZyUH5gOlpyaFE3iuwubTez2Sf3aYp9dyhQ8+wi/H7zADG9PXaLrKDPWLq9KA9UHJDJDvn tFc59HHULkUYOGtlNVQVHPQSf3e8zLQ= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-7e389d74dcaso828835241.0 for ; Thu, 04 Apr 2024 14:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712267906; x=1712872706; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MXA1Pawcw6q7MhE7VT/TIjcbej+/bkiKTDfv32P6Hrg=; b=3y14aaeDNWRdxvuDHeoGow6YGMpV1EnnanAWmxKWJ9vxuTWw/ygLsWWd1lSZe3+ncT KPzYX1T7p/pNZ6cW8n8/jnOzRN1n8ot5Lbyz0IcVBBEUc8BgThMxKa72qeCQ4Ru1rpE3 P1W35e1xEJTgZ11pBnqpaG/8QyZEDPixysSgkZjXcb6xpKqczqzWuK9Ng7TmFO6jhWGS QB288O6AMMtB5x1nwNk8t2bfFDOdzFUVNrf8spSkr3P5/+PdW2P1n/LIL3mDOGpTyOCI 36QtruDjzrMOesiQo4Jkt81F/vHUuhBC6MZcs9wpFzxvwLVobIlcfZwZzeEPlTh3LHy2 pkJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712267906; x=1712872706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MXA1Pawcw6q7MhE7VT/TIjcbej+/bkiKTDfv32P6Hrg=; b=V0dbx/7c05lqJapq8Vo+cieXZ3BaQg+cuImFEvY5Po3b0oo150irI8+UxfXmg+H3GP QFXutE32ELdmLyjo+AKNaIFxL7xNEOdl0TMXMVZY9abO4QNFpeNef8HLxrnVSg1lZknz ZAHNi3u86f7vPx4iKkXfZZrwXHswMQcgGS0hV6xKJpUd9LCOkudZ0tx/joYE9M2zcdn4 gI31fBzrWgAKFFNUn5q25wshGwPDTbV5G2ap5uh3lFtyhWjzAZ0LEBmZ6ioJE45xSxHB omiqB0bXlIlcr8atS8lIsc+Q9SKFj4VF8cflTjcnV3uOVGsxR6I/Iu8sJTh4rDAWFPzk SCQg== X-Gm-Message-State: AOJu0Ywz9AZZrO3OzGKo0EukCtHa9PiXZXJmm4sGaQY5Id1CdEWgdy5y j66RjEsjMMjGANkWN2N8ymT9MxBVLH5Y5vGEDbRakorrn67kwp9c7WWiLtzeWAFGBdzqoVYWHoL FGg5mg9unvHz/t+a/CQJe559qYA/43hN9z62g X-Google-Smtp-Source: AGHT+IHcGcVynOrCwd5GKEjNJxBR+DIwyhJJZMcY9Ci43m9rDIAmEzoFo7afNlAdZFC8NZt3fpMFw0EFs9yKchDPiG4= X-Received: by 2002:a67:ad04:0:b0:478:763c:1869 with SMTP id t4-20020a67ad04000000b00478763c1869mr749494vsl.7.1712267905791; Thu, 04 Apr 2024 14:58:25 -0700 (PDT) MIME-Version: 1.0 References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> <20240404131734.5fdd7380202cafcdc44a4d2a@linux-foundation.org> In-Reply-To: <20240404131734.5fdd7380202cafcdc44a4d2a@linux-foundation.org> From: Frank van der Linden Date: Thu, 4 Apr 2024 14:58:14 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid To: Andrew Morton Cc: linux-mm@kvack.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, Roman Gushchin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CF0A3A0018 X-Rspam-User: X-Stat-Signature: cjxdmj7o1zddrfwbbpm7dohm9yt37bf7 X-Rspamd-Server: rspam01 X-HE-Tag: 1712267906-714813 X-HE-Meta: U2FsdGVkX1/01Jwgd+iPCxaq4j1u2S3uYffkC+WmW3mEiG26xdcwH5kF4dSTFHPCt+YZY6HdMaOnaFm3Jsc+n/GcI9yXVsTKVmp71dCxhjeJTv/rl/hY1sxBH+IB6/oDLnzHCmCYqSwuIdRiY/AXrevqa53J6hJ5KdnRTmdBRm+Xpe7P80YJftVXiLuzv9P0XLywhIaCs3UtdhGuAe4NiBDGaBgpMw3aRUA0iCS8dOx8gbZ0kp+p72AXMUQO1gnOeTWIpSaMffToFb5tni7CVpdtaHRGbXksE5u0KixYuaZXZlEhFUGqutIaP9xgz5SxkMxH5VGFASQ+hLt3T4Qgsbk3Eh1UfklJZFql63viN7dZ1FsD5kMcH6FXjY9m2XXu8DiWB15/jHYjpE8zURcLUGYeEukUXlKU7x5VHqMt4xW7sPk21pegCko9jbDzleYaGwFiEzqXX48WZqSFqHpf5XXt/xXBM8DjYjKhfafmK6/pfLx9h839ILE5EW902wVYGBdZOrzCFUfMYAcvzcUBft9e+IxKRuTaBQMBcOacL9Cvf1JzZXEuztqMKe3Sl0L2pJD1tOp1bf4SjYu5P5Zjz8SSI7JFsnUkxmfEaeF8rx9ugnSnXI96/lY1NJXbNfaYSdNE494m1IGtTdyIC7BORtiNusna2goh/i8ecvCGKaWhFjI47KuE+79sap+uYEcoV2TRXKj5XLKe/eCF2J8wQZ+QzxmoUsls98hFf16B6knF7VcnWDpM8B18goxYPRloN2mLv/N6uswjjyGizaJG3tmZFD0unsOud1OtqzdLWpCmb9WkWUI5541fzVpDTUlY/WtFP854QZC/MDpBkHfsgGr/6KHeK1F6LpVgUAsb+lmHeTDQtCvjd+YjzY8GNtJCtH+vxmOCXZS0B/OdUz6t27MnXUenAprnEc3PkSx4hB2b7MPfDGzS7ov44j3NjHqzUpz0xgg6ab1cuMmtYvG NIymBQ8z +TbObY90lPtpng4h8/X6hE6jGmkwyE0dABOHE0tE23/UNQQY9zDFPnoVVucR+GAgNLlFXeyLmWSsOgWG0RCmTrdxxU65Z2wSbjW35KJo16N1XRDLqlOhQkXZdQX7b2ski9Qgk25vNbkK1gbm8pKhmTyZxfDvYwSLNmi7tBLEp3BJqhIiVm2guH+A3BzcLVKLT5iS1PwkGOWysxRKLOzEKc7Q3lMLdrtH2PKjIbJORXF34qfZg/OxXvbzCt3L4N0LCTV/6FIKFKJC0dJss52NU7zCncEpHCEjGUd4v0Jq8meg2XrOeI3rcojasTRCVWvAN3JaelQdgax24jiNws9pn3GkK0UAgZ+gOPiri X-Bogosity: Ham, tests=bogofilter, spamicity=0.000362, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 1:17=E2=80=AFPM Andrew Morton wrote: > > On Thu, 4 Apr 2024 16:25:15 +0000 Frank van der Linden = wrote: > > > The hugetlb_cma code passes 0 in the order_per_bit argument to > > cma_declare_contiguous_nid (the alignment, computed using the > > page order, is correctly passed in). > > > > This causes a bit in the cma allocation bitmap to always represent > > a 4k page, making the bitmaps potentially very large, and slower. > > > > So, correctly pass in the order instead. > > Ditto. Should we backport this? Can we somewhat quantify "potentially = very", > and understand under what circumstances this might occur? It would create bitmaps that would be pretty big. E.g. for a 4k page size on x86, hugetlb_cma=3D64G would mean a bitmap size of (64G / 4k) / 8 =3D=3D 2M. With HUGETLB_PAGE_ORDER as order_per_bit, as intended, this would be (64G / 2M) / 8 =3D=3D 4k. So, that's quite a difference :) Also, this restricted the hugetlb_cma area to ((PAGE_SIZE << MAX_PAGE_ORDER) * 8) * PAGE_SIZE (e.g. 128G on x86) , since bitmap_alloc uses normal page allocation, and is thus restricted by MAX_PAGE_ORDER. Specifying anything about that would fail the CMA initialization. - Frank