From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7208C36010 for ; Tue, 8 Apr 2025 21:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEA236B0088; Tue, 8 Apr 2025 17:08:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A965D6B008A; Tue, 8 Apr 2025 17:08:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95F3A6B0092; Tue, 8 Apr 2025 17:08:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 789BF6B0088 for ; Tue, 8 Apr 2025 17:08:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7A69259386 for ; Tue, 8 Apr 2025 21:08:24 +0000 (UTC) X-FDA: 83312114928.10.41A0C83 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf04.hostedemail.com (Postfix) with ESMTP id A19AE40011 for ; Tue, 8 Apr 2025 21:08:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FYWanLlW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of fvdl@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=fvdl@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744146502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cnu3bvgHMxtoAUB0jZkySCT3ifjhzRfTKB6ZlP7NxGo=; b=yh4e3hF5JeuiTsPydBmOWSy31jj0xCz0gm01BbBFaD8v0QwvKTMj0zYB+aZLAC/y0ifgZc +bQ0fYaxgDRvrcH7Q+8qqPStTspmURrGBWi8D274rUoogWy/byNM5Yef/8TypVjz5Fymd8 7fg7FXDpQFRICC6SF5ESDoMJdCpYwsU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744146502; a=rsa-sha256; cv=none; b=ozwrscCx538DpR7yrJPRr6nziWRXOWoL6Lv3pwzEfELV/Yf7oBRFXQLEXYE0JPCKZwidrG Yxx/eWcxWfZCsDA125w8NfCksRw1cEbT0dMYNcM0AuxwtqjANWAE+8mPGYoY4GzqZ1j5PR za0ZkfzmhX30kA/94tgyO2I0m5geB88= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FYWanLlW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of fvdl@google.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=fvdl@google.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4769e30af66so36121cf.1 for ; Tue, 08 Apr 2025 14:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744146502; x=1744751302; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cnu3bvgHMxtoAUB0jZkySCT3ifjhzRfTKB6ZlP7NxGo=; b=FYWanLlWI1w0EZ7rrTTA5C6t962Hi/aZc/EU/uXCL8jFSK8+J1A2td9FdhvG4oVmdZ C/WeqPQKUPhKF0k12ovF6D1YOSsyIxwPF/EAIcrUQr4E0fCsqIPCorKsMYEjpg/BevbH oWZx56HDkJa41UHha56LMx+LhiGAXjdlQklM2l4INm8C+xWWHDOsJ4r72UxrarDScZLz 0/+YVArhKApdjaaZ1qew/3vvyJrIcSOj9vdlCvJdwYwDNNCYBWNu5S55dI0xYOT7bh/3 eUZFQ1bsnPv2XtPqMCqFBlbsBF044k6ZdspXnSq2C+bbmbr7IuKZi9JyG1ExL9DRVqUH lpwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744146502; x=1744751302; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cnu3bvgHMxtoAUB0jZkySCT3ifjhzRfTKB6ZlP7NxGo=; b=MNQP3VIYP56m7xg6HZ0uaPgB8YsdKGnBN4HYlbDxowJWlo4z9OJRY7BgLgqMAauR2L 9zgCSSDCta7fyitV6qroOCreLteTfIxiw46Xnq/kJfIS3OSDzwEjyH6+0Tn37+OTPfkA 8/Xe9OCX6ImGrRjWaQcoVeIvgzyrXcBNHf8FscjG4r0R7adphi6uRkNhV46ObhKFr31Z jNlXAI0Dp0ypai135YpsV9gGJZiTxvxY9Ws7rj3CZxlbzPn/McLxDlYdiIGmuOfoOS1B LgRByxpuXk7v5bn+vf4ZzX7uIHgZ2yyQKtalfTLpId19ks8vzw0Etgt2dAfAeJVfGey4 wDFw== X-Forwarded-Encrypted: i=1; AJvYcCVLY9OsLLYJEweYgD/sP/TDxrhGKeVA4YWueZgMRE+MuF9mXKOAV/fckgnPYI/rA0JdoJZeAFtAJA==@kvack.org X-Gm-Message-State: AOJu0Yx1Jn4qUBY3hiq0EF6f1rakN3qouqdbMfLTOZhFoFtfmRyOrt/8 ZzBVxGJ6ZxXdRIfeGEELqea0ZXUu0a68ToZnMC3cjrfuBHjZDA9jevN36EHSv8To/rfXn5sRfYT DXuqLMy3o6azDRQP/Uenl7RmHTAOZ/67bGxy0pIqUoG65ULtFKw== X-Gm-Gg: ASbGncsFO50pcli1U7pmSTAAmm6p6sSfNoJha6R4rEJai1Mr9A4BE+7TvwMEpdXemlq F6HMcaPhrNlUNGWaeReV5UPTxRLG+itcvIuGQqKPFVuMLKhNLQHluWG+IV45qjseVBTeWidQaow kjLoGV+8c4A6Nf0+d0HLUd4d0= X-Google-Smtp-Source: AGHT+IFmyRrY9b5XrzQ6iow4zsbUyYUHGybURNKUpSZXCrzuiJUT9EOG0sFZeJBexlw4mSW12aq4Fv6vjlduxCNdFSo= X-Received: by 2002:a05:622a:14c9:b0:476:f4e9:314e with SMTP id d75a77b69052e-479600a2bd2mr151821cf.25.1744146501531; Tue, 08 Apr 2025 14:08:21 -0700 (PDT) MIME-Version: 1.0 References: <20250408164000.3215690-1-fvdl@google.com> <20250408140357.9a708f7547e48d2da1d2fc34@linux-foundation.org> In-Reply-To: <20250408140357.9a708f7547e48d2da1d2fc34@linux-foundation.org> From: Frank van der Linden Date: Tue, 8 Apr 2025 14:08:10 -0700 X-Gm-Features: ATxdqUFwjyzXo9A2CI9xTBTKMZAAWfOz1vt__1iANqLvh9kPsm1l87QYthjNUPk Message-ID: Subject: Re: [PATCH v2] mm/cma: report base address of single range correctly To: Andrew Morton Cc: muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A19AE40011 X-Stat-Signature: gu67u679dkqewgnnaifdop3fncccajee X-Rspam-User: X-HE-Tag: 1744146502-259966 X-HE-Meta: U2FsdGVkX180c+AYy3VxOSon+8MGKCbzQqtLHRTJCFmGglU2j3L6xT53h8RKd2n6E8jdIY7zSHEutimGOEYyVUK/qJiDBoUPADtbWgbySDlNAZ9ElyYChKX98DslJYIM59ReU82BY6jfMQXkkdelqvMrVgLIzMy9LSHFq+AFRP342Kz8Uw3Xa+Flaa12vxnS3bfRmuX//6GXGckqpwYx26vqH+79ecwFTPL9xIJim+eO99boPTwF9ujwt9XJkdI7dStNQtGhZhuyLh23AWeto106WuYEeOjfYQXZGvbLXHZAouAz//KTIXvnk2sCijsbvGr2BaOnv8K0MI7385mRq8hZrVyDPrfhToHkGBIEpMev9+EoCSMU7xvibgQdwG7tQj9nO+dnJmIRUUfSA3wmoPQdGm1LaweD7hOeYX4ShWMemS0msie6iKtN480DxAt0EG7Gr2pNpXA8RV4iPmo2qo5u/o7/DzAfFKhx00d4mLi4xQHaIUOFRVAgq2GohagwX5PoR3RJhj8p7HTdi78G3NRxBUXsGPhEU/v99NDNlaLLwUYShu2NcdlYH8HyGolDvKK/FLDQRdYCioMNd/D5xbxHKGiGFi3OGDlg0Skr04clrppr98ZMc+XS3PyL0yOsKUxox/ehU3Znvp8N+se4GXmsGDby2Fs6UIsehtp+XI617AhgvWyCELpUte7K+Ghs30Ykll0ms7Ew4bYzh0T3Tm8+hTFPz2k/jrvjK+NEGfOqEX4eoX99ycLRbpuid1rVICZxIFYq6mkziYGspb91r3T9AaK1OYytM2W+Dk/w2O9IOA9aq84vPWAsMye/wW52Sz+7tAJxgD3ApbrAHy928bmeCAwAJoTU4v9slIg4I78ZGzEV/AZprJ7tA/6dQbUUoxJBvmLfb/oMoTQ1rGe2Ywr6JMo+R4K6XvYpVnd1MuUguDMGfNeYhrJd1uy3pXSNtMlLAKBiUJZNg7AiS8a f/YR9uqt boY3T7TmKSyAPFGrBBfZIBXH1ySmzW9U37f4VxdrYYCymPp3hOdkOWppeN+8cMJYQfXgsD4d831bLXBcgVtbA1LEzpepRYTXaJ2uVby9Gfp2eC8YAHfTZfuSG5JWQCi+JNx8XnU+mPkxRNBWFX779fdT8PiqXdXC1/f/3c0N2UBNkvFg/QUfHOOr2QaCABeHpEaDYJq2etoETYiX9tcGVMSGwxIoWDvVMKnu7TP1mz9saDNRbvUw29Fwrx1IVC91WVWB/CO/3brMEZX1OkT39qZrNgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 8, 2025 at 2:03=E2=80=AFPM Andrew Morton wrote: > > On Tue, 8 Apr 2025 16:40:00 +0000 Frank van der Linden = wrote: > > > The cma_declare_contiguous_nid code was refactored by > > commit c009da4258f9 ("mm, cma: support multiple contiguous > > ranges, if requested"), so that it could use an internal > > function to attempt a single range area first, and then > > try a multi-range one. > > > > However, that meant that the actual base address used for > > the !fixed case (base =3D=3D 0) wasn't available one level up > > to be printed in the informational message, and it would > > always end up printing a base address of 0 in the boot > > message. > > > > Make the internal function take a phys_addr_t pointer to > > the base address, so that the value is available to the > > caller. > > Changes from v1 are: > > --- a/mm/cma.c~mm-cma-report-base-address-of-single-range-correctly-v2 > +++ a/mm/cma.c > @@ -722,14 +722,15 @@ static int __init __cma_declare_contiguo > } > > ret =3D cma_init_reserved_mem(base, size, order_per_bit, name, re= s_cma); > - if (ret) > + if (ret) { > memblock_phys_free(base, size); > - else { > - (*res_cma)->nid =3D nid; > - *basep =3D base; > + return ret; > } > > - return ret; > + (*res_cma)->nid =3D nid; > + *basep =3D base; > + > + return 0; > } > > static void cma_debug_show_areas(struct cma *cma) > _ > > Which appears to be just a little cleanup? Correct, it just fixes a style nit that Geert pointed out. - Frank