From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C05FC4345F for ; Tue, 30 Apr 2024 16:20:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F054A6B008A; Tue, 30 Apr 2024 12:20:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2746B00B7; Tue, 30 Apr 2024 12:20:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D52C36B00B9; Tue, 30 Apr 2024 12:20:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B4C396B008A for ; Tue, 30 Apr 2024 12:20:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6EC8A80904 for ; Tue, 30 Apr 2024 16:20:36 +0000 (UTC) X-FDA: 82066711272.17.DE46D5B Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf01.hostedemail.com (Postfix) with ESMTP id B237A4001A for ; Tue, 30 Apr 2024 16:20:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="po/iLWyA"; spf=pass (imf01.hostedemail.com: domain of fvdl@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714494034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KEtrK3qxDuRYVwOw3ESsbxVxDvF9U0HXAFKtExdTC5w=; b=fdxtoyVygbr/7jM3VOiw5TBOhWyKWzGAn3th1ZYcixD1+pwVnhVFoTVxUjqCQiydumUHPG xjeJJRBsgbe3u49oZtQFxtADEDJzLxY93u/Cv9hSEDWHeCq3B9K2vS+YtcyDl47KiFbgt0 qOrhJB2wxemG+M2YBkbTduYBZYWK19U= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="po/iLWyA"; spf=pass (imf01.hostedemail.com: domain of fvdl@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714494034; a=rsa-sha256; cv=none; b=XBY2XSqhXvPINhqTaZNN3rYB50ek5qxL4uDK7nFLJ3yuMIGqvcj+RWzjTVlsStci655y4e 9O2AbFcmMq7nCs+ZkFDP6yuJWthW9ei3MNBpRoR2/cEHXnE0ReewwAv3Z7L0VUIaafLRQM kRWLJPjZSKXDtV7jsf/KmY3k2mv/B9M= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-dc6dcd9124bso5902128276.1 for ; Tue, 30 Apr 2024 09:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714494033; x=1715098833; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KEtrK3qxDuRYVwOw3ESsbxVxDvF9U0HXAFKtExdTC5w=; b=po/iLWyAhDauHD8NuRZv2pBHdE9CmcaU9trlwe/qRFoq0ZbPHs9nCq7XphAr43OU0x JkWiObAfQPl8qd+5obSPralRpnG00qEYb5qlBFxqF31YRInCFyPdsfKu6KnGGeqnSOZN wv/fLLNVacQmTgch4GWhRJyWJQjMbUkPY3TiPsBN0stWGfPk0eMe6M5EkD+Wz2U9hKVG v7U7E1bUJNVZU6TA2T+XAgryHC5CZhggSABsaiT+NCCbfkpemdLmPK0B3JgzzNbeEzqQ SzRxWLnf6/29o+u1FKn9pP5hryRzix+plnchkIVJKxpR3ZO2oGUJu/a4NiJzww2z14Dq i2og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714494033; x=1715098833; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KEtrK3qxDuRYVwOw3ESsbxVxDvF9U0HXAFKtExdTC5w=; b=B1xvn+DsgKTsFft7KcP7Q8tnL1K+/zUYjTA9AJdreznP7X4yh9kuof1CIh8y6lzf2J enfa2Tl5SagQRHt0DjNBHQJ7Y+la8LPLgjVsY63m2mHryKIJP8fXiMaSZ5DrvatXwgn6 renGllWZZetBxPexxSAZntiFxkYijTnPrN8P2vO9LTKpVpzf1Btx7kyGoRn0yj8ZtncX RXmeRznlr2U7EsnnS6z0CfXIxvl+uQukmr0pq6OcXQXiP4xCdP4brhTXZZAe5Ur+asm0 bmXaH2lL3JgoHOGlBhaRdzPUmb1ir0PaR83rND3HZ3P9Jey8axNxTkIBgjrRRxb9VCPN fS4A== X-Gm-Message-State: AOJu0YzOxAcX8OWIGTQA9ifmyWFpcMCCj5cwYpZoJt0r1ZbkPyvMwlHb W8U0VEUCGShWDTYZkwipLBY17Ga3Vi/Mp0PJm/TKsKhFB4fV+1gsUoSZo9NV+KcH6ygN8uvhmJ0 ONR0ab9HbfkKkjrVmPY3KtoY9e4d/Fv0rHEDNpgajNkpCZn3w8YkA X-Google-Smtp-Source: AGHT+IELPiyYZO2W5SWMYAV/NXcUwl2eP3WFiKv6HN04TdUu8mgKQ9axzX6fizUiSeDsLiqDqz+ruqnKSgfwNjBrR7M= X-Received: by 2002:a25:c5c7:0:b0:de5:52a8:5d34 with SMTP id v190-20020a25c5c7000000b00de552a85d34mr18913ybe.43.1714494033265; Tue, 30 Apr 2024 09:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20240430161437.2100295-1-fvdl@google.com> In-Reply-To: <20240430161437.2100295-1-fvdl@google.com> From: Frank van der Linden Date: Tue, 30 Apr 2024 09:20:21 -0700 Message-ID: Subject: Re: [PATCH] mm/hugetlb: align cma on allocation order, not demotion order To: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Roman Gushchin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d8w9zz9s7i1yywgbz96kuhon1tq78bbb X-Rspamd-Queue-Id: B237A4001A X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714494034-214487 X-HE-Meta: U2FsdGVkX19dZ43SJkGvJFchxwv7fS+UE4Kl6Sfc5q7ItduXpkAYOq1+C9+8bYwnIWrKSSu+z+brw99YW/bnu+8CZi/b6bbrfWXB3AdaL6AyZAcGSXquwZbEoSftfyg8/VK2ZTjsCB3GNnZEqmKBFUcPBEzi3z0tqtGU7gNAIu3AE6SZuBaLHd/DxigJNg3ZQfBeLL6I6SACh0fppvMBUB5JfmcSzrm6F7hvnyit25kWm4sj/5y+naKTj4L6/f2YeNyhJK5I1sC1vyc9UVHZGwyapPME4fhcdHaR82JlGpZrVnDRLlq+1hkeFYHcoZ8QA4TqJmff0fdS8rLZKTcW/AiqjLMlKUIejyrrm/ztiTsiSmBIIB8e/ncrn1o7DQqN3vbuP5AYpxImin9C24dAqDzya2GNnKvuuJsJoxKg+7bvmnHmlaMsNicaWLkmNLO/xDl0+7Kn/baanN2CHVmI4j47n5RFHaw5jUjqtM16mzAWDuHUNa28y6FPvVQXUgBZgqefmlJGt8b8TRd3KESoRmj5zgRNuzsrx0T8vUgf0bZD6Rn+LvW9/lUIiKH7SEpudRLDfCX7bJQfWEmK3z1bw2ycCudCe0XgN+gO4rqVI+K5KSt13lEmQgqMqkmo3pQjXTDQJ6OX7sN03LN64gBm+xWJZSgByHtXe8uwLalM5X1zrzuTOnlK+19Fjkp69VOGdek9iXOAUV5k3b7WPIK1QnUoQhw5uxi66QwHYXLMZQzxDf7882V9JkSwPRcZrQNHJC8QpVVWY2xP6GHKl5ML3APn8PnKaynxl2krDqv97aDwBWNYJPjZP2F4uRlkv62gGxsrhTbuAX0hSfVwmlr4dakISfoNB/x7IOGv/UnZIgNZXUe1xMMDZgFFFSSDt1BTo7tS92rPac/+J/T4xan6IGw53HFmzmxFJC+fNIv3ebTCQvlYd0on8n6wZuQUKMojm1DjCCboqAo3+kztBbq /z7Tm3Po lPWEXueNAwsIslrbK0R8sbmZcZo9LM942dFxxIjv3+jad7mqCGcjk34S4/8/s9ASt2Mc4vqi7REbHMPhL3uvvIbPATxj+7X6GRnITIss0aMsy2DO5JA62AL13p3ckPAmjhZXFrp3Ov8jQTXZDwKV7WsOxLF/a6ym7nLfZuXuVcbWOvG3VbD4/PKr+KC8QCIuM8cnV64e3VItyosK+LEBgQz4h7Lg1x9AbESoUuPF67yFJDMLYrqXiJ/QEaxKJKZt8DgNmt458MkPojBkFG2X4ApPCTJ8jpXhahuAjzHf73PIBUs3c4oOb7RvJCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Note that this applies on top of: https://lore.kernel.org/lkml/20240404162515.527802-2-fvdl@google.com/ ..which is in mm-stable right now. It's not a fixup of that patch, though, it's a separate issue. Although they could be combined in to a "fix arguments to cma_declare_contiguous_nid" commit. On Tue, Apr 30, 2024 at 9:14=E2=80=AFAM Frank van der Linden wrote: > > Align the CMA area for hugetlb gigantic pages to their size, not the > size that they can be demoted to. Otherwise there might be misaligned > sections at the start and end of the CMA area that will never be used > for hugetlb page allocations. > > Signed-off-by: Frank van der Linden > Cc: Roman Gushchin > Fixes: a01f43901cfb ("hugetlb: be sure to free demoted CMA pages to CMA") > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 5dc3f5ea3a2e..cfe7b025c576 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -7794,7 +7794,7 @@ void __init hugetlb_cma_reserve(int order) > * huge page demotion. > */ > res =3D cma_declare_contiguous_nid(0, size, 0, > - PAGE_SIZE << HUGETLB_PAGE_ORDER, > + PAGE_SIZE << order, > HUGETLB_PAGE_ORDER, false, name, > &hugetlb_cma[nid], nid); > if (res) { > -- > 2.45.0.rc0.197.gbae5840b3b-goog >