From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31354CEACF3 for ; Wed, 2 Oct 2024 19:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5FC36B0120; Wed, 2 Oct 2024 15:50:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F736B0124; Wed, 2 Oct 2024 15:50:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B08E6B0125; Wed, 2 Oct 2024 15:50:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 68C716B0120 for ; Wed, 2 Oct 2024 15:50:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9C3EA0453 for ; Wed, 2 Oct 2024 19:50:23 +0000 (UTC) X-FDA: 82629703926.13.EB7ABFD Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf22.hostedemail.com (Postfix) with ESMTP id B485FC0007 for ; Wed, 2 Oct 2024 19:50:21 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0zmLoKOr; spf=pass (imf22.hostedemail.com: domain of fvdl@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727898493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sb4jGv4oiF+aP2ySUIWh2+NAs6/SQ53nUQHq1ghlQgY=; b=NO3fXRfHm8l9prCPpyFJMETQf+lRqwiD5MvLqQmmgrivDEDY31k2goB6kgLV0OALTQBxV6 v2SxDrm0tTyij5sHrnbUD4fz/jaHcUZByBORTnJ8PfGmOQ/BoaxsPoSbLsR8sCjiWJY9fk Psg/KQua6FK1wnvzWd6Ba57tVQvZDZU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727898493; a=rsa-sha256; cv=none; b=1C69ryfqQczzzcl190grduBEYtyBp+9ZWDyeTW3bdvBnehbOfwZDKbir1EQdMZjH4sjpu1 KREVotmegCtLMC7AIXgoUU1q/B7OtohJ0iczUR67P6E59gxfaowk0ZW1NsovTAsDH5ybGW VcQ1bPhn4kKq6JwYv0F//qvJJXJbN08= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0zmLoKOr; spf=pass (imf22.hostedemail.com: domain of fvdl@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=fvdl@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5398a4ae43dso803e87.1 for ; Wed, 02 Oct 2024 12:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727898620; x=1728503420; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sb4jGv4oiF+aP2ySUIWh2+NAs6/SQ53nUQHq1ghlQgY=; b=0zmLoKOr5AFHaGzI1pmyWKUqBRp/jicxaD3S7bPbg+HlILPHQ0+6et+TnER1dDAdFY DLdUTH2oohQjQkxLBhS44dAbHfbV/7qohNPW8gMbnxtUpHzArs+MV40egfBHO298ELCd LmBmgs4Sckl6O1LVpixSJSjl56in7xoSsF9vsw/nt/VX2I3HMfaS6kpes4gvfpLMw8nI sDpg/gvj3dLWljFY3pH6f4e7gEVV3PS4NBsdDMMf5PPBpUbcJ7nGY+XWuaM/VXXGhSxE sEielGoUy6GBKsmX8s7KcXvrD1BLoprLnOm04BYzt2xnlZUbOoq6lkNpSeyaC65vFqX5 MlLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727898620; x=1728503420; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sb4jGv4oiF+aP2ySUIWh2+NAs6/SQ53nUQHq1ghlQgY=; b=LZkaodRQPKrwLlCsv0Mi97yKsABNYsitWsG2bADD2Kza4DDE0UBZCcs/AiH2DjcJAK 9LIdR7NPLAl3csE/ZwC/wkwQilwBMl75AOZuPtPVGdBU4MIwkjCXxnAhMD8Hq1I5NHJd yAYU/0qa/WnmpLnETZY/B5g7D59O3KK0cgHT7Qhs7Z9qQzzJr1AKxZgXF6BNN+ljrQwL VK+1Qd+tj6N2pyXvKC1SlClXrq3KHPQa5XF8I5QLZGYKHWcUz+XkfxQthI1PVdbgcRzJ cCrrhFkDcQXeyhNtlqYFXFB2FC7qKspuxkzspZwZpRqkKNAt57MnAow5P018CWZKY838 lt6g== X-Forwarded-Encrypted: i=1; AJvYcCUgHRhNewZfGWhvArrPTMlyd3mtJX4BA/Xlx/yiZQB2Dh+TviGCdRMmr3CNkLTWD9XfvmFGCqBJ9Q==@kvack.org X-Gm-Message-State: AOJu0YykYrhXVsz8xq7rpS1BOPSoq6160q2fz80zBz1mCScFXZO9vTer gGR4s8CPy/nYh34EID4zwNPr+Wycf19oVj9qR+cAvMXXC2WZaGfSdYLd4JwdZ/4+EJz194K7aP6 uve55O9Qn5LBWNXCt1XT2tgkP3KL0ccDNjW9Z X-Google-Smtp-Source: AGHT+IGN5UynQItc9q1qMYS3sPfmE8YHPi7E0D9y5ZC5A7Q1slUP8RRtIijrFYkR2iXbgCBqJqGkp44KTdfpR/G9fG4= X-Received: by 2002:a05:6512:b07:b0:52e:8a42:f152 with SMTP id 2adb3069b0e04-539a6ed8df1mr69482e87.5.1727898619453; Wed, 02 Oct 2024 12:50:19 -0700 (PDT) MIME-Version: 1.0 References: <20240929032757.404707-1-gxxa03070307@gmail.com> In-Reply-To: From: Frank van der Linden Date: Wed, 2 Oct 2024 12:50:08 -0700 Message-ID: Subject: Re: [PATCH v2] mm/cma: print total and used count in cma_alloc() To: David Hildenbrand Cc: Xiang Gao , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gaoxiang17 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B485FC0007 X-Stat-Signature: jsobk37p5i3te81ine6bk6gzdbe94adj X-HE-Tag: 1727898621-308334 X-HE-Meta: U2FsdGVkX1/A9rojwcJ/wqsOLYAl2VvEZ3bsdBzVvoeJo6WBX0ZHidzJt1gilJXBPW5kZTBWCaTak8q3QUNAJtffpkkMVksf7stM0s/wAz/GZv5QCC66kxhxQSoYIJjuYfdG9xXb90TzmWiMTn909qdUM2ETm8b6E/pu6kCoThprfn43rtTMtkIHJFOtRv5KQ3iZ0EnaCUEDtlHvrgFcnHWYd0J8O2wzqICH+GnXavj8aNnFJ6RURymO/WByGDIVH+uLX6si1CjnA4cqypU/TQW6WnXT0EqEtIWD2GdcSf69PDHwwIPLy694AgQKqZi1VlNl04my2649ObOiznN9rztyCDya6ED7rzzmKghr1Rf6qeuuqb+wOIiP7qGhA10/L/kxzgT6OGLpkDOdiWxumZsvLDbBHQE3A6V79yDCdeOHkH3UizFEB66EqLo7eCOuy+1BHjiwlYcohwlrqnNXn6u4UiUZvdIxg06Pu98I021FPeHeDdHCSnI54pK5lWuV6O/6Y16cMwzzwZl+P3zjE0QWNQHKbpNudC9hNlpOiB53nwx/dV5dXkEYOqja3Hm3Lbno74eIb9lhhkUgwjFtfe5U5J/L1hmqoOYiHasWOcdPA1plNIxO5A4Uv7awC1pPPwMgAkb5puqe9ZVGV0twEMwHW0AywHEnAnRBXVtjQcZ5ACuTTT4pnSy9epwtJ+ddx2g4aoICaym8kTeJOjwVAP7CKDmfD2dxJ8/UHWxCkqphE3BzpgeAuEx78ZoLuoC7K9X5PZoOhaIVuNIYGXGOAzCGYMxCCtxKuHU40vcEWdjD2w/SckyBAzubN26TkjQBSnvO1oLV+QXQ2UAoLvQlAFvGl9ITlJ7MdynJABV2lJlm3MKbd8hkb7p9WyJe3lQ6S2N1OhtDTVQvyvT2B+LG1LyO1gE9GC7PVxcM+zBg2n84QY4PIK00ZJ0qXsA74oKT4IKWcn4OtjQ/NsB0IKN t39H8zGf GDdWg3n8QAesdjnzvzLhADsJMXqas6m17VFQzoXOf3VuRWaj8ghTxzxMDBdr4yZgeNs67sqLVMouMIkOiCFJBob0yIXFpuhd+JLeUALq+/uk83Cp3/AgnGngbVV6aq1EKxBftS3CiWh+I/xKP1y4AfaMb/3iYaQ3+s+dHRiemUPB94RLchan0Vj7YwPg6uIUAkHvG9WDIr+H+aqcZwshRw0cm6if45rs8iI4HfFHNAJEfRGcL6rLnl3Z0Sk15mm0liUoBVUK5qmhtP2G9YzXMPM7oIZ8tZNTckrxZRGF945HBng5F75rGb4hl1VYe6qdPufOvf6InIB1OS0SycbzWsmWAwFWPDnBbFa1AjpJSEEM4qBM5vJsYziOueQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 30, 2024 at 2:34=E2=80=AFAM David Hildenbrand wrote: > > On 29.09.24 05:27, Xiang Gao wrote: > > From: gaoxiang17 > > > > We should add here > > "To debug CMA allocations (especially failing ones), it is valuable to > know the state of CMA: how many pages out of the total ones are > allocated, and how many were requested to be allocated. Let's print > some more information." > > I assume Andrew can fix that up when applying. > > > before: > > [ 24.407814] cma: cma_alloc(cma (____ptrval____), name: reserved, cou= nt 1, align 0) > > [ 24.413397] cma: cma_alloc(cma (____ptrval____), name: reserved, cou= nt 1, align 0) > > [ 24.415886] cma: cma_alloc(cma (____ptrval____), name: reserved, cou= nt 1, align 0) > > > > after: > > [ 24.069738] cma: cma_alloc(cma (____ptrval____), name: reserved, tot= al pages: 16384, used pages: 64, request pages: 1, align 0) > > [ 24.075317] cma: cma_alloc(cma (____ptrval____), name: reserved, tot= al pages: 16384, used pages: 65, request pages: 1, align 0) > > [ 24.078455] cma: cma_alloc(cma (____ptrval____), name: reserved, tot= al pages: 16384, used pages: 66, request pages: 1, align 0) > > > > Signed-off-by: gaoxiang17 > > --- > > mm/cma.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/mm/cma.c b/mm/cma.c > > index 2d9fae939283..90b3fdbac19c 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct cma *cma) > > spin_unlock_irq(&cma->lock); > > } > > > > +static unsigned long cma_get_used_pages(struct cma *cma) > > +{ > > + unsigned long used; > > + > > + spin_lock_irq(&cma->lock); > > + used =3D bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > > + spin_unlock_irq(&cma->lock); > > This adds overhead to each allocation, even if debug outputs are ignored > I assume? > > I wonder if we'd want to print these details only when our allocation > failed? > > Alternatively, we could actually track how many pages are allocated in > the cma, so we don't have to traverse the complete bitmap on every > allocation. > Yep, that's what I did as part of https://lore.kernel.org/all/20240724124845.614c03ad39f8af3729cebee6@linux-f= oundation.org/T/ That patch didn't make it in (yet). I'm happy for it to be combined with this one if that's easier. - Frank