From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81B6C433DB for ; Wed, 30 Dec 2020 13:42:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F9AD2220B for ; Wed, 30 Dec 2020 13:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F9AD2220B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 593538D0086; Wed, 30 Dec 2020 08:42:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 543C78D007F; Wed, 30 Dec 2020 08:42:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A238D0086; Wed, 30 Dec 2020 08:42:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 2F05D8D007F for ; Wed, 30 Dec 2020 08:42:08 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E42BA1EF1 for ; Wed, 30 Dec 2020 13:42:07 +0000 (UTC) X-FDA: 77650062294.23.lamp30_08102e1274a5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id C2F2337608 for ; Wed, 30 Dec 2020 13:42:07 +0000 (UTC) X-HE-Tag: lamp30_08102e1274a5 X-Filterd-Recvd-Size: 3370 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Dec 2020 13:42:07 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id p187so14709013iod.4 for ; Wed, 30 Dec 2020 05:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dUj2WjSpqQLcqlN8UUnmEWJx9j8l+px7OfZqNlRWbo4=; b=ptoC1ga1r10YXdrJmNBXpdltzmqvnmO26GrH7dl2K40hEnTGyvi5i96sj2nP42DyQx y+ONHv+CdiqoJJ1/zamY8j4DYOgeQADniB7HFORhrjf4ffr5yLhaj6z7v74AyF0x1z34 p7wH6rLWHsTRBwQ8RrCMpg9RjeO6/lavTFdjRCbcmNkVt347P2Jy+KLgF7OAtpbdYNjF VEYDFHrOGlrBjuTzpL/5ZOD/VpAvyJjjaPfguBVqvk1UBLA6Kv89rZxwX/mltOKeig5x x5xkccxI/34NkGar/u5SjXw+YnpOIzn8KAU7G0wN0iZGxbFLRIVcxQwS+Teks/fu9j9c /VUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dUj2WjSpqQLcqlN8UUnmEWJx9j8l+px7OfZqNlRWbo4=; b=S/kOrgTqIn6a8TaVft+xKPvrzc15kXtrlZ0Ljix0/d36QFSdghaiGYfsYaDjvTftcj +02Do0CBncgoD6v0oXLr9sc64wUOwAo22oWB7ZjUtY6tAeiR/ZYx8JYQqP++oBn9gEUW ILMYLHRxLiqhY5JQVMkndpmMFk3mbGWOu2iawgL7pXfuem63MaBCjxvN8bQP9f2U/z8K s385Ux3Y3mCh2viv8cfAYYdIUCnxpiI3u6RqJFUD1xwjPCT180xYqdwPlgwt3Gt5zWnt sTW6ccoAo+/8CA11IOSVhMB9aWVT7bd8QqHpL2QoaRWCTmWU/agZ0QwHIbN1uir6VquH bbVg== X-Gm-Message-State: AOAM530PHTY7kwJ3mAdGRVV0nEZAL/zDsJuNbk/za0hEY+xGYmCemrXV AGGvfNDbIc6Eif9kwkz+wpzs7ef8O0cpNhAyXfg= X-Google-Smtp-Source: ABdhPJx6Bggd2NgTflZjM7uwaeXoa2NO4c6kYSwA86/s8rOmvwNeeJk5mfcILfSU7t4w0DoIxhXWYOPoK3ucji01LZk= X-Received: by 2002:a02:cd84:: with SMTP id l4mr46075384jap.141.1609335726798; Wed, 30 Dec 2020 05:42:06 -0800 (PST) MIME-Version: 1.0 References: <20201230114014.GA1934427@ubuntu-A520I-AC> <20201230124233.GE28221@casper.infradead.org> In-Reply-To: <20201230124233.GE28221@casper.infradead.org> From: Muchun Song Date: Wed, 30 Dec 2020 21:41:30 +0800 Message-ID: Subject: Re: [PATCH] mm/page_alloc: remove the static for local variable node_order To: Matthew Wilcox Cc: Hui Su , Andrew Morton , linux-mm@kvack.org, linux-kernel , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 30, 2020 at 8:45 PM Matthew Wilcox wrote: > > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on others) That's 4kB which you've now moved onto the stack. This is not the first time I have seen similar changes. So what do you think about adding a comment here to avoid another one do this in the feature? > > Please, learn more about what you're doing. I suggest sending patches > to drivers/staging; that will help you learn how to submit patches to > linux.