From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB59C433DB for ; Wed, 30 Dec 2020 07:10:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6771B21BE5 for ; Wed, 30 Dec 2020 07:10:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6771B21BE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E71CF8D00A0; Wed, 30 Dec 2020 02:10:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFC1A8D007F; Wed, 30 Dec 2020 02:10:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE9E18D00A0; Wed, 30 Dec 2020 02:10:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id B58188D007F for ; Wed, 30 Dec 2020 02:10:38 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 84B0D3629 for ; Wed, 30 Dec 2020 07:10:38 +0000 (UTC) X-FDA: 77649075756.30.soap07_2c096c5274a3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 687F4180B3AA7 for ; Wed, 30 Dec 2020 07:10:38 +0000 (UTC) X-HE-Tag: soap07_2c096c5274a3 X-Filterd-Recvd-Size: 3863 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Dec 2020 07:10:37 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id w18so14048914iot.0 for ; Tue, 29 Dec 2020 23:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dz6zakxhTN9+Hb27qzL2JoTPTR2hDJy3fnAhKgXSzDc=; b=gwEYQaCoHeTnnujhW9VMYcJPWPdfkrdzbsXXYBFkSRNkwo8LO5odYwzd841ttNPBA2 YII/xF3VBYOs8HCqKxa4xEosWWTj76HlHJONYDiLzDOJAGWrNdWZYL3RU9Or+h2exMtW SeNnhSt4CAOPu8t3qcLsgqv3APCvREgULe5xYGFpxni60+76S82TohUATfKXCW0JuluD eAhyPregxgTVbPwlNyH0/hQR8YEYIxEMxlx714UupvIUoGkmWJ8g1UrNO5plyirkQ1rS dO4VfnNV3uvA6Wl9q5wgXjvj4rHvfvlpjG3dXpowyy5pplI8Qc+Z+FNkJobsYaZ4cNrH H3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dz6zakxhTN9+Hb27qzL2JoTPTR2hDJy3fnAhKgXSzDc=; b=WAPwzMLhd+ONz1BlE1I/sB2HQvVBKChGQGBudJFsQrFWkmofnzGsexSVe0EuLjoTEd E7FyhCgJuk9bnquGRUf5xfbPsPwfAC6DzlrNjVSKIUQERxUW1bYnpJRRIjUG16qG5euP xa+p75nFTa4VYVMp+wKm69rm8s7ZGd3PlcW31bwwci95Db622uBR184qCr042/kn+p2N 3yHFP2iEZXvP0NmmIZ3jaJP7LX8nm2rJEvw//ZVo6Q+qEk8DmE9WpYG8yTMf7P7OG22b ly/wEviFJXH6iZyDM6OFy5q/yTidnORUgXGxFekvlg/N0ahvhL95wnvynZ01sVgGfGx1 UqfA== X-Gm-Message-State: AOAM530CLPW+wo83OstPuUNy8SwQSO7m8betMSO4/QFEdEv6keXe/N7j jaDDZd6b+3ZD5BbyieDUOd0dQyEhSgXcBaVZWnU= X-Google-Smtp-Source: ABdhPJwa1pU0cCC/mMbtuyYhyfQ5lAhEp525njljVUnbH5HwXEXif1suUfiyhTYmnNu3kzqmTRhnt4MBPCVo2RsOBrI= X-Received: by 2002:a6b:d01a:: with SMTP id x26mr42140401ioa.11.1609312237524; Tue, 29 Dec 2020 23:10:37 -0800 (PST) MIME-Version: 1.0 References: <1609311551-97108-1-git-send-email-abaci-bugfix@linux.alibaba.com> In-Reply-To: <1609311551-97108-1-git-send-email-abaci-bugfix@linux.alibaba.com> From: Muchun Song Date: Wed, 30 Dec 2020 15:10:25 +0800 Message-ID: Subject: Re: [PATCH] mm: fix: Uninitialized variable ret. To: YANG LI Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: YANG LI =E4=BA=8E2020=E5=B9=B412=E6=9C=883= 0=E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=883:02=E5=86=99=E9=81=93=EF=BC= =9A > > The ret is being used but it isn't being initialized, > need to assign a value to it, like 0. Hi Yang, I didn't see where it was used without initialized. Can you point that out to me? Thanks. > > Signed-off-by: YANG LI > Reported-by: Abaci > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 605f671..15ba17d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3366,7 +3366,7 @@ static int mem_cgroup_resize_max(struct mem_cgroup = *memcg, > { > bool enlarge =3D false; > bool drained =3D false; > - int ret; > + int ret =3D 0; > bool limits_invariant; > struct page_counter *counter =3D memsw ? &memcg->memsw : &memcg->= memory; > > -- > 1.8.3.1 >