From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE6E6EB64D7 for ; Tue, 20 Jun 2023 07:13:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58BEB8D0006; Tue, 20 Jun 2023 03:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53A5A8D0001; Tue, 20 Jun 2023 03:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402B88D0006; Tue, 20 Jun 2023 03:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F8FA8D0001 for ; Tue, 20 Jun 2023 03:13:48 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07FC8140615 for ; Tue, 20 Jun 2023 07:13:48 +0000 (UTC) X-FDA: 80922261336.24.CC29A19 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 3998C100007 for ; Tue, 20 Jun 2023 07:13:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=KS2MlNlX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of airlied@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=airlied@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687245226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cHYZLznLEupvmNgdz85Wsrh9nTfIdkBiscUX255Az7M=; b=PDxX4TS22k/Hrauc8FTzLQREl9j3KxOkohMRKzdBqcavkXGQu9/OXy1Y1GnAQ8aQICetL1 0BpakvNbanx037skGXCH2lqeUdecgYyu5nGNhupsJzBtSAfapYQGm4A3SFkTsvjOxLFKok /sYGA8gG4USlEXfuvRqXCD3wbWqfiYE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=KS2MlNlX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of airlied@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=airlied@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687245226; a=rsa-sha256; cv=none; b=eyTLSWDtc0sQ5j9lxQHzgNUgDdludZ6QAnAjqsn58vjmd14VWFRQxNW1GyRMpvaNkI8OM0 ViICACFAdD2TnxWZEUS0OG70LwuRQKiD30DruHbdCu7kaz1ItePERK3iIRpTTHFXxZtlMs SK1xdmMOq65SLU/NMEVisC8yvbG0RBE= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-9786fc23505so526870666b.2 for ; Tue, 20 Jun 2023 00:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687245224; x=1689837224; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cHYZLznLEupvmNgdz85Wsrh9nTfIdkBiscUX255Az7M=; b=KS2MlNlXd3y1nTza3BQfUQefl0hUFRyaHJjF0aNqen8fNC0xrWWq2Wqj4BXSO/TymI 7ZYHqb9Q0z2YI2jLz3j5V3n5Ti55PCYI2DNo0FHlYiLkbjgBrKE94yVJbYGGRKO2JNie swEfgr00n17CznG0qqtGxiT9LXeKUpAqB8fL9K0Wiz5Fv4c9DZuG7zH27UlHU+IpIXwj /74r3NxBxFV57roZ9AojpB2d+cobw2MJdSENRHLkn+1RSHeZreF8MTrO09njiqaaSNXW jaqzeslntv7BXyd++oVljfTIIA2Inss/uW3+u+Ol8tO7biaME1caakBq2wFMkXEmVjx/ SE8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687245224; x=1689837224; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cHYZLznLEupvmNgdz85Wsrh9nTfIdkBiscUX255Az7M=; b=WFEn5VsWCHNouOweZ49oago1OrqT7wHMEJTl2xdrb5qZVOh03xENMUfrXPDwaCFuO1 o5jRZycodE9Q+FchIfq3FVMzfM6S+cTCKKuZ9MaYgnPHw9VgP0e8UGbcdgIwp1SjsMig u+Dt0OH9HIaoaEAw+jycX1g/E+5V+VdCc7vXsrToKesNOXeMHne71DVJn2Y2Sn6kmcJx fHPzeNe/MXCuLmHuUHWHuUXGPTvMr383UYcczmUb9NYkqe7g5ayjMXPkV3PRII/nXrrx wt3JuQoAeiewJYs4cMC/nxtDXj+o+fE8JLZatx0bnC5GqbxnklJsOW5wpN7C07pLVoX6 DShw== X-Gm-Message-State: AC+VfDxubcTxrVTTTBGAAwsopmNHAeQrXcxZfSll6qXndIVzV29BDqFa UA8pAsXXiY//7A50POQR1Pj1cYDac2jnhe/I1XQ= X-Google-Smtp-Source: ACHHUZ6F96J1yKxnlaxPS5FMbR2w71s7opnQjEhCe3UpSiAY5D8Q7lBEBoaoOSJHfUY5/idqlvCgI9wkZMATl0p2xeQ= X-Received: by 2002:a17:907:a412:b0:989:d9d:d911 with SMTP id sg18-20020a170907a41200b009890d9dd911mr1975412ejc.69.1687245224382; Tue, 20 Jun 2023 00:13:44 -0700 (PDT) MIME-Version: 1.0 References: <20230620004217.4700-1-dakr@redhat.com> <2c92bae3-0003-3c53-8ef1-6e12e5413995@redhat.com> In-Reply-To: From: Dave Airlie Date: Tue, 20 Jun 2023 17:13:31 +1000 Message-ID: Subject: Re: [PATCH drm-next v5 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI To: Oded Gabbay Cc: Danilo Krummrich , Donald Robson , daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3998C100007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: cjr3dwd39j9niyfqdhiyxcgqttkpgjz6 X-HE-Tag: 1687245225-277802 X-HE-Meta: U2FsdGVkX18vZIYZHdMHe5SRnMMOyrLL7THOWrVfaFipMDnHQp73QRZfBr8rp1aHNKjltU2XdWOWMMZrIBsSWvmPjfFqouSiX70CjD4pN5zxf/Smk+sp49ewxQcb5QyjHt6/XEIZpdhzUKVuC2NUhpuZjI4KeEZ76hZ/CxO4aXuuSiFRQNwiFmJ7A5qq62vS7mtvBYsmaMm2NzTPDbPQT+T+2zEMcF45jMBU/t4g6By8uBU3DIzxHfTd1drfkJ2AXaYNw6v3g6gWQJLeOOT3hko7umHG1YLsMxfdXyt5mwnRQa2ABsjBYkLlOxXk/EqoF+0Ms97KD5CW1oYcbP1wOIAnBZLFUnvOTJh/R9+h3hJ5K6JHszG/6db46smrShqa9ImzHip/k+/Fh/rZOF6Vy9h0qZOuL+c+ANHGNrfLYcGToJzsKTdIhFzLv8sHWlszAKLuL4VSb/+tDJ9oedM1dMUKU1CVQHm2lOVRfkPh/yJq/dc3nmIdsu/7ckkfSAHQ9OsP0RNHZu2pyWI7eXGHCzbOgEhs9SEiqC6YsveYbrlS1RKddVZ8TgltvPrCIKJtllOKIdYC3mGuYZ2lYOW7yuMiIrlRhtTVcW3Aw6dO/aU/xU+doQ/V0BFJbFUpO8tnysSuo1Vcxh1AEC2JcnKx9uV6kWWiqHm8hoCXWSuSdNlKQmEBB2649y4oaxm62yZ8Mo/tM+VKU4YeW09DO8bM1lesLhAriIKVdAXANxa39gmPwW0kNd0gS30MI8KOa1syIvpaVGdwckLwcyTiAtYW+GHVizZEOL7SSBJWRWTDxRs3F8cKX6RQHXD1ynoT9PKXquYzHX3uYbAXPkU1eZXs1iHtSWLms5oKlGXdnXuyjK6MVtmmWZAQa5/C8paJyfA0RV5kztguecoclBnOsTGVUBwrdNiKNx25QA1hBeYx376c96nh3wzHtSXeSHO2adlJW9ViLw+hP9K27wVzEiV /peHR7G3 2rbF8OfuUmuFS4BVSSS2KW1La4IN/IlYxcJfRtd1lwv+nbN5sX+M+vbCK2uiNSDOICA8CXHeLUnJotamTR60/MywaNUTMLlV/3jZd98JGu1FG6uXFypUq2IWazc2IeQPzqEPJfeTh1yekX5XhTyUeW0stGVYVSpt3FB4sfDuvufSx/6vD+8R/+cbqOd8qCcPXKk7QA/jIeHBU1D2B2xukDM25HEvwBmumAiHaHpSqIFwr7Ubq7yILZp/+ZYDwe5f+H/dkuhKGHOtCsGjrCi2+RFJI4xxi8R+Mep56AdLQyGUCdHrgvKDziHC6mkLxMZ68IN2DHCveFytlMZQDojPlElyJpzQxq4eWmPbMlyByFn5paHG6pLpQznDJH8EsZYCj6kToZUSmCwP1SaksJLvNh2U2tvFZTXaKWH5m0vbtgxr969SK6zZZXVXXre8YKN2jY1spjjfbpnLtbVhy4Om1Png65GEVVZg9T6l9bYWpx6MwVos= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 20 Jun 2023 at 17:06, Oded Gabbay wrote: > > On Tue, Jun 20, 2023 at 7:05=E2=80=AFAM Dave Airlie w= rote: > > > > Since this is feature is nouveau only currently and doesn't disturb > > the current nouveau code paths, I'd like to try and get this work in > > tree so other drivers can work from it. > > > > If there are any major objections to this, I'm happy to pull it back > > out again, but I'd like to get some acks/rb in the next couple of days > > in order to land some of it. > > > > Dave. > > > > > > > > > > forgot to add your email address to the patch series - sorry about th= at. > > > > > > This series (v5) contains the Documentation changes you requested. > > > > > > - Danilo > > > > > > On 6/20/23 02:42, Danilo Krummrich wrote: > > > > This patch series provides a new UAPI for the Nouveau driver in ord= er to > > > > support Vulkan features, such as sparse bindings and sparse residen= cy. > > > > > > > > Furthermore, with the DRM GPUVA manager it provides a new DRM core = feature to > > > > keep track of GPU virtual address (VA) mappings in a more generic w= ay. > > > > > > > > The DRM GPUVA manager is indented to help drivers implement userspa= ce-manageable > > > > GPU VA spaces in reference to the Vulkan API. In order to achieve t= his goal it > > > > serves the following purposes in this context. > > > > > > > > 1) Provide infrastructure to track GPU VA allocations and mapp= ings, > > > > making use of the maple_tree. > > > > > > > > 2) Generically connect GPU VA mappings to their backing buffer= s, in > > > > particular DRM GEM objects. > Will this manager be able to connect GPU VA mappings to host memory > allocations (aka user pointers) ? > > I only skimmed over the uapi definitions, but from that quick glance I > saw you can only pass a (gem) handle to the vm bind uapi. > > I think it is an important feature because you don't want to have two > GPU VA managers running in your driver (if that's even possible). > Maybe we should at least try to make sure the uapi is/will be > compatible with such an extension. > I think that would have to be a new uAPI entry point anyways, since managing user ptrs is extra, but the uAPI is nouveau specific and nouveau has no hostptr support as of now. The gpuva manager is kernel internal, I think adding host ptr tracking is useful, but I don't think it's a blocker right now. One of the reasons I'd like to get this in the tree is to add things like that instead of overloading this initial patchset with feature creep. Dave.