From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7757AC25B79 for ; Thu, 23 May 2024 03:13:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4BBE6B008A; Wed, 22 May 2024 23:13:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFC296B008C; Wed, 22 May 2024 23:13:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEA616B0096; Wed, 22 May 2024 23:13:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A10736B008A for ; Wed, 22 May 2024 23:13:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 452FA801C3 for ; Thu, 23 May 2024 03:13:28 +0000 (UTC) X-FDA: 82148190096.15.B976AA1 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf09.hostedemail.com (Postfix) with ESMTP id 68B8B140010 for ; Thu, 23 May 2024 03:13:25 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BWmb7+bq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of airlied@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=airlied@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716434005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A/Gtf76HOcyJDIMcic6r4R7wehZnNe29DHssJ4jbfEk=; b=Rjdu2c3wuabwzOeH9DDa4DNIbJtxlbGsNOy/DxJrDR5L7bqu/K/aO+cv/1+I9FnJ0QuC5W aOG+aO0yJd/61W5CiJ8oJkxydI+pbqXr2wGVNaxRSSToMwRQQdnIZDrjvx2K+RnvazLwTf 3CXpHFSnbK3Ow4NYUDameo5cDyF6Qoo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BWmb7+bq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of airlied@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=airlied@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716434005; a=rsa-sha256; cv=none; b=FmiGpLr/plxRTps8OThD+XJD3OLX5eP/lOZHZ4xIxakoIDAYkXTMxeznNvmNLvMryGgcEW twGD7rCF9jxubZb3RIgMeuByYpfHzRLnRX2dAAeCoAKyHNdf75lghemqU6CgpjKaXjEoVP Vg+v99AjXET7SEHt0LYC+HxVqYXi3Xc= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2e1fa1f1d9bso98785181fa.0 for ; Wed, 22 May 2024 20:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716434004; x=1717038804; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=A/Gtf76HOcyJDIMcic6r4R7wehZnNe29DHssJ4jbfEk=; b=BWmb7+bqoknzGu6OtHtn5RPA3LdsynixlzP2DBN8+axWDlIljg288qi/qs9KnLPMwL Lzv42kOYDtNM7/vWuNvU4fN91QWXAMcR1SPVqUqsDnO5QVPLL9lEN3CbpJj1wPYSYhTW Jwu8r9h5P9C8+806M9BzBttCNCOEC0o+BzouOVEG+AyXeYulQ1Da/GjRpO4bkzBOF0na t3odN5gAYE9M706PhlF7eKsOlq0aZXBcyHK6aps31EFpLbZN2DX/c0zoB3qZ4GqGZLWK IeinrDQKINVFTKcGAq326nY0vTKLcyAH5SUcU3oBaReJWPRtaGL2vjPVZEypEg23xQQ+ +XOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716434004; x=1717038804; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A/Gtf76HOcyJDIMcic6r4R7wehZnNe29DHssJ4jbfEk=; b=EUlBkKLGVpMUhbwoXnzP6DhiLAZVosssHx3zfndD2C6eZZArr5SqRuLJJ6cKwUD2YG gruukYQehPwmvZR0zKXXNszhVmQ4pQaEljlwXI8iNOuMaA/olsNNAMxFv9HOIo9+p8Og 8u0jqvUZUAvK7+ROfu0Ul0gNMa3aNTuCqZ1LCgIJK5mpDC5nGRZlmzNVei18NXtPtYoB wI79+NYh2M6esVJihVaA1jQU8i3p2vyO7Z5uCDMZH2MFIW1wArFBA4vlrn1xCuyxThFz zMuwbD1NKSZ0a0obp3ZvjZxA9j43Ghv85rJjaSmTolgViCaZ65ePFoNr9+OlqhMejdEv UEIg== X-Forwarded-Encrypted: i=1; AJvYcCUJR6nXS6U9w7KMa/OESPI2Ev+yyaNiFqJFDD9yFkOF34AzvoB9W90uC+vF1kK1Ho/gsmoBkS5RG/PTn5TqN8y68Os= X-Gm-Message-State: AOJu0Yz0spP9rkgmpTD7mkcl3mVnLQr4U4HJZn7DBWgjn3neYPLTC12h Lf5P62WWS3SMc1mh+l90oeOyqzjjYBh3WS9JoVc169ItlR0Lu5fn4t4JfQF6lhHliNlcHa4jvlA oj9+gRbkPv1H59qXqCEEYcC6VHbg= X-Google-Smtp-Source: AGHT+IFAc3VYRAKI6ria71uUXIPWHgcd1C/YOtDb3dAt0oa75qD3sunTygcqHGKXSPHRJxZv9qjo1NPBW3BW8vbUy8Y= X-Received: by 2002:a2e:8055:0:b0:2e7:2c84:4f65 with SMTP id 38308e7fff4ca-2e9492beddbmr27130041fa.0.1716434003519; Wed, 22 May 2024 20:13:23 -0700 (PDT) MIME-Version: 1.0 References: <20240411070157.3318425-1-vivek.kasireddy@intel.com> In-Reply-To: <20240411070157.3318425-1-vivek.kasireddy@intel.com> From: Dave Airlie Date: Thu, 23 May 2024 13:13:11 +1000 Message-ID: Subject: Re: [PATCH v14 0/8] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios To: Vivek Kasireddy , Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Daniel Vetter , Hugh Dickins , Peter Xu , Jason Gunthorpe , Dongwon Kim , Junxiao Chang Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 68B8B140010 X-Stat-Signature: 5o8yncwscuugzfy66fy34qsjo4qy1nkk X-HE-Tag: 1716434005-105182 X-HE-Meta: U2FsdGVkX1/UfeMADDoBGQFxlPoj1HSv7/Dl8O018RWE0XPnw6GC7Rj2JZ7d0q/AVEN3uxV2g9L6+cslnRNalu2xAFeW0IyyFaGVIvb7GJTtr/j3rxmWDBbOp7m1omzZM1aHRG4rAajh3RtDsRylBYJxXkWTuWVZyswmgFVKYCDbAijryGl9RaXEuXLLr4pZSThgcz+8bcvhl3+tBDBBTwlulsLEPzuhu5aIIoyCXlXE9mo2prHSV3hNFDq3b+cLAMtSeiL/HbQLTwDW23ZcQfGURZ6/t6qEjTN0tZwTll3q2bPxMEgVbUHg6v8qeNPu3JPZRw1B7aYwtoLoMHhSvwFiNlaBzBbnSHr+Kqg8UrnjJ3+73bU9aL9JVtbn1cnH52wcaDO+WoePKOvifK0cmcyHZqSyj8uhvO3/rV/QvfjRss3/c6uepCVNt9RWwyYQhPyCKFnxLk+fhNWo9nFXt5pZY4XT1Fj5Ijsp4EhrstjpuqBBvFByDu4nk4zHNWRCNASESwnZDD7DNKdJUj1B+Qwqq6rZR7FGyJsYga1ewNbehhF1Iv1f750jxD60L7i+hb04rh4XNDYAgBwTdivhai7Emr6vR9JrGFsqFnzMS9dxDupBDlLX1Y8GmcILguFVIvH9vlY5YY+7WrNzWgQa3doe4pbte0aRK90go3F8XOM1e8enwIZn3SpYi1dgQ2UiZ81ZONSHoE1V8QPkK7suvjiYWclnJh5Uf/FlXKpbm39k8y6k1qb6Zw05wfe4N/DszOkrVDGFa7bZMn63joF2ouK/uC46xjOACVNPgjnCYnk9MRKx9so3A3m1iV/XEVvittbqycN7clea3C5bsFxl8Y0qK12DbGG/kDrCjfKQ8aI+PGJDryi+5itkdsuPryv/K4bRNOvKwCFNW7P40Ev9WuhtmYbFmJTq60Oe2UTgsHEq1DMLBLb59K7Nb4VP1nl5UTbFAa90Cf15d+Zmmpj AkSqA9R1 +rKHq0uRYMayHHLNpkb3gjc4qGa2uJ4x/MiYDIE56t5zFur+fbauU5qmJtvro58n748nPlrEthFukFdQ74UDmDfVlLHsL7bIG4oTKWnpv3SVXiwQWuqridkeFacac1kDf8cfhBnnSo9LZ+0ZE3rBD1DGZ843EOs9123E3nXUN33SPk5y+U91m6JWfcB0vTLdaLaNXSwJaXJ6gc+RhwvxoMoDBMyjq7qCmlH5nknIcoqdv8B3f89OsBp1sYYlEQ6ZU01UehAA0Bt4ssAuHyqBZiqxTi6/lKwKMWyI7zgLEwrqASvXUrQ4pE31UqabeLdEFW0bqUkBBphMeXQoAAYiX065iqaAArZmIvJgiFRlxDLDlc6kg2RDrnPnV7ZIv6wWl1g4MWneJBU9iui507uIMWW6R5mhO1pjEIhEI6Fz6c8Yd/8U+WURtWLUqg2q8IbW33YGUBUFAoxcJficR5Rwp1I+WFyjTHEmYGUlYX+sjtVRmMcofenYIEBj2/nZVmocazgX9ryEvtMx5PBhcDsaZGO4Tr+cxpWbEgUFdIg1VzJDHRuDr8NoVVfO1/w6N1xCUF5Pf+MGy+3VPuvYRmQMQLho27hWJhJDrhgpH5PIAa8uQmZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Gerd, do you have any time to look at this series again, I think at v14 we should probably consider landing it. I'm happy to give Acked-by: Dave Airlie for landing this via mm if it makes the most sense. One comment in passing, was I wonder if it makes sense for things like vm_map_ram to have a folio variant in the future, to avoid that pages temporary allocation. Dave. > Cc: David Hildenbrand > Cc: Matthew Wilcox (Oracle) > Cc: Christoph Hellwig > Cc: Andrew Morton > Cc: Daniel Vetter > Cc: Hugh Dickins > Cc: Peter Xu > Cc: Jason Gunthorpe > Cc: Gerd Hoffmann > Cc: Dongwon Kim > Cc: Junxiao Chang > > Vivek Kasireddy (8): > mm/gup: Introduce unpin_folio/unpin_folios helpers > mm/gup: Introduce check_and_migrate_movable_folios() > mm/gup: Introduce memfd_pin_folios() for pinning memfd folios > udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap > udmabuf: Add back support for mapping hugetlb pages > udmabuf: Convert udmabuf driver to use folios > udmabuf: Pin the pages using memfd_pin_folios() API > selftests/udmabuf: Add tests to verify data after page migration > > drivers/dma-buf/udmabuf.c | 231 +++++++++---- > include/linux/memfd.h | 5 + > include/linux/mm.h | 5 + > mm/gup.c | 307 +++++++++++++++--- > mm/memfd.c | 35 ++ > .../selftests/drivers/dma-buf/udmabuf.c | 214 ++++++++++-- > 6 files changed, 659 insertions(+), 138 deletions(-) > > -- > 2.43.0 >