From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Andrey Ryabinin <a.ryabinin@samsung.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH mmotm] x86_64: __asan_load2 can be static
Date: Wed, 4 Feb 2015 22:24:12 +0400 [thread overview]
Message-ID: <CAPAsAGyK8RD3i0n5bZ=KzxWpkNv2k2s5gzcTEWXy+LkREBXdfQ@mail.gmail.com> (raw)
In-Reply-To: <20150204150942.GA100965@lkp-sb04>
2015-02-04 18:09 GMT+03:00 kbuild test robot <fengguang.wu@intel.com>:
> mm/kasan/kasan.c:276:1: sparse: symbol '__asan_load2' was not declared. Should it be static?
> mm/kasan/kasan.c:277:1: sparse: symbol '__asan_load4' was not declared. Should it be static?
> mm/kasan/kasan.c:278:1: sparse: symbol '__asan_load8' was not declared. Should it be static?
> mm/kasan/kasan.c:279:1: sparse: symbol '__asan_load16' was not declared. Should it be static?
> mm/kasan/report.c:188:1: sparse: symbol '__asan_report_load1_noabort' was not declared. Should it be static?
> mm/kasan/report.c:189:1: sparse: symbol '__asan_report_load2_noabort' was not declared. Should it be static?
> mm/kasan/report.c:190:1: sparse: symbol '__asan_report_load4_noabort' was not declared. Should it be static?
> mm/kasan/report.c:191:1: sparse: symbol '__asan_report_load8_noabort' was not declared. Should it be static?
> mm/kasan/report.c:192:1: sparse: symbol '__asan_report_load16_noabort' was not declared. Should it be static?
> mm/kasan/report.c:193:1: sparse: symbol '__asan_report_store1_noabort' was not declared. Should it be static?
> mm/kasan/report.c:194:1: sparse: symbol '__asan_report_store2_noabort' was not declared. Should it be static?
> mm/kasan/report.c:195:1: sparse: symbol '__asan_report_store4_noabort' was not declared. Should it be static?
> mm/kasan/report.c:196:1: sparse: symbol '__asan_report_store8_noabort' was not declared. Should it be static?
> mm/kasan/report.c:197:1: sparse: symbol '__asan_report_store16_noabort' was not declared. Should it be static?
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> kasan.c | 8 ++++----
> report.c | 20 ++++++++++----------
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
Nak. These symbols shouldn't be static.
All these function invoked only by compiler, so we don't need declarations.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-02-04 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 15:09 [mmotm:master 394/551] drivers/isdn/hardware/eicon/platform.h:333:18: warning: array subscript is above array bounds kbuild test robot
2015-02-04 15:09 ` [PATCH mmotm] x86_64: __asan_load2 can be static kbuild test robot
2015-02-04 18:24 ` Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPAsAGyK8RD3i0n5bZ=KzxWpkNv2k2s5gzcTEWXy+LkREBXdfQ@mail.gmail.com' \
--to=ryabinin.a.a@gmail.com \
--cc=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox