From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] mm: vmalloc: don't remove inexistent guard hole in remove_vm_area()
Date: Thu, 12 Nov 2015 21:48:38 +0300 [thread overview]
Message-ID: <CAPAsAGwExjJzBvDo-LSF1u8wJMCa-0BALxKZ2Se_cxUs8r+29g@mail.gmail.com> (raw)
In-Reply-To: <1447346238-29153-1-git-send-email-jmarchan@redhat.com>
2015-11-12 19:37 GMT+03:00 Jerome Marchand <jmarchan@redhat.com>:
> Commit 71394fe50146 ("mm: vmalloc: add flag preventing guard hole
> allocation") missed a spot. Currently remove_vm_area() decreases
> vm->size to "remove" the guard hole page, even when it isn't present.
> All but one users just free the vm_struct rigth away and never access
> vm->size anyway.
> Don't touch the size in remove_vm_area() and have __vunmap() use the
> proper get_vm_area_size() helper.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-12 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:17 [PATCH] " Jerome Marchand
2015-11-12 15:55 ` Andrey Ryabinin
2015-11-12 16:28 ` Jerome Marchand
2015-11-12 16:37 ` [PATCH V2] " Jerome Marchand
2015-11-12 18:48 ` Andrey Ryabinin [this message]
2015-11-12 20:55 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPAsAGwExjJzBvDo-LSF1u8wJMCa-0BALxKZ2Se_cxUs8r+29g@mail.gmail.com \
--to=ryabinin.a.a@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox