linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kyle Huey <me@kylehuey.com>
To: Jeff Xu <jeffxu@chromium.org>
Cc: "Dave Hansen" <dave.hansen@intel.com>,
	linux-mm@kvack.org, "Stephen Röttger" <sroettger@chromium.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"Jorge Lucangeli Obes" <jorgelo@chromium.org>,
	"Kees Cook" <keescook@chromium.org>
Subject: Re: x86/pkeys in early kernel version
Date: Thu, 26 Jan 2023 21:55:11 -0800	[thread overview]
Message-ID: <CAP045Ap-SP+O-51Sn5g-tZRWNEPjjXeJba5boPKRgkR2r_hS1g@mail.gmail.com> (raw)
In-Reply-To: <CABi2SkU=FX+kOr0sGzLU8YkHmYaAANWVvnoKQ0Z0Wj_CA8Uq5g@mail.gmail.com>

On Thu, Jan 26, 2023 at 9:36 PM Jeff Xu <jeffxu@chromium.org> wrote:
>
> On Wed, Jan 25, 2023 at 5:43 PM Jeff Xu <jeffxu@chromium.org> wrote:
> >
> > On Wed, Jan 25, 2023 at 11:13 AM Dave Hansen <dave.hansen@intel.com> wrote:
> > >
> > > On 1/25/23 11:02, Jeff Xu wrote:
> > > > I'm investigating if there is a need to backport x86/pkeys
> > > > fix/feature into earlier kernel versions, Chrome is starting to use
> > > > PKEY in x86, and I hope experts here can give advice on this.
> > > >
> > > > For background, ChromeOS regularly syncs with upstream kernel
> > > > versions, and has production that uses 4.4/4.14/4.19/5.4/5.10/5.15.
> > > To be honest, I haven't got the foggiest idea what you need to backport.
> > >  I can barely keep track of mainline.
> > >
> > > Are there really production 4.4 kernels that you need to run on
> > > pkey-capable hardware?  That would mean running a 2015-era kernel on a
> > > CPU released in late 2020.  I think Q3'2020 is when the 11th gen CPUs
> > > came out which were the first non-server CPUs that had pkeys.
> > >
> > Thanks!
> > For 11th gen CPUs, chromebook uses 5.4 and above, so that eliminate
> > half of the versions.
> >
> > > On a positive note, the pkeys selftest has been pretty consistently
> > > updated as we find bugs.  I'd be curious how well a mainline version of
> > > that selftests runs on old kernels.  But, I'm too scared to find out
> > > what's down that particular rabbit hole myself.
> >
> I took the latest selftest from main and run on 5.15 kernel,
> all passed except test_ptrace_modifies_pkru
> assert() at protection_keys.c::1623 test_nr: 20 iteration: 1
>
> Is there a bugfix for the ptrace area ?
> Thanks


What 5.15 series kernel did you run it on? The patches for that didn't
get backported until 5.15.88

- Kyle

>
>
> > I can start with 5.10 or 5.15, it seems there are quite some changes though,
> > for example,  this one by Thomas
> > https://lore.kernel.org/lkml/20210623120127.327154589@linutronix.de/
> >
> > My question is, if I have to pick a version that doesn't require a lot
> > of backporting,
> > and functionality is stable enough, what version would this be ? 5.4/5.10/5.15 ?
> >
> > -Jeff


  reply	other threads:[~2023-01-27  5:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 19:02 Jeff Xu
2023-01-25 19:12 ` Dave Hansen
2023-01-26  1:43   ` Jeff Xu
2023-01-27  5:36     ` Jeff Xu
2023-01-27  5:55       ` Kyle Huey [this message]
2023-01-27 19:08         ` Jeff Xu
2023-01-27 19:22           ` Kyle Huey
2023-01-27 19:30             ` Kyle Huey
2023-01-27 21:12               ` Jeff Xu
2023-03-13 23:24                 ` Jeff Xu
2023-03-14  0:24                   ` Dave Hansen
2023-01-27 15:22     ` Dave Hansen
2023-01-27 17:58       ` Jeff Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP045Ap-SP+O-51Sn5g-tZRWNEPjjXeJba5boPKRgkR2r_hS1g@mail.gmail.com \
    --to=me@kylehuey.com \
    --cc=dave.hansen@intel.com \
    --cc=jeffxu@chromium.org \
    --cc=jorgelo@chromium.org \
    --cc=keescook@chromium.org \
    --cc=linux-mm@kvack.org \
    --cc=sroettger@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox