From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ECEC48260 for ; Sat, 10 Feb 2024 06:50:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3428E6B0080; Sat, 10 Feb 2024 01:50:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F27D6B0081; Sat, 10 Feb 2024 01:50:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E1C86B0082; Sat, 10 Feb 2024 01:50:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0B9026B0080 for ; Sat, 10 Feb 2024 01:50:37 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C6DAB80845 for ; Sat, 10 Feb 2024 06:50:36 +0000 (UTC) X-FDA: 81774970872.04.8527FCA Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf10.hostedemail.com (Postfix) with ESMTP id 0132EC0019 for ; Sat, 10 Feb 2024 06:50:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kXLbvOGJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of memxor@gmail.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=memxor@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707547835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kofXlfSw5eG7uFS5fzcRJor8xoj2JsyQJRb5Nt+X1gc=; b=QYgPHFA4y1Y1bMjTQsRgctbJwJCioq8vM0EFJB0qlIHLvQv49g4UcYVdyShdEG8nE29GCh 1dp4L1+UneL6NgZQtc1P/8r7ynuYcw3pUfUPwS+gg8sN7fGUpWdDPJT5gQOxIzpjP0DY6y aerhVrzycU9C+47pWsMp7oED0V56UEA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kXLbvOGJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of memxor@gmail.com designates 209.85.218.65 as permitted sender) smtp.mailfrom=memxor@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707547835; a=rsa-sha256; cv=none; b=Xh3ZkslMkeMbbpmH7Je3gzcdJ6Y80XTvmxIACI8wq3gipvBGGJP4FrxExKVqGNJvPYwr3J WATFtcQTmkW05hraX1YJyxZJRp9QhKn0xZv3M6+au7+a4FO31KzV6gLvCcudWGAjkItGYc vQ8Ckssrxa+jrIm1B1wHN4jFIzCnQEk= Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-a389ea940f1so174312766b.3 for ; Fri, 09 Feb 2024 22:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707547833; x=1708152633; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kofXlfSw5eG7uFS5fzcRJor8xoj2JsyQJRb5Nt+X1gc=; b=kXLbvOGJjyxhBwVTs9TAH790SUziIY+2ZMs8aiLxSi8sibuGtX6M5VspBrtLo1GvF8 omO3fdP4mDDi6eOtu/DoGid/wxy1lNkv62owdFRGd+V4PsWI60jyL2odjkx0nDOBinq4 TR4Z9bdX7P9hyppcZQxzHDzxNBciJM7T9hgiOpdBZUy198+zvLv6lWeQS95W2NzlKkbI mYulqAHof+bwM8TgZPQQ6yFT4H/uYsc1ok2xrFC0DWzuuikxO4ScPLA4k7SeCDFrOTEr qZeGSW6hwkBv4/PO8zY/CrLJlqIhqxM9NR+H8EXj3hhIjwPzAiABFega+9fHFZfzfIAm plKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707547833; x=1708152633; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kofXlfSw5eG7uFS5fzcRJor8xoj2JsyQJRb5Nt+X1gc=; b=hXZRu59+6WZj6eeTuUp5RDxmrPE4uJ+PgNR7JD3m5OOyEDiseNJ3BvYjHVmb3C3UoP cYqV9O5G3vXFFf2GdikrH2q24+OxpxfPT8shPvX1DgD1fjGB4YjLjVK9wCIEQw+rQd8B 7NHqa1B4LFtyhSNPDLlyPSOR6lhVAwkWqdAKnE5G+lGkOypnpAz3yGdUBvjIEVg51a6A cspxZQhAiRNS0wtq7cXYxhMHQF2pF/QjcnGPCjOx9rEavUbJXei/W6HE3SXlewhhfrVJ srAmbtBhWdLq1ZdOgAe9BmY4GYeqjIeL5H2cBg1WG/NzveTyJ2D/ncjvscEhaB+jI1k5 saCA== X-Forwarded-Encrypted: i=1; AJvYcCVzzWoZhnQQqHWJTEdWlKRQuuG1w2SGkg45Vx8VNyTbB1j7BPCDPAkBlferbgDMR65FZCpIE9Ovj9WBgRTFD/l8fb4= X-Gm-Message-State: AOJu0Yx8fU2/pEjfwbM4Uj4dEQ/PfZdgKcxia/aUt4Uf8tF1Y+W3HwT2 HCDWvpdv8D9jwUXqyEZX+ba+UB8kHySYZ+mZ6Tu2Ci4CmNHa41oQJeb4mM5y2Sk8Ky8Eni+O33m APR5PeVwy2naMtSs1fhLkYyU88IY= X-Google-Smtp-Source: AGHT+IFZgv9srpEBT2S7q2JO6RMJz8FGaKrZrkZ33WTwTTcbuhNUwu9Nv5gvlp+EIa1Fxms2quSzm51R1MlQt+/yMKY= X-Received: by 2002:a17:906:1b16:b0:a38:80a3:6692 with SMTP id o22-20020a1709061b1600b00a3880a36692mr724469ejg.30.1707547833413; Fri, 09 Feb 2024 22:50:33 -0800 (PST) MIME-Version: 1.0 References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-2-alexei.starovoitov@gmail.com> In-Reply-To: <20240209040608.98927-2-alexei.starovoitov@gmail.com> From: Kumar Kartikeya Dwivedi Date: Sat, 10 Feb 2024 07:49:57 +0100 Message-ID: Subject: Re: [PATCH v2 bpf-next 01/20] bpf: Allow kfuncs return 'void *' To: Alexei Starovoitov Cc: bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0132EC0019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rfd1ek9cojhgr993u7aggown5zci9dmc X-HE-Tag: 1707547834-206513 X-HE-Meta: U2FsdGVkX196OFiU28B3TsSmxCAEhLhCVwQMACnVnlvet7cs8QbagZp8xuAeo1smTOCVIvjsMFUbbEDXnMX39rsNGW3N/2zKBxSmdmqBq9Ksh9ORYYqB0M6FXZpbFRqneZ5bNNR8HAGzf1LmCKTUK5bf7WKYXwnD5LDVFeNAe8Gxkbinf/JAYxNVOA+2mrWqZuaTT+hzC5bvQpKIK/uJHUUfM20j2kLCAug3u+WkX3orfq1yJtpLQuWgPpP9BMjFDGZA0X0L6e9AoCRF+bsMLUEhSrAEBYzBlBRy2TaWu6MurMSebZGxt0JgxMX3gctkjQkz5/I49c+Z/7SjCGxQPVpahU0gODjXNCo30j75XDq7A4uiMBWHaIv6zlCCQtqc5YKPn4b5Cc6b0KLj+9Iez5BbSEbIkazjaCxPdlfAZbTYuEvrtIsmw5/B/SJkJoXVgoRNWbyy84WZ+M3kzjkNTkWZCmjuFqCe/6OJA9zkOR36i9OuzvDlq4w5T1lyqnhmdLPN5RgQ18PLZe9kmufRacSUJ0VcZqE8rxzl65dmgmqgartB4S5oPXRzVMgvyIDUrViepobDydz1T5PX2+rp3GJBp0hC4m9AqYj7Ex+xDwJ6x92yvPYoY//6lwGbNnRUgHF/cXhrOe7Pn3lZ248VmfSCgyuhEZg+U2xOj1yTGmeEi+JoT5Snuhn7ayfxedI8AQrYHgyDEmT+vFIWCCANrX7BD+nZiyygbA3d//2CGe+TuDeqcArGbwpAQmoMPIqsofwlw66qZbd5fTFrxjzbb2tlr0oUjK7w0BHx4zQ6W3sjfmo0IxCNc6Rf4lN7gSJ0QBFtXmrPQTRr1TRgxWsf3W+vZKvUpn5zyfTFYzHnzaVpgEuo6WvEp8gf6Ei4JKWFyE7XQyGmpjpHd5QkzHvowcssdm/aoZS/4dxw0292cG3eIq3NUzBYFuwibd3SOPz8136odNJ0Ts4Mx2dsfzD kxzI+CZ6 c83UStCEm5YLgTB4WGXIpdpQJtpbxNucG27Dyu2GX+Vyz/2+BlnaSrE1U75RLqWUREzbcgbLlKAddXeftXkOYvpDJTOlhBTgbojdT7bQgEI4yCZnPen8/GfAWeQvQ82X/ngryvZ0Ph26nVGHYIFtrkNyb4oefMDUe+zwB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Feb 2024 at 05:06, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > Recognize return of 'void *' from kfunc as returning unknown scalar. > > Acked-by: Andrii Nakryiko > Signed-off-by: Alexei Starovoitov > --- Acked-by: Kumar Kartikeya Dwivedi > kernel/bpf/verifier.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index ddaf09db1175..d9c2dbb3939f 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -12353,6 +12353,9 @@ static int check_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn, > meta.func_name); > return -EFAULT; > } > + } else if (btf_type_is_void(ptr_type)) { > + /* kfunc returning 'void *' is equivalent to returning scalar */ > + mark_reg_unknown(env, regs, BPF_REG_0); > } else if (!__btf_type_is_struct(ptr_type)) { > if (!meta.r0_size) { > __u32 sz; > -- > 2.34.1 >