From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F352BC6FD1F for ; Thu, 16 Mar 2023 17:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52599900004; Thu, 16 Mar 2023 13:50:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D523900002; Thu, 16 Mar 2023 13:50:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39D9F900004; Thu, 16 Mar 2023 13:50:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2B0FF900002 for ; Thu, 16 Mar 2023 13:50:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 08756A1440 for ; Thu, 16 Mar 2023 17:50:34 +0000 (UTC) X-FDA: 80575501188.19.B316747 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 4D23CA0015 for ; Thu, 16 Mar 2023 17:50:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=asLa2HDF; spf=pass (imf25.hostedemail.com: domain of irogers@google.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=irogers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678989032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wVREMZ5kpSW/gc2Ge3hXpJkQknE5nkfYCVcEvxv4EXI=; b=gv7qQjBgmUF6m/8Kb25Xf/gWrYY4mkvWDterCpR4DvjVodvALd/yPvMdTcgL52aEmUIW2i DniM45Qdag6lrxeQZBZkdPqEmW7MCF+lYJ9keDMEdVFSe4mbXSfME2N4elEbo2nJ4bGwL7 RqifJc7kp+RTsyerXAhm43UQrr210T8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=asLa2HDF; spf=pass (imf25.hostedemail.com: domain of irogers@google.com designates 209.85.166.172 as permitted sender) smtp.mailfrom=irogers@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678989032; a=rsa-sha256; cv=none; b=vX/B/oMdB9uxptiIrMX6kThbyDCraEhUCutsMDnQJqj807xosdlELtUEWZLS6Z4sWFlJMK E2JbwnUXwRtJ1+NDrU9LayQ8aCIDSx5LVZubJ7ehItSYCKGKzUnag4MtrsULRIDE/7Fu0B IKq5OQST7L7i2mQoXGGaiyFL9n80zDw= Received: by mail-il1-f172.google.com with SMTP id y12so1435181ilq.4 for ; Thu, 16 Mar 2023 10:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678989031; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wVREMZ5kpSW/gc2Ge3hXpJkQknE5nkfYCVcEvxv4EXI=; b=asLa2HDFhrf4l/5L/rbsFjIMDSD0pGnamZAh61JnlEKslGh4/ioiqBPX5uimZuV0/A l9Uu2x/ecW9+abZ5qSQlxUkjLcxSO4AjWkr2OAV6V20nTK80dRjDAVHq9s4SNcHZaCTh b/EMGCnN6cbq8pBPRyI3yiSwd4l+szi8F2T9/R/zJdHOpp2H+nZM+3rja9gmrjzL09aV 8lzePT6Z0KcwYBoJ83jCr/EoE3t87+M/o+qfIQ5LGn+BHwcypDU2tBHD+I1ut+qd2cmS ccWeNJOdkJgAGQDu7tIrozPi3pqswZfkqeC1NtX9dIp0M+C033XYN3Mw5Raq2rTKVtl0 qSug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678989031; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVREMZ5kpSW/gc2Ge3hXpJkQknE5nkfYCVcEvxv4EXI=; b=XP/BSBynijlt11BryF5UnOwQG4lN1TUS9C0ZtXJRnVG3UttSbnZzpGcycWnwk57z+k e6U8pO6rwcFn1N+PEK/8N7gtffJS198Xk5O8L+edU6KT0cQj3OcC7l+QdwkedI16NLva zfwpMcUkvUMejLWFZhJTwYZTM50LpmifJEJ8kIZLNC6N05qGmE/fDATVQWW1+KsyXJcz ZJMFgiw3y8Kl2HTC4GVxjeHG1x62ZO9oEyFzndhfs37zXoKQMFzYr5I0d0qrusG+3Pv0 3SoUcYtjHuWTVDf3nYGn7pCnz1py/E7ZEcn6S1KjRJMeJEGW7g4i2oLJaZmmcMk1h3xh i1XA== X-Gm-Message-State: AO0yUKU43sBWr15zMMZLt8zjOmkwtQgRob9atWROCSIolFHq5coBXkzr ni7pnvbGxGgQ8SGMAMi9MCe+jdmSdjfpy/B/waGp4g== X-Google-Smtp-Source: AK7set8mXf20D2vvZ13VDFjuQCTRthMKZlP5n2x8/krArMampywj3ASCIlATMoK0zgwEG6o2Ok5YuhGPd3VwvvLLZVk= X-Received: by 2002:a92:c542:0:b0:313:93c8:e71b with SMTP id a2-20020a92c542000000b0031393c8e71bmr243410ilj.15.1678989031152; Thu, 16 Mar 2023 10:50:31 -0700 (PDT) MIME-Version: 1.0 References: <20230316170149.4106586-1-jolsa@kernel.org> In-Reply-To: From: Ian Rogers Date: Thu, 16 Mar 2023 10:50:16 -0700 Message-ID: Subject: Re: [PATCHv3 bpf-next 0/9] mm/bpf/perf: Store build id in file object To: Matthew Wilcox Cc: Jiri Olsa , Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim , Dave Chinner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: w64rcjjghhsrtc8tqjqoxa399ktf44ns X-Rspamd-Queue-Id: 4D23CA0015 X-HE-Tag: 1678989032-410952 X-HE-Meta: U2FsdGVkX19VxPYwGV99D9DMWLJoaRdWDbAk/jF/gbJ2g5OsyoZK/zZ955AM2JusGO01xlNounvPg4A//z6vl5eOWWn3Rqta47GU/HqgzxoZKORCJxsVS1Hbxd7Umq93aA9WjLYNOGpPGygu610rPif7iRIOpRMP/0v9g67YGVIWNo8hRHVq3/3U+0zUGWUwfCcDOvw2NuG9S1Skxm3kj2XztrrOa/0Qfek5i1SK98iZtJXMa2o0SKARm1M84TxC1ovs8TsuegeaHUYtDIwfAKuPRIf2EJCUpns8XNZAwIrLM8KD6LCXEtHggjC2Vrpf4GHgk7mzpKajC4OqnA/KsN77Xor4V+OL57un9f0+6LhaGgxLNcKhKXwmX6/i+jmmVwBVXuVmwlviAHvJI2yM3JrwVLKGRBKl8Dj0M4LsLph3Eci0P6hoJHOeEB9YUPZvsU5dBL/8clAb0J1H5GU7uabkAmU1Fz1ukEk+35kaBk1xY4yvWs4HFwjxmdkTurFkaTpK3SzhJvFTkdPI9/HvIzRVVtSA89zKO8VNTds3+Uu5/p3eyTHUNrC77qW3vU7NiIp9/lrRkLhDqOdgvAwp4xU4UK0Lxyno3PxEgckAIEt/bbrnVlZoWn9jXNEi9XGe4cUj697gNgMzlPNYyPFh+d2IXzQ3LrWcqVaOBJikiIkTWlQTIONkSVgpgVcykal6UwsDZMpKhN2s3QjYgG1/wyLaDSbCIdXB+HWIYC1WVcrsJ9rSQ1l1U+XJH8V2Sg2Jwf9diHp9PlKeO3F9+7PQC2uGfPsuqp+rDUOmhkm4hXbuSbvXvRRLEp1ldEOvj8GrAVN4xWuJeKgWgXjLJPSv7ObSFPUbsM6oo16JbkZgbtHSESC8wrYu3nqSQRFgq0cVyq57/oMHvUYRTrmh5KzmKG6DCzjDcBMEZmkyMsBK3YfjLhorMLjyht71122MVyU5dX/mHouIak/m9B1oCXY QwssVPqA 3mchi9t6CWFm9RFiGTbruPJjY0mKa/D9/gBvsNtmOuPbWAigywm43kFPhuc6G7ze3C7uDzFthJZ8BxzzMI5PIuFZVbeb+w1FBRffyti2/t2N6IL/IZnRfV5UZZomWI4sO7CwSBcbprPAisdlhOVPYbbDwix/jL64Kixb2w8XJN63WSjBDAGdUHSStwqwQXZ9OzwSsc0rXVoX5hZTqHkm8rT9jK6y7OAzPsP7h4gf0WkxozFUyPRAsti1R3iLW+qIfb8ppeBfJEBGV7jhZ2k18/tyVbWxMeGX7W55uvWBs5BlYpR/KKIybXHtfNpML1B1YeRGceNQy2NXITZj+Mz5FzmjYMTuRWWcU5cVJNVy8vBoP/DXMSdkYaJRZFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 16, 2023 at 10:35=E2=80=AFAM Matthew Wilcox wrote: > > On Thu, Mar 16, 2023 at 06:01:40PM +0100, Jiri Olsa wrote: > > hi, > > this patchset adds build id object pointer to struct file object. > > > > We have several use cases for build id to be used in BPF programs > > [2][3]. > > Yes, you have use cases, but you never answered the question I asked: > > Is this going to be enabled by every distro kernel, or is it for special > use-cases where only people doing a very specialised thing who are > willing to build their own kernels will use it? > > Saying "hubble/tetragon" doesn't answer that question. Maybe it does > to you, but I have no idea what that software is. > > Put it another way: how does this make *MY* life better? Literally me. > How will it affect my life? So at Google we use build IDs for all profiling, I believe Meta is the same but obviously I can't speak for them. For BPF program stack traces, using build ID + offset stack traces is preferable to perf's whole system synthesis of mmap events based on data held in /proc/pid/maps. Individual stack traces are larger, but you avoid the ever growing problem of coming up with some initial virtual memory state that will allow you to identify samples. This doesn't answer the question about how this will help you, but I expect over time you will see scalability issues and also want to use tools assuming build IDs are present and cheap to access. Thanks, Ian