From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78555C0015E for ; Wed, 26 Jul 2023 17:27:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B83B8D0001; Wed, 26 Jul 2023 13:27:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 069146B0072; Wed, 26 Jul 2023 13:27:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72748D0001; Wed, 26 Jul 2023 13:27:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D496A6B0071 for ; Wed, 26 Jul 2023 13:27:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8120A80324 for ; Wed, 26 Jul 2023 17:27:02 +0000 (UTC) X-FDA: 81054443484.25.BB71281 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf05.hostedemail.com (Postfix) with ESMTP id BC558100014 for ; Wed, 26 Jul 2023 17:27:00 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Z5nnOHOs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of irogers@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=irogers@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690392420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eh/u/3oGRS27e8zFhRvxdI/qhhrHZL9r58i24C4GPzM=; b=w9j+vlnLJixphc3B58yTWroRVSxsTRPloxlQgwp2Ck2hVDgX4otmb0bSOR+QcHq9ectn5c TBbKekslCy+iDxL/HfZy4mYjbnCvsPlxyTuIv/W2j+lyEJtHBMSWCBKtlDQI0QuWeX9M9v kP2PQ214MM7BfFPRjfwdtE3FSs9MpMQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Z5nnOHOs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of irogers@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=irogers@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690392420; a=rsa-sha256; cv=none; b=ZcOmuqStoOVzy2h1DEaRRacjrfrRPnTcQ660GVYOLPSpVHKAypknfRlr1VEzxdGod32GiL egCoTaF0h+sppyHJ5VD1Xq5bztKMS3JsSLz2j99XP6TfVAVepzXjaw9MeIQaWy4qzlCUxh BnvbRrKyWwUUFYc8vAXjgPc7BsC1djE= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4036bd4fff1so21371cf.0 for ; Wed, 26 Jul 2023 10:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690392419; x=1690997219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eh/u/3oGRS27e8zFhRvxdI/qhhrHZL9r58i24C4GPzM=; b=Z5nnOHOsigSkUjHY9VXlm8uRkVIK+o/C2ciOWGFX5ZreNGtzqo/DStSNwyhEIhOtlQ 1HZzHZ5Z/bI51P/9sr29qxtvtj/V7i2ofdTHxABNFkC9eDM95l42z0FNMm0TGm319XUX 8bUiZ5pTUJOSjIx+EL3W7+eREjzSB+v3AHoeoeHSU8w7nIsb0HUjj5eVzjlzr07yvf4A 3xFcVLyORSM2Y7MmUPJ7UscJYE2y4a9wj3WBOgW8PAgwhhKBZTvGayeQaIqTVoCeQwAx UmxxXi4SVtt1jxPdhne6PV59lg+8y8GnTdCo+UhI8ClHj1C9555IwX7cRS7NSPp9n0NB 3W1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690392419; x=1690997219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eh/u/3oGRS27e8zFhRvxdI/qhhrHZL9r58i24C4GPzM=; b=fSviWzYHsd9t73hB8qw41CsO48QesHJPRVLsQa2Ucr3wyF8sdraU1ATWF5t3S5cuMn wxYmT6949nDfPibfiKGn+JTmmz344RDLc0GMzTt/IDgqtUXecHjx4lG9vhljKGCBW2kA Y3KXwIqcI5lsVnPd531akpycbxECLYL8nIBq5HCIb1pL5eAzmn7GcyLAujskVqNtE5Dn BTJBNI7eIbs0qLICeiQ8s3Hz+LMy86/VrO7pE7BQdh2yxRmCtAV4jHsnDak7WLrnK75g c0Xd5/02+BKLp25351yV875LsINcoq1FGmIDAIdtsH2EexU+FrU0C4whkTLe6XjeQh1J qdXw== X-Gm-Message-State: ABy/qLbks2jOhbR+xN9ek02OupIqgKYvgBJiEib48i8pi2C/ekW/IsOY X9Tov8aXbjKJsiftSAOtcr0pbpnJTC7rStlGw0UfXw== X-Google-Smtp-Source: APBJJlHGWp+bm4jUOLGlkNEl7j1aAqridXdXn43BV8tVe7NcvahvARkO60jNNy8/qF/NabVfFMjAZLZ74r9V7SwkK/E= X-Received: by 2002:a05:622a:18a1:b0:403:eeb9:a76 with SMTP id v33-20020a05622a18a100b00403eeb90a76mr529479qtc.17.1690392419547; Wed, 26 Jul 2023 10:26:59 -0700 (PDT) MIME-Version: 1.0 References: <20230725092149.443119-1-xiexiuqi@huawei.com> In-Reply-To: <20230725092149.443119-1-xiexiuqi@huawei.com> From: Ian Rogers Date: Wed, 26 Jul 2023 10:26:48 -0700 Message-ID: Subject: Re: [PATCH] tools/mm: fix undefined reference to pthread_once To: Xie XiuQi Cc: akpm@linux-foundation.org, acme@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, weiyongjun1@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BC558100014 X-Stat-Signature: pq6gzwrbtf3g55h6tudgbknixc967o8p X-Rspam-User: X-HE-Tag: 1690392420-329443 X-HE-Meta: U2FsdGVkX19sXIiev0yHiWgkC5ny4XBOTV67O2DDApD1l6L/9WEKAUdEWGgCHfQ4TavtF3cg63Jc5NGRWkiSKHdZyLqYNemu2mIQ4qLlC1Bidh8LWv3jT8Cx/Kv0NaE+Ws4gaFAETVxDb1eUmLeLobKsy2TxQzJ1jIOBXbTK5sSNMWPwVYn1YgV3HQF3dxD7eepNpWLJIRum0tIExM9RuacFyOYysIYWLiaCi0ooycAn9+PO3TbqLmH6wzZWKdSOoBzG9tE8ka0YBQEnnVwWjDU5wX/+DAHAODsmi+VjFKdfGQjmFkUWxluvIHLUkqmDympARB06zDV9QdTbEHDB2kWhCdvvl7txx583ZrAci8VZiHdqSnL2RECMlJ4/s5aCKUasiQg9du9Ul4WKOFC9GMBZbxxyFqIkG8Cu0e3bimb60nM26qTIMtc39VPEmAbWcNORFavMLNhWlPQTMuWwWeIcrW+4/KpBZQfVV4uqeYMG0IJAlSKx26PvlLjc2NZ7PaTQ9C/6E4zIjZGeNPBFljPV53Xv9RGYEYZAnl7tJmlQVQkI1I1CHJTjCUPTAggwDUwkJFTeFypHmsnp1Fge7RvFIVNqQybFmROLwzuZIoqPeSJi1TX/QKJ/3SFfm4xixPWdmEgoNemcDl6Ef+FmpFOZdoLaqgSf8MI9Lhg6KgUYV+c/t5uySdbWC0SYMpI7de2G6Vy4O/wEna1Pi0OYqycDThZxCB5HP1vQDqfOOrdto1Np55izDGTdryCH9OOjc3MydVU7KHMgMqGATvtk8aZqNe7C7Ka1iaSf3qmXMbXL+gBGH6lfhEbwBgHQCQAEgrN71pYEBOk63E/PZEZsSGRSNZqy/RqJ2Zo8/Pcj2HiGOUBIR1S9x+QPNFPqltwFzBP+4+5S82DX6KkWfZhl62HOIdUNPA1ShBAVFIDK6CCBZvqJYGJ+uy7lqLxXyFMDHR8GVbbp8b9ZUr8kQk6 dbBmU6Iv rHE4MX0PxxU6ce1wHVSzR/3mjV1Ns11nhyGvb/AnXkjNmTePPWrOwl3jHaykLBaOwWswVAzy+EyK4H+QSGOxyO3ulNfKl8YdAss7t7+ak5WO8uL/KvFZsTEHMWc8J974zRkIjbFDqlK5jtQbtUuovbwicrxUPE3arX/cetTQHgzwwklN/RM+1tGgUKq2jKSxv368Jadxqnv0VNFiJS5ZkihunrYeEHhfD0ehX0n9CqSK2MkaXmo1yGRLDNVZ22EVkFl1Ucovf909pb/dtr54BOzxpBTo0VUiKsBTN9M4VjaBEaFMdcHrBzZoBDeGi0Y3RESgu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 2:24=E2=80=AFAM Xie XiuQi wro= te: > > Commit 97d5f2e9ee12 ("tools api fs: More thread safety for global > filesystem variables") introduces pthread_once, so the libpthread > should be added at link time, or we'll meet the following compile > error when 'make -C tools/mm': > > gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libap= i.a > ~/linux/tools/lib/api/fs/fs.c:146: undefined reference to `pthread_once= ' > ~/linux/tools/lib/api/fs/fs.c:147: undefined reference to `pthread_once= ' > ~/linux/tools/lib/api/fs/fs.c:148: undefined reference to `pthread_once= ' > ~/linux/tools/lib/api/fs/fs.c:149: undefined reference to `pthread_once= ' > ~/linux/tools/lib/api/fs/fs.c:150: undefined reference to `pthread_once= ' > /usr/bin/ld: ../lib/api/libapi.a(libapi-in.o):~/linux/tools/lib/api/fs/= fs.c:151: > more undefined references to `pthread_once' follow > collect2: error: ld returned 1 exit status > make: *** [Makefile:22: page-types] Error 1 > > Fixes: 97d5f2e9ee12 ("tools api fs: More thread safety for global filesys= tem variables") > Signed-off-by: Xie XiuQi Apologies. Acked-by: Ian Rogers Alternatively we could #ifdef the behavior, but this way is cleaner imo. Thanks, Ian > --- > tools/mm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/mm/Makefile b/tools/mm/Makefile > index 6c1da51f4177..9997b2e401ae 100644 > --- a/tools/mm/Makefile > +++ b/tools/mm/Makefile > @@ -9,7 +9,7 @@ LIB_DIR =3D ../lib/api > LIBS =3D $(LIB_DIR)/libapi.a > > CFLAGS +=3D -Wall -Wextra -I../lib/ > -LDFLAGS +=3D $(LIBS) > +LDFLAGS +=3D $(LIBS) -lpthread > > all: $(TARGETS) > > -- > 2.25.1 >