From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BD3C433E0 for ; Thu, 4 Jun 2020 08:06:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58AE8206C3 for ; Thu, 4 Jun 2020 08:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X1ULfBB6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58AE8206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA35F80008; Thu, 4 Jun 2020 04:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2D408E0006; Thu, 4 Jun 2020 04:06:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CDA980008; Thu, 4 Jun 2020 04:06:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 715FE8E0006 for ; Thu, 4 Jun 2020 04:06:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3650C8248D52 for ; Thu, 4 Jun 2020 08:06:48 +0000 (UTC) X-FDA: 76890798096.16.land24_121c1f135933 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 0BF4C100E690C for ; Thu, 4 Jun 2020 08:06:48 +0000 (UTC) X-HE-Tag: land24_121c1f135933 X-Filterd-Recvd-Size: 4803 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 08:06:47 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id d5so5304358ios.9 for ; Thu, 04 Jun 2020 01:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=30zbvCSiUNFC/4JC6r6s08hU1h5yZMzf9vYI5wggAUk=; b=X1ULfBB6m9lNFEUzzxvnEzyoXzk+e9lxy25yEd0WsJ3q60vDpYJVIdXq2FaaLXmQvM sayG59JEagjzc2FRuRVVh1IhEOqCytQlvMyB44xHizQOnuaKAZdWjT9q1tAz9BnWL9tb LLRtATBme2H8jMWw3PeDk309pUT2zvOOCq46f5GYJdhNX8xyOLkIBZoL6eBTtCTcBPc1 wHkOYwMacy8xX6OdYGPWuAS+WMo0b64pwKAqpMj81cwNE2IRkHvFk7XNFlD2PYZ0UOM+ UI6W7R4vbH68xHT4VHiuCb8x537MhsSnDQuajblLnQsnMEatwZJNkDnaEC7WerA6sTaJ +fWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=30zbvCSiUNFC/4JC6r6s08hU1h5yZMzf9vYI5wggAUk=; b=X7IxStg2VQ6Xio0SJyKI6YdcFpiasIkhBI+8AEkZfsBjhJ0u+nnaVvu5Q4Q8xM+UvV SVGXSI52R3/9bReWDcw+vFBJiICr2QQ72YomwBWhWsFegI77F1EvPuqHOZGELE8emSzA T88LWkWNg1l6lfTAvyMLqGoBdv/nxvxmbJUfw1aLMyjffgpMe6RDm1IFO6AV4c8zs4Sq GW7A9DQzmkdC2kMigDfjuIhHtgA2NR32Hswj/hta5UDPHVUZBJmUILBy7hKHjCCKLKui EifpcnyHToSokeGbLUPbP45hk/8iBR1IQzETJOgLekbv2TCh+fpru1rc9Kf6hRGX1iTb DqYw== X-Gm-Message-State: AOAM533uhK7s+mnCK3a87Xgy2f1Hx6WPdrEiHja+kex5fY1tq1ze/3U4 hIlqTJxSFjzrbJjUm9+FW+XM6wdW16pjeWmX7qA6GisuCDo= X-Google-Smtp-Source: ABdhPJw6c7hVXevkuShijLGTZaMQmky6RMLqAb2BAYsD62NN4HlxtQ6cABWQZMFm2BAthP7aWGqt9A6D1gKBOEXJs6g= X-Received: by 2002:a6b:5915:: with SMTP id n21mr3050044iob.103.1591258007026; Thu, 04 Jun 2020 01:06:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:d54a:0:0:0:0:0 with HTTP; Thu, 4 Jun 2020 01:06:46 -0700 (PDT) In-Reply-To: References: From: youling 257 Date: Thu, 4 Jun 2020 16:06:46 +0800 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: Michel Lespinasse Cc: "Liam R . Howlett" , Andrew Morton , Daniel Jordan , Davidlohr Bueso , Hugh Dickins , Jason Gunthorpe , Jerome Glisse , John Hubbard , Laurent Dufour , LKML , linux-mm , Peter Zijlstra , David Rientjes , Vlastimil Babka , Matthew Wilcox , Ying Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0BF4C100E690C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: i build linux next kernel have the kernel/sys.c error. 2020-06-04 13:57 GMT+08:00, Michel Lespinasse : > On Wed, Jun 3, 2020 at 9:35 PM youling 257 wrote: >> I have build error about kernel/sys.c, >> >> kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99: >> kernel/sys.c:2392:18: error: >> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean >> =E2=80=98mmap_base=E2=80=99? >> 2392 | down_write(&mm->mmap_sem); >> | ^~~~~~~~ >> | mmap_base >> kernel/sys.c:2402:16: error: >> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean >> =E2=80=98mmap_base=E2=80=99? >> 2402 | up_write(&mm->mmap_sem); >> | ^~~~~~~~ >> | mmap_base >> >> why not rename kernel/sys.c mmap_sem to mmap_lock? > > The proper fix would be to use the mmap locking apis defined in > include/linux/mmap_lock.h instead. > > However I would like more information about your report. Did you apply > the series yourself ? If so, what base tree did you apply it onto ? If > not, what tree did you use that already included the series ? > > Thanks, > > -- > Michel "Walken" Lespinasse > A program is never fully debugged until the last user dies. >