From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505BCC433E0 for ; Thu, 4 Jun 2020 08:16:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0ECC5206C3 for ; Thu, 4 Jun 2020 08:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nabm25sR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ECC5206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A796580008; Thu, 4 Jun 2020 04:16:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02498E0006; Thu, 4 Jun 2020 04:16:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A34880008; Thu, 4 Jun 2020 04:16:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 6EA898E0006 for ; Thu, 4 Jun 2020 04:16:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 371532C06 for ; Thu, 4 Jun 2020 08:16:10 +0000 (UTC) X-FDA: 76890821700.09.route33_52edabf651000 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 1B8DC180AD802 for ; Thu, 4 Jun 2020 08:16:10 +0000 (UTC) X-HE-Tag: route33_52edabf651000 X-Filterd-Recvd-Size: 4806 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 08:16:09 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id g3so5180063ilq.10 for ; Thu, 04 Jun 2020 01:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kjjlTnSa7zCVTFiJJ897/S5uuNv1Eo5hAY1pnGGn8sA=; b=Nabm25sR4PLNEV7zV1UPUPkYNimXTKjp+dGu60tvTZNRb8dv2u/4hl78eSIISghSTr vtY7oYkZ5I3LZUZcTi048QdGyKiPWLnSlqSR6RADlgtzYpRgolVWIzrzV0bVt5k4YZCS 53+UAJDwhqvzBfflpoYV0nwjk+8UNIKfXuEOTzr1Cco8JmTXyp4RZcFm+7i4uzt5Vtq0 e5FixZ94ygf+D02QbGyKss+tFI9np7MOCWckaDPPR7+fF6tvK4FjfoqKwy8jH+Vfwhkd MAjMvcQuPfBER+beuccuav9azQVIEvlzrdAqlUDUTuF5XLUC/uRkqSHZ35EKT1ImeO4Q S/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kjjlTnSa7zCVTFiJJ897/S5uuNv1Eo5hAY1pnGGn8sA=; b=MqrhQN05N5dw/KawFPI4cYwFJLuQjwdVZM6pd3B0kNJlAzY3LUMrhHhtRSs8SfNsxc e72C66w1pA/f7mxySKujgZhfLdJ3lZ62my9e18q5G2UxBSZhUlC737qFdcwO+jRdB2cB TGYLG4gtzyf/F2TQrXhwnk59Afa+vFo4k3jDlKRhXCNECsIigTHip2kg9oxdHgZZh/vg iv3KR7FZzVuCQDbLNKF52jO6ylDwCWa4FmEMawiWdSFiu3zLYqA+gFAW77uWF64AiHhe OrfF6aMNsDaeinaz8TzhrdnsorUTV2dg+ugfhEQ6CMPjUmnyvAPDndIjWWU0tN97BOVt 5WdA== X-Gm-Message-State: AOAM532xq5dMsvh8rDkfhK657/Jb7JM7sGkV12K1SXaSdbJbGa9Vannr 9O5Pgn7OGm03kOlU48Vwuuvh2eynqcuQ14gdm5Y= X-Google-Smtp-Source: ABdhPJyUX1Zz3KIvZHOPxX4jKyUlPdBfNXICoRiSq7Z7LJrDNOWGSIROXUEGzNsj6q49kVhWXqdAiAdtH6davA6o2H4= X-Received: by 2002:a92:9a5c:: with SMTP id t89mr2939515ili.280.1591258569224; Thu, 04 Jun 2020 01:16:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:d54a:0:0:0:0:0 with HTTP; Thu, 4 Jun 2020 01:16:08 -0700 (PDT) In-Reply-To: References: From: youling 257 Date: Thu, 4 Jun 2020 16:16:08 +0800 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: Michel Lespinasse Cc: "Liam R . Howlett" , Andrew Morton , Daniel Jordan , Davidlohr Bueso , Hugh Dickins , Jason Gunthorpe , Jerome Glisse , John Hubbard , Laurent Dufour , LKML , linux-mm , Peter Zijlstra , David Rientjes , Vlastimil Babka , Matthew Wilcox , Ying Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1B8DC180AD802 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020-06-04 13:57 GMT+08:00, Michel Lespinasse : > On Wed, Jun 3, 2020 at 9:35 PM youling 257 wrote: >> I have build error about kernel/sys.c, >> >> kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99: >> kernel/sys.c:2392:18: error: >> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean >> =E2=80=98mmap_base=E2=80=99? >> 2392 | down_write(&mm->mmap_sem); >> | ^~~~~~~~ >> | mmap_base >> kernel/sys.c:2402:16: error: >> =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean >> =E2=80=98mmap_base=E2=80=99? >> 2402 | up_write(&mm->mmap_sem); >> | ^~~~~~~~ >> | mmap_base >> >> why not rename kernel/sys.c mmap_sem to mmap_lock? > > The proper fix would be to use the mmap locking apis defined in > include/linux/mmap_lock.h instead. > > However I would like more information about your report. Did you apply > the series yourself ? If so, what base tree did you apply it onto ? If > not, what tree did you use that already included the series ? I build linux next-20200603 tree have the kernel/sys.c error. > Thanks, > > -- > Michel "Walken" Lespinasse > A program is never fully debugged until the last user dies. >