From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195C7C433E0 for ; Thu, 4 Jun 2020 04:35:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C31122072E for ; Thu, 4 Jun 2020 04:35:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AhwvEZTg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C31122072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4148928000E; Thu, 4 Jun 2020 00:35:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C5628000E; Thu, 4 Jun 2020 00:35:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA1E28000E; Thu, 4 Jun 2020 00:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 138B78000E for ; Thu, 4 Jun 2020 00:35:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C31D6180AD804 for ; Thu, 4 Jun 2020 04:35:07 +0000 (UTC) X-FDA: 76890264654.06.frame61_2cbc280dad741 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id A5DA01003EE1E for ; Thu, 4 Jun 2020 04:35:07 +0000 (UTC) X-HE-Tag: frame61_2cbc280dad741 X-Filterd-Recvd-Size: 4254 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 04:35:07 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id r2so4789909ila.4 for ; Wed, 03 Jun 2020 21:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=g+64I7JZp1JXS80n8G4BLUDcZzIS9BkuQYkabG+zwps=; b=AhwvEZTgFuvltvPU8KBCKvxVuGI0BR7fYtPWZvsfPhapBV6dbvgPl0k9VcIcG5U7WO ITwqw0rXEPIg0WAJ/I1z7J8ih3dlvz9wWcm2Lmc2NX4mHjFwO0xN8iZ3bSWyH+f4XGj3 waL/8DTQJ9A5pSnXJLcJdVPBohzSQVkde58DeBk6HxMV2jM62Bez7XEsFenQXcrFXDBz scQ7HaAGgXYD0DYQGq6Ly4m9ZOCiLjqtG85+39MmB/+5vSpQJ6+KA4cU00F/oiRue8TU eYGzYLLXyTQdJrUE3I8qGms2BQADyObokXNkoU0zMsqo3mANxayQPQdQvdgCCaZNdREe 9uqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=g+64I7JZp1JXS80n8G4BLUDcZzIS9BkuQYkabG+zwps=; b=pBocBE4Ov4y+1946E3pVUYM3tyoPqArrnD7Fr3BfGCeuomD2zQp3QcNuBBf4vNhw+R RKs5EBQplrjOdi/wqMPotZJvOMzjjsmGDaJx0E0y73jc2OJa5AGXGUMVuARnPmi/4sSq TLbHgdMrbOu5HfwP2784cXLpNjrXfbj5jdnd6BtBvQvnjNvAtJ5trXpNO3odBvE5K9C3 GM8ORe4vb1l5y6N/WJHpvVmsuDVSZxWHKYPVbdqiiKyATNazjPYe8cQrd39YfRr1RJFB 6nUiBf69PZD8ZYb6Vl64kpJJLZBIn2J3tYxTatBRk89drOspsNqXAEv0sRC6e+ZGm1TD iwSw== X-Gm-Message-State: AOAM530uY6m1yt/SR9zgMzw62aOpqd/VKWF3fD8x0IjGz8Alae+HtX17 uzYg0nyuuqekK0Y6bfyBNKyW73eDVAT1Su6onjQ= X-Google-Smtp-Source: ABdhPJwqtGQ0Huvfnt9AjzvUGB7RCsJHSwB61wTKamI8d0uPbjkflX/+h8yjUR6HrSrd6SSwRsXU4LDXrXdyGFkKZi0= X-Received: by 2002:a92:5dd2:: with SMTP id e79mr2331818ilg.94.1591245306792; Wed, 03 Jun 2020 21:35:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:d54a:0:0:0:0:0 with HTTP; Wed, 3 Jun 2020 21:35:06 -0700 (PDT) From: youling 257 Date: Thu, 4 Jun 2020 12:35:06 +0800 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: walken@google.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, daniel.m.jordan@oracle.com, dave@stgolabs.net, hughd@google.com, jgg@ziepe.ca, jglisse@redhat.com, jhubbard@nvidia.com, ldufour@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, rientjes@google.com, vbabka@suse.cz, willy@infradead.org, yinghan@google.com, youling257 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A5DA01003EE1E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I have build error about kernel/sys.c, kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99: kernel/sys.c:2392:18: error: =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=E2= =80=99; did you mean =E2=80=98mmap_base=E2=80=99? 2392 | down_write(&mm->mmap_sem); | ^~~~~~~~ | mmap_base kernel/sys.c:2402:16: error: =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem=E2= =80=99; did you mean =E2=80=98mmap_base=E2=80=99? 2402 | up_write(&mm->mmap_sem); | ^~~~~~~~ | mmap_base why not rename kernel/sys.c mmap_sem to mmap_lock? diff --git a/kernel/sys.c b/kernel/sys.c index 113955fe1c6b..043c04a745a9 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2389,7 +2389,7 @@ static int prctl_set_vma(unsigned long opt, unsigned long start, if (end =3D=3D start) return 0; - down_write(&mm->mmap_sem); + down_write(&mm->mmap_lock); switch (opt) { case PR_SET_VMA_ANON_NAME: @@ -2399,7 +2399,7 @@ static int prctl_set_vma(unsigned long opt, unsigned long start, error =3D -EINVAL; } - up_write(&mm->mmap_sem); + up_write(&mm->mmap_lock); return error; }