From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434DDC433FE for ; Wed, 19 Oct 2022 20:07:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C84EF6B0072; Wed, 19 Oct 2022 16:07:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C350C6B0073; Wed, 19 Oct 2022 16:07:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFC8F6B0074; Wed, 19 Oct 2022 16:07:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D2AC6B0072 for ; Wed, 19 Oct 2022 16:07:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 722FCC0645 for ; Wed, 19 Oct 2022 20:07:13 +0000 (UTC) X-FDA: 80038783146.20.362F6F0 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf14.hostedemail.com (Postfix) with ESMTP id F3E5E100012 for ; Wed, 19 Oct 2022 20:07:12 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id a6so23613797ljq.5 for ; Wed, 19 Oct 2022 13:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=b7CNOQx77jxJkr8fo3A8KqRmFLYVGew+7knPtLNO80g=; b=awEFpEhcqOyuVVRGI60VVcsY5M+7n3ldfd1Do6gZB1LMVB3KIviAIQVoo0kYWTOHT8 XM1MHj97CJzRipIruN5JqNCyKjUeAGAXbhnVmtZadyZlm7K0obdKSz1nbZdSRur3DoiH WpM0+oRZ17FZSFdsb0BHFWIRMTSgulfz/o0MFuuo3sKFZvdXVpgc1Z4QW6TK+DhHBE9/ 8VNXsPpSviKl/qU0YqAEakVFHyvMzyztSAOEde/r0NLVMzhuD+Ni1F2qG/zPZruDeEFL m5TGE/5ApV7g8brCcqclP/YXzChpw8AOm4ewYdXBFs/i/pe8Uw/3y84IWfdoPmZ3poQ0 480Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7CNOQx77jxJkr8fo3A8KqRmFLYVGew+7knPtLNO80g=; b=6EKX2v+xjVUi+B7JK6SI5l6O33e1lYnGq4DOqTtN/Ot2KamVXNBfFDbdd8tERpkS+h d5i4aAN9YeuqQOaR0kgLZeXOcpPC5b9vLblwzwKz7EBL+5HoeQ6hLRQ3I7xyWHlm1GwB fj0Bp5XJzUXGVs9Kx+AboJdXz4zp5fn3wEbX1sCJFPZ4yRh0BojeDKzmfIkTy31pVFtd Veyc5iTQSf+h88YF7TR0sjymE2kS8A9o8KKKkPkANxMMrsf22YjBxCsrVBX/zj0V2upb riFxmuYmpHowniOI7iih3A/p3Q/iBrhrN+dxyaz4DkAXsOaTDnGXCc1yi3MLqD5D6Wm8 Y3Uw== X-Gm-Message-State: ACrzQf2n1gR82f8gW72Rzx8hvpwG9DCF4o64tz9Bk5hKeFc3kA5gbAFd MhOyn6SHECXQb+Cg+qlfzf48Uw6wP8xh9LN9m5c= X-Google-Smtp-Source: AMsMyM6sYCtQ57vM1AQbbV3fxrVxnMWB0NyC+Rv9m+1OQN0e2gDL0yS2/jvhhkzrg5lQMHkx2CWA73bYz/FN+wz9pwU= X-Received: by 2002:a2e:2a03:0:b0:26d:ff37:f731 with SMTP id q3-20020a2e2a03000000b0026dff37f731mr3316534ljq.25.1666210031367; Wed, 19 Oct 2022 13:07:11 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab3:5411:0:b0:1f6:575a:5fb7 with HTTP; Wed, 19 Oct 2022 13:07:10 -0700 (PDT) In-Reply-To: References: <20220915150417.722975-19-glider@google.com> <20221019173620.10167-1-youling257@gmail.com> From: youling 257 Date: Thu, 20 Oct 2022 04:07:10 +0800 Message-ID: Subject: Re: [PATCH v7 18/43] instrumented.h: add KMSAN support To: Marco Elver Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Biggers , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Stephen Rothwell , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666210033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b7CNOQx77jxJkr8fo3A8KqRmFLYVGew+7knPtLNO80g=; b=Q2uFQRLYzzcaneYkrlV8orbg1miSPSqc6pcQMg+tEAGUzPXyw+DiGUp74N/2SH0JDgFOwr OvDVwTZMad2i7LTU25KAow1KwOpnIcR62+HMWDjAbZJpyoQFe2Ss5dhEz7YUOrTnKz/M5Y ctIRSW0QWB8J65b25LthE6+8kKYLO10= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=awEFpEhc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of youling257@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=youling257@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666210033; a=rsa-sha256; cv=none; b=M+G/QPNuubasrGc8N2LGIq8HfrEToMaF0oKAtsviXzOJq0vcAryXXClpMAnql+PAkGFg9+ IkrZ09tSadsc2RO1othI6jjskl310pl76DpowodNvW5FCpAzfzIZh+AoXhq1N/8G6kvysi uowbuTjenVHEe/N/XsdNIUUJkvYZjE0= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=awEFpEhc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of youling257@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=youling257@gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F3E5E100012 X-Rspam-User: X-Stat-Signature: 6qb3m16btuo6eysrdpr5iakemsi58c6n X-HE-Tag: 1666210032-270664 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: That is i did,i already test, remove "u64 __tmp=E2=80=A6kmsan_unpoison_memo= ry", no help. i only remove kmsan_copy_to_user, fix my issue. 2022-10-20 4:00 GMT+08:00, Marco Elver : > On Thu, Oct 20, 2022 at 03:29AM +0800, youling 257 wrote: > [...] >> > What arch? >> > If x86, can you try to revert only the change to >> > instrument_get_user()? (I wonder if the u64 conversion is causing >> > issues.) >> > >> arch x86, this's my revert, >> https://github.com/youling257/android-mainline/commit/401cbfa61cbfc20c87= a5be8e2dda68ac5702389f >> i tried different revert, have to remove kmsan_copy_to_user. > > There you reverted only instrument_put_user() - does it fix the issue? > > If not, can you try only something like this (only revert > instrument_get_user()): > > diff --git a/include/linux/instrumented.h b/include/linux/instrumented.h > index 501fa8486749..dbe3ec38d0e6 100644 > --- a/include/linux/instrumented.h > +++ b/include/linux/instrumented.h > @@ -167,9 +167,6 @@ instrument_copy_from_user_after(const void *to, const > void __user *from, > */ > #define instrument_get_user(to) \ > ({ \ > - u64 __tmp =3D (u64)(to); \ > - kmsan_unpoison_memory(&__tmp, sizeof(__tmp)); \ > - to =3D __tmp; \ > }) > > > Once we know which one of these is the issue, we can figure out a proper > fix. > > Thanks, > > -- Marco >