From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F577C4332F for ; Wed, 21 Dec 2022 17:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8D058E0003; Wed, 21 Dec 2022 12:17:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3C2E8E0002; Wed, 21 Dec 2022 12:17:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDD418E0003; Wed, 21 Dec 2022 12:17:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BF10D8E0002 for ; Wed, 21 Dec 2022 12:17:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7BC67160383 for ; Wed, 21 Dec 2022 17:17:45 +0000 (UTC) X-FDA: 80266970490.02.02F993C Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf25.hostedemail.com (Postfix) with ESMTP id CD372A0006 for ; Wed, 21 Dec 2022 17:17:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hBa2jQX+; spf=pass (imf25.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671643062; a=rsa-sha256; cv=none; b=dtCEKNXSDKE3Eqrlgr0l2lBGFPGIKkNIV7IpwjZZiHVg1Q0g0OfWxx/txNx8nsWLleIT+g l3EUf5gRZjSf2OiXe4PpBAKj13uF/A1GbAFffXf9miwk6wwZX4BD/9och9bVFtfNSkaTUB pFgbUL0ZIwmr/i3wOC/Or+xaMQb34SE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hBa2jQX+; spf=pass (imf25.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671643062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=obPoXeoGwnXe5CqGdFwqw1lMSLFBWN5B3Ufm/DPfw6U=; b=4Nn0xN0rrM8vklM/kNPBvIDTx/fvvCUfpZYe6XI+P1EpOFAsxIj8AcDkvuQUqlJvVeFnW0 954LLpw9894RzE1cdlzgYoyl3pP15j9WiU/0HfjU4yWN2AHFp58a7VdqT1Dq2TzXOFP8D3 9k6uyq1EvU7bfdR0DVJJ8e2oitvF+XM= Received: by mail-yb1-f179.google.com with SMTP id i186so17196692ybc.9 for ; Wed, 21 Dec 2022 09:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=obPoXeoGwnXe5CqGdFwqw1lMSLFBWN5B3Ufm/DPfw6U=; b=hBa2jQX+YX2How1HUjfStPdAV3ULq0M3X5sJVB0HPxl6WZtflb+yvVtaXKtIe03h11 +tRUjiQl40NP+Na+qEt+ivcTx3vCoCewMUDQAaodyaKBDxh4if2ET1+dtz0F0pATAs5/ +L4mco6VjT9x0iMoCnAkAkKUUKBfJPLV9gTwyqtrELDs7Y/weYhOLvFaP1C2bEOKjOtx ElNFX9E77xkLUqa81LUSQpLxsk9xGe2PR9HlZHkUYhvnxezZOzV18ENSfyIlqO2YKoah t421pTE9AJrZBgwKlx+QP1h0rrSizVfLngo4/ai8yZDwTdjCNkvxsGhYXECd+YjUOm/x WSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=obPoXeoGwnXe5CqGdFwqw1lMSLFBWN5B3Ufm/DPfw6U=; b=dosW2o3IgRkPSzPve+evS6fdVKq7fXdBj1eBHQ47ILBjsBjhYsNon3cFfIxitORrVg D/m2SdiOOkVQ5fXNoFrJkMF3JIzbQY5/9jnCKgZdr6UrY1PlieGKgaIMibhrc+QbqMpr NMsK2EwuBCmFMtSQcVIHTQ2mQrDClmWX9qOoXRxNQoLjWTBwXCf902a5ECgNMFI2AY5i 8KNPLPjEtFK0xTHAbAR8Awc14e9Myrd7m/dZI/ENQ2Hl4yhlA0zSNkBG3idWrYPuaFwZ j4l0tUzPUzCZMQ32DHsPOzQdaFObyZz2KeCAW4EPtp40+qH8kgq1y+hyToFcXoD28iTV vYqg== X-Gm-Message-State: AFqh2kqWoZSuzkRlIbZ64IzRARGPLbeU3um7YMuurAFyoccJNAQ/zjGs GWTitMSTAb8DoOrwcvj0veEy0U6rhy0S+saxrv8= X-Google-Smtp-Source: AMrXdXtveEC2+hgy7ihrRHqxFTx3SQ7hEr55PWvD3HSbqv1EZNCaA/UJLaeerK30Q6U0Ho5qcXvBgkxSvXY5yoOTtr0= X-Received: by 2002:a25:dd83:0:b0:758:65d6:915f with SMTP id u125-20020a25dd83000000b0075865d6915fmr188536ybg.582.1671643061860; Wed, 21 Dec 2022 09:17:41 -0800 (PST) MIME-Version: 1.0 References: <0a95ba7b-9335-ce03-0f47-5d9f4cce988f@kernel.org> <20221212191317.9730-1-vishal.moola@gmail.com> <6770f692-490e-34fc-46f8-4f65aa071f58@kernel.org> In-Reply-To: From: Vishal Moola Date: Wed, 21 Dec 2022 09:17:30 -0800 Message-ID: Subject: Re: [RFC PATCH] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() To: Matthew Wilcox Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, fengnanchang@gmail.com, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CD372A0006 X-Stat-Signature: i15n93unx1ey6yuteyf4b7c7hcrqrbsc X-HE-Tag: 1671643062-945869 X-HE-Meta: U2FsdGVkX1+AM2iBmmNMC4wlzVc0UcjD5IL/NlLkcoMweqQvrN/qW1m4H2nMw8hnwSaLBSJXsgDoyvvsTWgx5PeIv+1dZyJTsFd/69DXAcaGWAmfMq7h5IeAxxxe+KJ1X1KYwjrUZlFNv7gLLVZRmYRKl23x7Qskx8NnQldgetNwueyc4e/C8K9qYy1z1orrRugmrMU+6kh0L2v435EABSFjHay9m8MW3igQzWZx0ZpZFNIY+XpB258LDZjn2uXWR3rdfUHIcTwraJbzY/r2ceLreZ8Sw1opOyC3H29ro2U9+TWRSgzE26ZQ9a5iJGWuCRMJXW0lVYkfHqCVg3N5BSRUO2j2t0CQhF5Mr5z6e95LrJIZdfqH8GoOErn9I9G8VSzyAdXtrQf4HlRv18jbTAv6JEYvqmk61EV97rJTRE17mZm4IKsqStwKtr5ZNrvObpb8B3f2wC8mt/I/MUZppfJsJj+VsVn/LnyH4LDNcqXfCq8WfOOrULIAnv1qh2egi04Nk7VyUjYrH4GJEM3jBNoWNesht96CTiq8JlFs6BDDYexyEY0r+hjL5jnIU+jJ6UdCVLLKkN8gs1Y4dWrM/vKrftb4hqRDU3OVnz6y5Cx1flnAb9da98TmVyCP51V+dhHTYLJjsjYxUbQFx6FEsw0dlNZ45vG6Apb01hr7YH2K4wtC4dtyfIudXzGGDhXzw4lj93oAxsa+wTrEsPvepHtn/X18MuucmtYlyJy3enW5SPRqCwUkASTBlCJPaVNjqOGKr9VGmW4bioWMEQsMrUivIUJ103HB7iDOtSj8iKhI/PTofenY77mUTATT++QZuKR1V8W08/Xf9fM7aYYWnC2o268kzo3rFYXZEB3gu3nt6yVlq+WAF//NefxGvqNSuyX6xSjgFkWtHI7PdcnfeiI2ecDqMfv7epuQ459nxxb2nG6JSBxPdgX4yAD5AWlf/foaR1hIVKDuHbPqvwW 2rK25AIh 6E4E3SJrDiyLDE68H8VCtLORjg6dPScjnnhf2Yr/V2JiE5ns1jVMuQpX4m6vEHPmcttmSOyFxQ1aAwgWtAk2V67co+H1Vimar3Fmles97dZ6pea118ENycJuY/VNO1RMAqcgz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 15, 2022 at 10:45 AM Matthew Wilcox wrote: > > On Thu, Dec 15, 2022 at 09:48:41AM +0800, Chao Yu wrote: > > On 2022/12/13 3:13, Vishal Moola (Oracle) wrote: > > > +add_more: > > > + pages[nr_pages] = folio_page(folio,idx); > > > + folio_ref_inc(folio); > > > > It looks if CONFIG_LRU_GEN is not set, folio_ref_inc() does nothing. For those > > folios recorded in pages array, we need to call folio_get() here to add one more > > reference on each of them? > > static inline void folio_get(struct folio *folio) > { > VM_BUG_ON_FOLIO(folio_ref_zero_or_close_to_overflow(folio), folio); > folio_ref_inc(folio); > } > > That said, folio_ref_inct() is very much MM-internal and filesystems > should be using folio_get(), so please make that modification in the > next revision, Vishal. Ok, I'll go through and fix all of those in the next version.