From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F11C433FE for ; Wed, 23 Nov 2022 02:26:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6B06B0071; Tue, 22 Nov 2022 21:26:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 195AE8E0001; Tue, 22 Nov 2022 21:26:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05FD06B0074; Tue, 22 Nov 2022 21:26:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E93E06B0071 for ; Tue, 22 Nov 2022 21:26:18 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BEAD71C69B4 for ; Wed, 23 Nov 2022 02:26:18 +0000 (UTC) X-FDA: 80163117636.03.5F459F9 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf20.hostedemail.com (Postfix) with ESMTP id 6F0101C000A for ; Wed, 23 Nov 2022 02:26:18 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id 205so170696ybf.6 for ; Tue, 22 Nov 2022 18:26:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=00RzDuciGC3lT3xwhCdi5LokzQVvWdDHLPqjXqGdFJg=; b=XxOYWYfkLXZKqUD3n+fJDAFgrClq2Sb81DA9yBIghAtY0oN4Nicw54fBJN26uBoMAW CGE2l0OYqyl+K9YgzLCMSLDmPTBonACWL1AQ5Up02om+CQMp1m9X6OHp2UQGg1ZoJNDm Gzk4QLk6AWIvfTz+i+IWzkn7gG94jmKX0BAJI/VKczV+onDlpPyEZSVe/XX5/qoS8r5i zF9LRUyS0/9vEXBOXQuIV3vLk6ajTk73xwa83CRhfT7AyZQkEQulpme3Z+a++WxExI0e TCDYAL/8MldvAoBL6L6IFvTle63L4kzodOdmgc8aEoxGPbGRslThdQ2XdvF6Rwm561RZ zJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=00RzDuciGC3lT3xwhCdi5LokzQVvWdDHLPqjXqGdFJg=; b=G6UX45QOV3arbr4fdB28MPRl0XOdTN4kcMkAM6xDQRG17oN2BbPyeo8bojqhQNyTvB TZZeJBpSkwfLcmM/K8vphQt738saHPCwyFr+R4kLAA7N3hYar9IrP8cPiczMoXS0vkaH cjhwZlxCbp95D7mkJVeT256tOGF5QLJXNpotq+Bqb4g0xzH9hwJ29aPxv0177FisSrls 6OG2qXJNwHcpOcQTEe07yqAkzKfJv5VMyHL6mmE5UVOoSi+CMpEvi5r3gZdH7Kq91J6k g8PFYztP+iUChmGZzB7J5BCLYbUrjLBWJ3Z2XTN1GK6LKupJXEdY9iDpZ7ncQdmLGxqK MRvQ== X-Gm-Message-State: ANoB5plRzXr5QoyS9yUxcoM0Ir629Hgg1IsJevuimE5zjqWutIxCY8jb SrhCgVTr8O4PD1bAyhO4wih01FUVyKklCHbUV6pkZfzJ X-Google-Smtp-Source: AA0mqf477e8qpxV1bYLLR0R8Ks97SHy8PTkHSXaEkM6HfXKb5dxC5qoWucYbvDF6OuQ91KCwyLIaUcmFQhpCw1GYqmA= X-Received: by 2002:a25:e70f:0:b0:6ef:aa80:9083 with SMTP id e15-20020a25e70f000000b006efaa809083mr2100761ybh.407.1669170377646; Tue, 22 Nov 2022 18:26:17 -0800 (PST) MIME-Version: 1.0 References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-15-vishal.moola@gmail.com> <9c01bb74-97b3-d1c0-6a5f-dc8b11113e1a@kernel.org> In-Reply-To: From: Vishal Moola Date: Tue, 22 Nov 2022 18:26:05 -0800 Message-ID: Subject: Re: [f2fs-dev] [PATCH v3 14/23] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, fengnan chang , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XxOYWYfk; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669170378; a=rsa-sha256; cv=none; b=md7yF0Ov8/dnUvMplMSkDC8JDQ4WJthSzD0JmVkAIX5cFMXdIO8lMbpkXcYd9feP6i6HCV oe4eq5ga5yA2z6v67D2p1UnIUJjMJEqQ8nJrCEY/tVzNzGsx4UI/xaAP3hKz+oK/1Q0zQQ omYnp8hBELVZIO6yW4waDfh0fwD2eGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669170378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=00RzDuciGC3lT3xwhCdi5LokzQVvWdDHLPqjXqGdFJg=; b=tWiNgdfz9lQwKxlES039NHPyOrysDCUfAfXe1yRc2NS5/JK3jmFibwBaInCR9qSSWlVdja qu8857osl6Kjkq4YedBQqM7qhN6t6qMJWRywos0XdKXrUog4NgC+xCh8+5daHLB+rvmHRS mikXWa2gANCZZcCZuhyNyleqlHb0AIQ= X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XxOYWYfk; spf=pass (imf20.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: b9wkiytrfo3bwfannfx8odtcqgm5mrjp X-Rspamd-Queue-Id: 6F0101C000A X-Rspamd-Server: rspam09 X-HE-Tag: 1669170378-639613 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 14, 2022 at 1:38 PM Vishal Moola wrote: > > On Sun, Nov 13, 2022 at 11:02 PM Chao Yu wrote: > > > > On 2022/10/18 4:24, Vishal Moola (Oracle) wrote: > > > Converted the function to use a folio_batch instead of pagevec. This is in > > > preparation for the removal of find_get_pages_range_tag(). > > > > > > Also modified f2fs_all_cluster_page_ready to take in a folio_batch instead > > > of pagevec. This does NOT support large folios. The function currently > > > > Vishal, > > > > It looks this patch tries to revert Fengnan's change: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=01fc4b9a6ed8eacb64e5609bab7ac963e1c7e486 > > > > How about doing some tests to evaluate its performance effect? > > Yeah I'll play around with it to see how much of a difference it makes. I did some testing. Looks like reverting Fengnan's change allows for occasional, but significant, spikes in write latency. I'll work on a variation of the patch that maintains the use of F2FS_ONSTACK_PAGES and send that in the next version of the patch series. Thanks for pointing that out! How do the remaining f2fs patches in the series look to you? Patch 16/23 f2fs_sync_meta_pages() in particular seems like it may be prone to problems. If there are any changes that need to be made to it I can include those in the next version as well.