From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E64ECAAD3 for ; Mon, 19 Sep 2022 17:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9775C6B0071; Mon, 19 Sep 2022 13:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92623940009; Mon, 19 Sep 2022 13:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EE1C940007; Mon, 19 Sep 2022 13:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F79D6B0071 for ; Mon, 19 Sep 2022 13:34:55 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2FD0F1203A1 for ; Mon, 19 Sep 2022 17:34:53 +0000 (UTC) X-FDA: 79929535266.22.94517C1 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf30.hostedemail.com (Postfix) with ESMTP id DD77880010 for ; Mon, 19 Sep 2022 17:34:52 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id f20-20020a9d7b54000000b006574e21f1b6so36273oto.5 for ; Mon, 19 Sep 2022 10:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=kdS9QD9VodJFlDe/hzPt/fIHrfeguLlK063E4oft3xY=; b=RSsN1QZHs/TmzsGp1gwypXdKb/ST8jjoxnGgjyJpGV7sq5aaYponooE63RtJDRuoFk 4VXjc4NPaG7MQomjEcSt+y7p4ZVGuVPclZGjlL/vQiCR0Me8vanyEOYot/zi8Qsubu9j Ix69jBgynF7tCkr+xxKol7c7kNhnVS8KJgxgKk0lyolCfmfJb+3zoq8Vz25NtkyW/5RJ p2+8AeVSPil9bJICaFxtsaSaqUw5Kt5tKUWnYm/Zm3aB+7O1VaahZGVySmK2tZf55QM0 YghzgAsvx0sqLEfTTQQuMHFJo6+U/klj2pt5kixy16lXa6EmRGn5eHCZGXkCezFh7SPi kjXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=kdS9QD9VodJFlDe/hzPt/fIHrfeguLlK063E4oft3xY=; b=FwPMRsbxLF1kstMCJn2bbQjkrnxweejmCLVUyZgXC/+dWc7B/ogv5dv8cQ31tkY5Yo rHgvMpGfUdu7SGpuMs7ZzyWc/eCMfy0UGLZXP5dHln8aw698PDO9c32LMS7tUMbTljmY fKB48nmrCfk+AUcfuTe8TB5G/Y6T0VIgJAc6Pnnj7ZTyEdasTn3pHFh+LOCad95b1gsM XfYAT4MQo01jYNW85Seli69a7xtMTkurUgPH3fTStvupQ9d7hihLjVwPFycKnkyzm3LF PLKTjag/EgUVfrkKcLwqdEbZMF/gwlzLObJxSRqftkri4YXKIxpVgXiDklQewmw8z+zZ QXzA== X-Gm-Message-State: ACrzQf2K32ymhoOiEXRGYK4YOK4XIG4bM4OP2AcKgpSgaRGGZZ67n0VK gdT9/NNLSafI3v4BkL+kfFkUX9Cgrpj41l4HJzQ= X-Google-Smtp-Source: AMsMyM5sQYgUol/jmTSw3stKiJsYQ02a9vmJcS7x25EvIWll4MwqWjrE0KfujNT4rW/qZrnmuFrh2hzLLcoYzG7yGfA= X-Received: by 2002:a05:6830:d8c:b0:639:6034:b3d7 with SMTP id bv12-20020a0568300d8c00b006396034b3d7mr8692869otb.125.1663608892048; Mon, 19 Sep 2022 10:34:52 -0700 (PDT) MIME-Version: 1.0 References: <20220912182224.514561-1-vishal.moola@gmail.com> In-Reply-To: <20220912182224.514561-1-vishal.moola@gmail.com> From: Vishal Moola Date: Mon, 19 Sep 2022 10:34:40 -0700 Message-ID: Subject: Re: [PATCH v2 00/23] Convert to filemap_get_folios_tag() To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663608892; a=rsa-sha256; cv=none; b=ieiRD3scg6H9VIpUS/GOofdtFTTx26hvGAUaY/guCsgUwgavwmH/OPcjquDu5yre69LCXZ G+u4KzAzJHX6t7NEnIlDrRfDhGe2TdR3XuU2CJad/plywDJjcAAR5EDSDbGLLjq6A0qO5e GI+FluItRwjtVZU04vOChJdZkiZ58QE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RSsN1QZH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663608892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kdS9QD9VodJFlDe/hzPt/fIHrfeguLlK063E4oft3xY=; b=yE6WX/BCLZjPxplZmS6xLEjtoi5HPtnRfOhE6INwcWkUjwDjHa0VACuLjhjTwGVjV8D3S4 po1Sn3dXVy0l7dRysU2myvp4SpLcbhJOWaQAkM3+MQ9Y3gMefPVBoryQ3wEbSJw+jWkHsE yxXXYa4rj+OBfb6r0E3jGlEPkV3gRYU= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RSsN1QZH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ybozhsegje6p1b4kn7xrui81yr377kwc X-Rspamd-Queue-Id: DD77880010 X-HE-Tag: 1663608892-951620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 12, 2022 at 11:25 AM Vishal Moola (Oracle) wrote: > > This patch series replaces find_get_pages_range_tag() with > filemap_get_folios_tag(). This also allows the removal of multiple > calls to compound_head() throughout. > It also makes a good chunk of the straightforward conversions to folios, > and takes the opportunity to introduce a function that grabs a folio > from the pagecache. > > F2fs and Ceph have quite alot of work to be done regarding folios, so > for now those patches only have the changes necessary for the removal of > find_get_pages_range_tag(), and only support folios of size 1 (which is > all they use right now anyways). > > I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be > beneficial. The page-writeback and filemap changes implicitly work. Testing > and review of the other changes (afs, ceph, cifs, gfs2) would be appreciated. > --- > v2: > Got Acked-By tags for nilfs and btrfs changes > Fixed an error arising in f2fs > - Reported-by: kernel test robot > > Vishal Moola (Oracle) (23): > pagemap: Add filemap_grab_folio() > filemap: Added filemap_get_folios_tag() > filemap: Convert __filemap_fdatawait_range() to use > filemap_get_folios_tag() > page-writeback: Convert write_cache_pages() to use > filemap_get_folios_tag() > afs: Convert afs_writepages_region() to use filemap_get_folios_tag() > btrfs: Convert btree_write_cache_pages() to use > filemap_get_folio_tag() > btrfs: Convert extent_write_cache_pages() to use > filemap_get_folios_tag() > ceph: Convert ceph_writepages_start() to use filemap_get_folios_tag() > cifs: Convert wdata_alloc_and_fillpages() to use > filemap_get_folios_tag() > ext4: Convert mpage_prepare_extent_to_map() to use > filemap_get_folios_tag() > f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag() > f2fs: Convert f2fs_flush_inline_data() to use filemap_get_folios_tag() > f2fs: Convert f2fs_sync_node_pages() to use filemap_get_folios_tag() > f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() > f2fs: Convert last_fsync_dnode() to use filemap_get_folios_tag() > f2fs: Convert f2fs_sync_meta_pages() to use filemap_get_folios_tag() > gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag() > nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use > filemap_get_folios_tag() > nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use > filemap_get_folios_tag() > nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use > filemap_get_folios_tag() > nilfs2: Convert nilfs_copy_dirty_pages() to use > filemap_get_folios_tag() > nilfs2: Convert nilfs_clear_dirty_pages() to use > filemap_get_folios_tag() > filemap: Remove find_get_pages_range_tag() > > fs/afs/write.c | 114 +++++++++++++++++---------------- > fs/btrfs/extent_io.c | 57 +++++++++-------- > fs/ceph/addr.c | 138 ++++++++++++++++++++-------------------- > fs/cifs/file.c | 33 +++++++++- > fs/ext4/inode.c | 55 ++++++++-------- > fs/f2fs/checkpoint.c | 49 +++++++------- > fs/f2fs/compress.c | 13 ++-- > fs/f2fs/data.c | 69 ++++++++++---------- > fs/f2fs/f2fs.h | 5 +- > fs/f2fs/node.c | 72 +++++++++++---------- > fs/gfs2/aops.c | 64 ++++++++++--------- > fs/nilfs2/btree.c | 14 ++-- > fs/nilfs2/page.c | 59 ++++++++--------- > fs/nilfs2/segment.c | 44 +++++++------ > include/linux/pagemap.h | 32 +++++++--- > include/linux/pagevec.h | 8 --- > mm/filemap.c | 87 ++++++++++++------------- > mm/page-writeback.c | 44 +++++++------ > mm/swap.c | 10 --- > 19 files changed, 507 insertions(+), 460 deletions(-) > > -- > 2.36.1 > Just following up on these patches. Many of the changes still need review. If anyone has time this week to look over any of the affected areas (pagecache, afs, ceph, ciph, ext4, f2fs, or gfs) feedback would be much appreciated. Also, Thanks to David for looking at btrfs and Ryusuke for looking at nilfs already.