From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 495E7C5478A for ; Wed, 21 Feb 2024 17:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE08D6B0080; Wed, 21 Feb 2024 12:16:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A71C66B0081; Wed, 21 Feb 2024 12:16:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 930286B0082; Wed, 21 Feb 2024 12:16:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7EF696B0080 for ; Wed, 21 Feb 2024 12:16:05 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 359F7C043A for ; Wed, 21 Feb 2024 17:16:05 +0000 (UTC) X-FDA: 81816463890.17.0A77AEF Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 9AC3740022 for ; Wed, 21 Feb 2024 17:16:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M9FS6KLT; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708535763; a=rsa-sha256; cv=none; b=J1l79fkSQH6C5UaJKzRzvgjUaHsMStZvbe/nHnj6oshbjLP3QLEO62gRaOIV1cNTiwmszE ASLamsypwzSOzyi6jcIPe9AfpZjfhQnHkte3GW2PVpwtxs7/XF5n7IJ/c9QsMODFIV5RuO q3R7g6y7LTz1RCrxjcqMdRYTayxelc4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=M9FS6KLT; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708535763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SJQdC7idwulVMBcihj7Q1mmstXpwh/b+WQal363i4yI=; b=2nJ8Cvcj8frM7ONIUgDNpJAXOBhglR6lxyyWvI9wBmbCMStsRkSxAQkjkDR6i3WhitZR6S H/b5YYLX3ONMLjLaRinRtybfMbupjMDpCApfCtAVtw2rF0XMNonShxZ2XxKm9lRD4eHBcJ cm0FMpWgeWZDkWrK1O41+vy+qi9ZOAA= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-6002317a427so57859517b3.2 for ; Wed, 21 Feb 2024 09:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708535762; x=1709140562; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SJQdC7idwulVMBcihj7Q1mmstXpwh/b+WQal363i4yI=; b=M9FS6KLTXnQ7KwtW2ZwHiHAiTPwpxw7qbIVDtPw1mehXvYuS1oi2MquqF+Db84TrXG efvBi9i1Wp8+qaN93yzTSajWX/qG8TW6UBEJTGQxd1QUMTKlN1CC+epriCTUrxuM6GDw tDfViW1DlhLVnxbUopvMuYbPa64eZjqNcGD9/SMvzqJaXMukMpRzhPACY5Hk0Cq3m5dW 446FJzb5i7JM1tYrJZxrEfdy6S1BCTQZEtfhczKrbHzecFxS3/ethzLyfy96sFWjjeNk nbz7gd10OXSYeqf27vknXTLkYc0WgYFCO78bwZK1Zjy+NVupDJ8hleAlbfHV5cCOx/Tw 8+ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708535762; x=1709140562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SJQdC7idwulVMBcihj7Q1mmstXpwh/b+WQal363i4yI=; b=qaFs24ULM88wO3mCAGar7DEt3L0uAHNrcko6K9RUUHOKUBNcBxAdrmZ7g6VroKYa7D 5UoCJVwXU8bJy7m855i0qAh6JyaYs0thSnQhQBGxfkeuuFV3PC66HySWAHX0Hpht0Tgl zn+1MGmFVuMGoYApUYLBSJOGSEgTGWvWBnrbeZhIzhLEjZ9cZ0k8M8nU8gShZW7QPwgi tncd9MCOl9A+6WlazxDGOYO/K44rMWdT9HobHEPMofkPOtcufeGTYlvytUzd55VZV3pB lCpGu83jLAiCT25vSf/fqH02QdZgEwYx1lp8HDoPy+ZGpq87pHSZeqyMw4OqZBaPV+GT yf8w== X-Gm-Message-State: AOJu0YxUQnw4pJ3fjiyvU4L7dDNHBGafUJYzfJWolfqPqGOfEqmcjop/ GfE3wB5wHFN7BKki08OvXkiGc3L3TkyreZgojmW/WpDu+yJAvo0VAHTRKoIQASM9oWaQC8UwTdI VxRHup5fm3TSZ8wvMbEtp13jpX3I= X-Google-Smtp-Source: AGHT+IEAwFraNxv2gdyUkWs9AI8tRKZ6QfWhmLXP/8+SdHnZ8j9oEfXqNxxyODBqTs7e1+IEWyyGFcYSAuWRLBcothU= X-Received: by 2002:a81:a103:0:b0:607:9d63:1a85 with SMTP id y3-20020a81a103000000b006079d631a85mr17916533ywg.44.1708535762484; Wed, 21 Feb 2024 09:16:02 -0800 (PST) MIME-Version: 1.0 References: <20240220231424.126600-1-vishal.moola@gmail.com> <20240220231424.126600-3-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Wed, 21 Feb 2024 09:15:51 -0800 Message-ID: Subject: Re: [PATCH 2/3] hugetlb: Use vmf_anon_prepare() instead of anon_vma_prepare() To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9AC3740022 X-Stat-Signature: obpodors7cka19pyuro5urqpnyw1jqwi X-Rspam-User: X-HE-Tag: 1708535763-456826 X-HE-Meta: U2FsdGVkX1+xvGOXfucIngc4Xz2nItHbjAZhS4bX9lw47K/ll/IvO1uliIpAdmEosacZu4RmpAwI83U805fFtd/SCTbS9F9LkhJttMPnFvBBu3RlVc4plPCvqjm/xGsZhizGzLaewKNMEl7rD1RUS5NiC437obkzext1jHUoIuhUh+L/0QWGmtFe7Pph4RI1Zor90za1RHJHbFZh5EDxIW+kCvnMh+057vSUZpnZHgv1oz+b108f+zrPpAGrwvMT2D9Dv5eGCm3+P4uCTg62Jx88uDRkleZPwBY4R1ZQ05IjMfUaVb2xBVoIIvEm7mYn08Krnl4bKqRfydBM4NMpI29NxKlhz2NWA0OmeygkWo2e7fsDL5Mq3xpPAs2KYT0//8pBgIzeMxREqqexQ1MrqPsGsxUtkeAsn+De6OJcqYse+cNpC4mOpbdgnnN+ch6eEhdSyFYo+pBLQkd4E0OscxNIs9LkquDy5/yU+Ddvx+c2YY3NrZSOWhKtAbotkpn6TQGT1Jj3SCDYWBM8rZQ7xLTCmmSOx8uPNy7I0yPy47x69HELfEnWB5/63ttGueJOJJYmYeCuAQszQSwQfeuuvixzySvLkJA4lKWKRf6HPsjo2ezlslhS41PrRNXmGeIyW2hgYAJY9fr+hhLg10tQH36n3W1iOMFpF7WikKEfPDp/vIyEKYqa7FHjAAMAT34zrVl2GtCVNL+5ee79zlTpbsNUN7XuB18d5+0SOXPzaHZwaW9NoAgWnB1zjLHm1efjmD/dAoJOV8crFAQRb1OFa86JnYd/zWDNZbP3OdjK1rMWEOepGWfp2/thsqWiR6bpeZM6dZoS52NF/o1trws1aQu95SFVvmyFQBqIZ8GtJ9BAoMgXnqmCwlM6Rkkm6LZBf2zFGmqokEdfC7VsJdYelD//T71WrQH4tVyju4IVKZLL95ktYTmDs7c37dBDA9DwG4bE9SW7cV7PxY9ixD2 FqcpUMdm rh9pi2MneIEZtMMFqzKRNKM/mUsocB2adJvdxv66UlKZJ24pE/i7QSJF8n7qtHmNyn/LEIOt/PTjzatslkrVEy18yepYn+426vAfjAGHCzKOOas8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 7:46=E2=80=AFPM Matthew Wilcox wrote: > > On Tue, Feb 20, 2024 at 03:14:23PM -0800, Vishal Moola (Oracle) wrote: > > +++ b/mm/hugetlb.c > > @@ -5834,9 +5834,15 @@ static vm_fault_t hugetlb_wp(struct mm_struct *m= m, struct vm_area_struct *vma, > > struct folio *old_folio; > > struct folio *new_folio; > > int outside_reserve =3D 0; > > - vm_fault_t ret =3D 0; > > + vm_fault_t ret =3D 0, anon_ret =3D 0; > > Do we need a second variable here? Seems to me like we could > unconditionally assign to ret: Hmm, looks like we can directly assign to ret without any problems in both functions, I'll change that for v2. > > - if (unlikely(anon_vma_prepare(vma))) { > > - ret =3D VM_FAULT_OOM; > > + anon_ret =3D vmf_anon_prepare(&vmf); > > + if (unlikely(anon_ret)) { > > + ret =3D anon_ret; > > > > > unsigned long haddr =3D address & huge_page_mask(h); > > struct mmu_notifier_range range; > > + struct vm_fault vmf =3D { > > + .vma =3D vma, > > + .address =3D haddr, > > + .real_address =3D address, > > + .flags =3D flags, > > + }; > > We don't usually indent quite so far. One extra tab would be enough. > > Also, I thought we talked about creating the vmf in hugetlb_fault(), > then passing it to hugetlb_wp() hugetlb_no_page() and handle_userfault()? > Was there a reason to abandon that idea? No I haven't abandoned that idea, I intend to have a separate patchset to g= o on top of this one - just keeping them separate since they are conceptually different. I'm converting each function to use struct vm_fault first, then shifting it to be passed throughout as an arguement while cleaning up the excess variables laying around. In a sense working bottom-up instead of top-down.