From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E950C7EE29 for ; Thu, 25 May 2023 20:39:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35E77900004; Thu, 25 May 2023 16:39:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2973F900002; Thu, 25 May 2023 16:39:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11097900004; Thu, 25 May 2023 16:39:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 02865900002 for ; Thu, 25 May 2023 16:39:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E981A140DF5 for ; Thu, 25 May 2023 20:39:07 +0000 (UTC) X-FDA: 80829941934.01.6E2797A Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 214DC8001C for ; Thu, 25 May 2023 20:39:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hsCL+sMj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685047146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VbD1OYIGibvwFMRrdJMTdc4wGgHOsGEW6NjvtgF3JXU=; b=s1RQPSd2p73XSmNWAI31BxjNXU/WQJBkcygnpx+uqWvEdANA18mKbWR3O5GXOYHdXRrVXl 6x9CLC4QyIy9ZWHoAkQ3OwJrwOAD+8pCHNK7zmftglS3Kjso5wdYRbWfXc5BNfbqlN9LxC mM0oYGtSM6xij14AQpQ0GN6pL1WW4sQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=hsCL+sMj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685047146; a=rsa-sha256; cv=none; b=wJjgnRLbpZMRnD5aopcROtvky6k+918gHiKnu5XrD52JIAqEegHitRy2yN7VGRQRf2Ww0X OW/PQVJk/MPQ0q+3GeFMVwz3Mqf2uoH6cbw5V1Ts0jhzjz2ntQYN1z094CwDLeozFZcMim xavohN7w9ejLV4Nbwe35JWSZe43B6k4= Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-babb985f9c8so207610276.1 for ; Thu, 25 May 2023 13:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685047145; x=1687639145; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VbD1OYIGibvwFMRrdJMTdc4wGgHOsGEW6NjvtgF3JXU=; b=hsCL+sMjCSPEeQwY9ipI1+Ugi88AzJEwmAmsO1IR16vD0JLbTTRj1EWY5Xyhze+GRV OIRanM33HOk1xRjR7/GHHUD5lVS6HFpcFxeDfzeE8/I0OcBZz8czUxvwLPGCPl3ZI/jZ DVqHoFaNkDaMUMuSYvpfhlO6EV7GylFCaeIZ84F6j+93L973raF6hD3O66C/pZ4eWLz+ QLbFT/lbaOp/9U1+H051UFvXelrd7lzOtz3vj1HsEWe84ksN1HTRbSJYJedE8uZu9k6u F1jI+oM85Ujez7vT22bFzFiXTlvVTKRouPJkd38Xldm/McWaSi1VxP376ACeyocGF45q tGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685047145; x=1687639145; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VbD1OYIGibvwFMRrdJMTdc4wGgHOsGEW6NjvtgF3JXU=; b=FV715vtAKs4TiRi2ld+6GX9fCVaBTLuJfWGJIctDTt8vSqBrjNHQmTdniV4U5bBL9w VHT38MLCBCAuewLs3TKehPwfbhHzFBhm5OAaO+1oMIECsloSALBCO2FoejmIams7zGba XlyecQ8xWDff0vK6MpGskgh85ZDEJuk6rBntAKI35xnA2xmRs8I/eQEOtNlpRJO+hY0y p4s40P2uOpnP1flof9SvtX8O5NPlDTvrmGLNu4Zfmvs/veSN9fYUiy0frM9V6PdUnoMR ieBoSoqrqeF0Mrcgei+y16HGuDWizGFGmCjQDDqzs8CXjlDJbG681HYQ2/YWH2pcKNsw UICg== X-Gm-Message-State: AC+VfDwktW5NdgYWYbpDnTC8EGxmgaeZtxIN2bbO6QC8p7/N0ejg/dUL W8IzEZspsHMsu2OFF2FX7vc7DPup4qITaAg0N0A= X-Google-Smtp-Source: ACHHUZ4OcPsUwJDpZZlKfNKbpYbRuRkX6Q4UETTfFRyNyytwfdAtGP02e8IuqJSt1+a/7sd0aU+yePVkYawV73NLE1o= X-Received: by 2002:a25:d111:0:b0:ba8:4b48:1de0 with SMTP id i17-20020a25d111000000b00ba84b481de0mr4810389ybg.47.1685047145065; Thu, 25 May 2023 13:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-2-vishal.moola@gmail.com> <20230525085555.GV4967@kernel.org> <20230525202011.GZ4967@kernel.org> In-Reply-To: <20230525202011.GZ4967@kernel.org> From: Vishal Moola Date: Thu, 25 May 2023 13:38:54 -0700 Message-ID: Subject: Re: [PATCH v2 01/34] mm: Add PAGE_TYPE_OP folio functions To: Mike Rapoport Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 214DC8001C X-Stat-Signature: 739hk57557mu84miqqpsj88ptc4bcy1w X-HE-Tag: 1685047145-238413 X-HE-Meta: U2FsdGVkX19/TzL/2G2OC4YFuNzwl+3CaodR97uoiQCzHd/mJecjId3KzDTv64P5IGc67DTKkj8IE0rG20UWI1c/qs7zels51AmWyHNvLoHDiww34aE14QR18bmexNEqaZG9f/yS9JLAFudaLuZZ9peAXWe0Ybkrz7FFlG7tbGajvfGUPieNm9jJVAthmBoei16TImDQJOe6JWk01Pa9rpB//7G5Nqy3O2NUqy+Gu93rPvs8w5gwZ5uXfc78f9fC41VONT6gaGUDh47nuU88n/P+vMnb2l5jEkH40fcxTfNN6aBAcOip8q75EWK02ND+9QbVBNzJn19N1ZxMEW0AMfn6H2QXMhDDQJE8eDPV0em1rNIVBHDR1j0UN5FIr7trh6bhGbBzRggf7yGIz2E4kA/Wq4DpcPzc/PWISR+XhUVpuPhC1580KPLgiVYlm4D8tk0DvQlu82LH98Usr00XUvFYGBmANvReUemIgox4rExl0753Fu+4s2OqnzBh2+pJhy5sp3y8sgYRhJ3zMR0VJXr6uSeuNhGlQpCnzlyKXOhOIzsXgYMhbXEkbVW7Jv9Ggt1tJvVm0KUtdj9QDP1KlY7e/sUGkvnYrfVevlndSmi+jzy0UTs0C09D2sdw3Gp4P4vBVeO6Mkfxd8ukmyRnY6fC3d6B4r8ECGqATxYIvhZhmnmdLaU7v2LXOstyYJcQV8IQGPjcHDZJRaS6Aazj6W+nWt7ZirQKrbivOkoyRoQwuTYeIUgst/xRG1gOxVoUwpQEgfyVqQ836uJu92X9QZya346yDD6xyDrT4ngTS8RG9a4dRZb2GtMrwQ/0dJEN05AqFErW27OYZlmTZfvQKN9Dd0af1srbtWMcQybyFOLyVYP4TwTq58kjM+5bRkaiM5t8bHlljeXQWHWuswQAtReGaaHbzvQH/sHqsRy4vyB0wRLtVD6ngRcaq1/qfQAEggBS23fYvuPqZBWW6TG QBuHIqhF lIGmc7IfwnNgxhZLAneIO4R2f+FdIax9azfgviZls8zWhVdIZIpP5FbmYqhrIn2C41Q7rRvyJkKv+7wnRAyGaugYqEvVseWAsQRZWRb+0YHsP/Q8zaYx+G8kK8zuMys7Xx+kf8ALukYBCbtjxxW7Cki4CIfEBPKoyVLhdQoiGh5wr1uiSXBqFxzoYPBaSXf9KXVo8a5snhkam8weyo29ZFbkaSsnUJ5g4B5KKA53xwPONSk1fGxLD9sYJJCs8kulgVfHZD4Swg/Fm2nIoPgzEyBd8IDVEybEQvT2aOgKp8OQKeH0ClCyV6hqQw5ujaaNPWo7lZG9aBR+YzMRTaEoXja4fJhrEF2q9dgL2Fs7slYi++fvXOndS/q7XlXr7l/FrosAmyaNoAC4ZjVp3hLdgpPIMmP+ka3Lnjz5Az8DFAWliFBUVmIwT9KkZjaFTAXH9tfcE9VcQTuRzmtt8CgdopWGR1EbEJitS4rH6GaD//iy8RLKqqypkoUXsIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 1:20=E2=80=AFPM Mike Rapoport wro= te: > > On Thu, May 25, 2023 at 10:00:23AM -0700, Vishal Moola wrote: > > On Thu, May 25, 2023 at 1:56=E2=80=AFAM Mike Rapoport = wrote: > > > > > > Hi, > > > > > > On Mon, May 01, 2023 at 12:27:56PM -0700, Vishal Moola (Oracle) wrote= : > > > > No folio equivalents for page type operations have been defined, so > > > > define them for later folio conversions. > > > > > > Can you please elaborate why would we need folios for page table desc= riptors? > > > > Thanks for the review! > > > > These macros are for callers that care about the page type, i.e. Table = and > > Buddy. Aside from accounting for those cases, the page tables don't use= folios. > > These are more for the cleanliness of those callers. > > But why using folio APIs for PageType will be cleaner than using page API= s? > Do you have an example? Ah, for example in mm/memory-failure.c there are a couple uses of PageTable= . Like the line : if (folio_test_slab(folio) || PageTable(&folio->page) || folio_test_reserved(folio)) where that PageTable(&folio->page) can now be written as folio_test_table(f= olio) instead. Also there are numerous uses of PageBuddy in mm/compaction.c that will likely need to be converted to folios as well.