From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6453CC4332F for ; Thu, 3 Nov 2022 16:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7EDB6B0072; Thu, 3 Nov 2022 12:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2EFF6B0073; Thu, 3 Nov 2022 12:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F6A36B0074; Thu, 3 Nov 2022 12:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FA436B0072 for ; Thu, 3 Nov 2022 12:39:01 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6B2BE1A10D3 for ; Thu, 3 Nov 2022 16:39:01 +0000 (UTC) X-FDA: 80092690482.16.E1BCC91 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf29.hostedemail.com (Postfix) with ESMTP id 14469120007 for ; Thu, 3 Nov 2022 16:38:59 +0000 (UTC) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-36a4b86a0abso20678547b3.7 for ; Thu, 03 Nov 2022 09:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Kh3PemVjLOMzD+zXkDJxoTeXa2tk+grc1up9htYz3yQ=; b=TBUw7q9qlHT6DGo5HjKtvBxbUDq+n/istEJfhP3bgdU7CnHlK014WON/49qdO7GgS+ RgxuEN4xbsVF7yK92hmPq+KFzPCfizitf30Jyy5THmkvmvJcf0/AenZJFlTbQOqSaq9t mt1fJeTL3SuDAdWBYqrwg+1xS+WwZ0rGkiDIYgN5vnd5oSRNmVoGDw8IxRuWD8Fzi2/s WKOAZr7nTjLUCxj01UWCWqYIS/ToOImwMXp0M0aSr7A6X9lD8R+BB9I11dD3UTwY7BMb dzvLL11zwCIl9tqMPcVFQSAnwW5T4pu4XVePASsS/ZkKBRZ/zUD8v1hoebUdaSPZeMuh xGKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kh3PemVjLOMzD+zXkDJxoTeXa2tk+grc1up9htYz3yQ=; b=5pZ8ioa0eVgupx1QVmaOoa69wlgvIxQmZxPCPsedTtIfeX7eNbZ8AWJzw/qW2D4+kq HINB/Wsec1Q7lU7tPhL3DS3nBse+Q/wEu8HId7Ptt+tnpWDjadqWWgdWlN0M3o9H8sdW prODRLZ8RyA0Su2KC4l3QvvDu4Vd7P0eZ12xE23n9lPECADE0X3YABz3m55hUbyewTdm vK+clJfDknJFJGn2yoh1/mG8ftkAagn8eb1msc6EWMDI9yrEZmPULL8UN30NklErQkfV 6hKR58zMU2bl8GiFgr4xhPpPzloxfbZfwW+5xdHcl3iHQL3dVSCPFxUKLjO6zeZEsFJD 1xgg== X-Gm-Message-State: ACrzQf0y+pUAXphC7J693j4kdy4h3StDe1p4JXKd4rv3CWm8oPZn1vBV szDWVgFaUDV2I1L4TNGUKJXV3HkvCjpgA08ojao= X-Google-Smtp-Source: AMsMyM6eD3AkR/tTwVJuSGW1VpJEcDm8gRAUUIITH99yEF6ks7q7BqgOP+0YDkckG+H0+22nmeoDoFNiML2RzB4TzPI= X-Received: by 2002:a81:1648:0:b0:36b:1891:7dda with SMTP id 69-20020a811648000000b0036b18917ddamr29441580yww.447.1667493539150; Thu, 03 Nov 2022 09:38:59 -0700 (PDT) MIME-Version: 1.0 References: <20221102161031.5820-1-vishal.moola@gmail.com> <20221103070807.GX2703033@dread.disaster.area> In-Reply-To: <20221103070807.GX2703033@dread.disaster.area> From: Vishal Moola Date: Thu, 3 Nov 2022 09:38:48 -0700 Message-ID: Subject: Re: [PATCH v4 00/23] Convert to filemap_get_folios_tag() To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TBUw7q9q; spf=pass (imf29.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667493540; a=rsa-sha256; cv=none; b=6C07KunuMllztEFMjuXD5U17U9WNNdEEaN/tc4XJi3Yjed4Z7pE3LYECw6Mrr68hyaip/M HnrbXmY1VH9wjvE6QGnt50qrSN8u3NaZluhebFdyKffX8lMNAbOCrpGNvlQ9D5VmH0tHRc W93Xy1W7R0qjI5hytQ/+ZAOcKwoGWJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667493540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kh3PemVjLOMzD+zXkDJxoTeXa2tk+grc1up9htYz3yQ=; b=C6qzZYYWER/Ju74bNckUscxZZec4OgjoBbZUUlFsePGTeAS184n54QmhSlU4wm4aCsq7Ec /r9pOnuy+6Xocp+hMJblf9rvx6QHmx+sPL67VabY719PD2j9QTVQh91cYSJu520JeaF38e ZinBqDNsz/kQWu3CESDRCRQLRgOVGvY= X-Stat-Signature: t9k3jxf6wf769fe3dw64wn8qynp9xgjh X-Rspamd-Queue-Id: 14469120007 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TBUw7q9q; spf=pass (imf29.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667493539-897514 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 3, 2022 at 12:08 AM Dave Chinner wrote: > > On Wed, Nov 02, 2022 at 09:10:08AM -0700, Vishal Moola (Oracle) wrote: > > This patch series replaces find_get_pages_range_tag() with > > filemap_get_folios_tag(). This also allows the removal of multiple > > calls to compound_head() throughout. > > It also makes a good chunk of the straightforward conversions to folios, > > and takes the opportunity to introduce a function that grabs a folio > > from the pagecache. > > > > F2fs and Ceph have quite a lot of work to be done regarding folios, so > > for now those patches only have the changes necessary for the removal of > > find_get_pages_range_tag(), and only support folios of size 1 (which is > > all they use right now anyways). > > > > I've run xfstests on btrfs, ext4, f2fs, and nilfs2, but more testing may be > > beneficial. The page-writeback and filemap changes implicitly work. Testing > > and review of the other changes (afs, ceph, cifs, gfs2) would be appreciated. > > Same question as last time: have you tested this with multipage > folios enabled? If you haven't tested XFS, then I'm guessing the > answer is no, and you haven't fixed the bug I pointed out in > the write_cache_pages() implementation.... > I haven't tested the series with multipage folios or XFS. I don't seem to have gotten your earlier comments, and I can't seem to find them on the mailing lists. Could you please send them again so I can take a look?