From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19B7C7EE2E for ; Mon, 15 May 2023 19:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D015900003; Mon, 15 May 2023 15:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57FD4900002; Mon, 15 May 2023 15:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46EF0900003; Mon, 15 May 2023 15:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 36D48900002 for ; Mon, 15 May 2023 15:12:02 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ECB2EA13E6 for ; Mon, 15 May 2023 19:12:01 +0000 (UTC) X-FDA: 80793434442.09.A3DBF3B Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 2AF08100006 for ; Mon, 15 May 2023 19:11:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="W/Z9qzmB"; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684177918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lEdsDznoeQ0wGPMJWBs10mMvCj7VphDqPqR+uizklHY=; b=EIXJXa1iY6f/puG1R6daml3F4PKRS6B49Q9UsxkFt+pT+kGcNJy8ihHrcIQpXADYPZW6gN VW+ZwDOqnnyzH0yJEqlQ6xJHVQcuiIvGd2reFre7NXUU4PVsm9+nhhsd0rA7CkWNl7I/Fc kkQqUCK9t9IgfxQM+y4LKHHFK5BaQjA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="W/Z9qzmB"; spf=pass (imf14.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684177918; a=rsa-sha256; cv=none; b=6sWlSD3tFEsBvD7xWERvZrtQkrrozvHMq3Puvv2lucnpBla3OEsIILrWkiLFJCLYVbJjMo 5AeZsErL2cRuA9N44GLGn1c8TVMQWgUv+eXD0YVTW8fySvGRhnnwbkFFNBINAZrMp+qrY2 itnDwn3mjiKWAAwOdkEizIi3VuF34zc= Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-ba7ed900ac4so910943276.0 for ; Mon, 15 May 2023 12:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684177917; x=1686769917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lEdsDznoeQ0wGPMJWBs10mMvCj7VphDqPqR+uizklHY=; b=W/Z9qzmBUq3bCVhP8uewmPEIaZEVYfzpzeh9YTeAKrK3sWIwtOfql71JlvN0P+P5pK YKy9cml02fk4SnFQ2DdWQ6w4JijHunpNA4zsiud1GYDMnfuy8RTxF/bEehOFA+aPeByE DTSRG2bdMMqymbgvM1f+cbSlSYq+sQANl8uMoYLlmajJ3SyWJdGVyTNcYD0Ioakieviy BESs3L0iPHTKfiNNq75aO8FTJdn/BYay+E8sIKUXSqB49RgAR5VB2xxzW+nwEEKofO5F 26ssX78nNr5JZdvfN8wyMBJyb6MRO06YlrKHWh/GpY8CaWKtewkcbGK5ZJkz6FL2Wiq9 dAhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684177917; x=1686769917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lEdsDznoeQ0wGPMJWBs10mMvCj7VphDqPqR+uizklHY=; b=FaL4UnT8E+7I49K6V1RPC1nfPXHv6xgBcESDUB9lzXTCmjMz4+3ZUDmQJSrgynOVlO eNkdy7zGbh8DNjVwMfDpMSst+DH48tCnBP4sF7TltzW0m5/RDMRriPv4lyvyNpdkZvwK rg78iGXObk/7cGsEws7ls9dzyfgaZgnYaoGfV/mqSImH9fBqdK8O7gkk0U0dnohq9Pf3 RWhpMxrOsOlLsjwctC+26pvQAhbzLdin0RZjEbCiGqAGTZzRRdUM746AAQDFruWA8adt fiIziDIemUf5YzrnvyiiUygIZhNSL/JiSan9qB/5eCBmUEFYZADYXJxpNArWBvtiTwNe DkiA== X-Gm-Message-State: AC+VfDw5dWQ2z6xVHbq6tA+CWLq6T0kH4ZLT7g5pMBmhNe96lixkVwc8 +4wwR9TC5zuQu/WaLl5HtGFF+6rFrxc02sH0Wg0= X-Google-Smtp-Source: ACHHUZ5oDsw20tcH12/01C4i2nT6w5iAb2H6/okJg55EYYpqTgJ8h9iiRdXz2tD9egoOuSwMxk4Rmyquuvv7u/aep3U= X-Received: by 2002:a25:2586:0:b0:ba7:809c:50de with SMTP id l128-20020a252586000000b00ba7809c50demr6158133ybl.38.1684177917068; Mon, 15 May 2023 12:11:57 -0700 (PDT) MIME-Version: 1.0 References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-31-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Mon, 15 May 2023 12:11:46 -0700 Message-ID: Subject: Re: [PATCH v2 30/34] sh: Convert pte_free_tlb() to use ptdescs To: John Paul Adrian Glaubitz Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Yoshinori Sato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2AF08100006 X-Stat-Signature: hh4zh7fbr3natketc5xa1tg355t1nnbc X-HE-Tag: 1684177917-884292 X-HE-Meta: U2FsdGVkX1853tkZ170qJ5uMIMI5qg8K5f0TM3TDZdXX3FO83Uf1/oj7idTkUUp23TyICu7GsecH6WC/dXBxjEqldZFFDJHWxb1fEP10Yz/mm+2B2f/ALae2k98GkLPqmkWumKHGh+IHSMryXxIKVG/GWakL1wT1ISmOSDslt+LHFK1OezHQME0ezoy3TYmDW1XMMIOlnaWi/eJWmn2+vlsT3rO2E1/PpsCZrKdmNVqBF2/Qt6Y81Puizl7ZGlqz5/AUaXH+6sKygZxDpA31L7hIkqLyPjKZuKKDj3HiPqWl84iJOaGfgv4ZEdoiFG6yxg85L1Jp60yNLQ+5Bck3e7y+SY9zu3qgPtgb6axlR81Ya06BeUgrA3qPVbdlWpZ1CWbwRAsbF+CjDvFVOEkXIP4u8ySwv4+pMPAxTHtP9IgucJpUHdKdsEk/H/zuMFVyTjdOlwge5cIHUulY5Laoxb5ODJkycs9BinJWl7NYOgrgWbBuFvvQgioAhWKyivs5PcRMrl0GcKfIDH2cNf5DML0T1776xrLbzrrSGZgKxEHyynS34ZjB6SMZuA6QAh5aoSaiwjyhwQkN/ji95m50PoTiAY1b22BpiOcyEkqbovvbwAT+XuHvNuiwZ3ZNW5VH2E9QO9cpD4Ag7UjnuvYiAJB+eN/vhZbkIlENUeb3stEwc6HnBgAqcVjQuYBzJ1hYz4zd1zSt1K05z311EF3bZQm6uRL73xTJYRoFfYhPB2rsB6fFhmPKQTS6zRd1WgmRoxZVzYwwlY51jvQFAOltIYYE9uHnqRLTgSzleMm2C+EspAtoYC+7xfgYkKWtDaD7t7LsnhOdyT/48pyvTkwmAolczZoTbEUvKWBxjFvUB7Pqq22vLkNvtC3SZLD2zNA0+bepCM9/W8Hm+VwTl0fYqtpyI5QTzdlQOBISiaLQp0081ODrLPl5XlChTWCxT18Z2fTtCNJR6TAY+SYT64q pUyghpry 0SsbJHpNwUJ0fWVYUiltJZJSvyQxSmRltrHNR8y0Si+3bIGTl+OtEBywTem6Ygz5oMJY6T9AX+3HIAODMs+aqcBozZYbqPhyKpcfwP//0G37P1zjNm98FUH2g9A6zhk3IPPBNklXlmUjMh84TO3kfCBf+oqYcxuoNAViHIMtNHnvYrAygRVYweaHXeVmr0Enn9wcdjLyyLdaIjR75gj5d5usb/nldz5N9uxuUQDsqT7ZFmETYPk1V58FefbXa5oHOtl5uqROA82++r5ayESObFNx9oaBkyYzPVpPdxzQ8kHwioK/DeZ3z/WbeqlgQ3rKIKPVLz9t7ZyT/Z/7rJRfdA7aW5/sDPpPCz54Lzd6jEKMPDJNoKijo/kupCDCYd6icKCeYOtU86/NqaBTipJxPBeBzJ2VomQBZ4aOByFAoGzeJ33wsqgzpyEsivOhLn74UpQqe3qtLLUUn7UmlIwatCx6lCz0ROqY51egqyNAjiBZKkMRtkZGY6i9CzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 6, 2023 at 4:35=E2=80=AFAM John Paul Adrian Glaubitz wrote: > > Hi Vishal! > > On Mon, 2023-05-01 at 12:28 -0700, Vishal Moola (Oracle) wrote: > > Part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents. Also cleans up some spacing issues. > > > > Signed-off-by: Vishal Moola (Oracle) > > --- > > arch/sh/include/asm/pgalloc.h | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgallo= c.h > > index a9e98233c4d4..ce2ba99dbd84 100644 > > --- a/arch/sh/include/asm/pgalloc.h > > +++ b/arch/sh/include/asm/pgalloc.h > > @@ -2,6 +2,7 @@ > > #ifndef __ASM_SH_PGALLOC_H > > #define __ASM_SH_PGALLOC_H > > > > +#include > > #include > > > > #define __HAVE_ARCH_PMD_ALLOC_ONE > > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *m= m, pmd_t *pmd, > > set_pmd(pmd, __pmd((unsigned long)page_address(pte))); > > } > > > > -#define __pte_free_tlb(tlb,pte,addr) \ > > -do { \ > > - pgtable_pte_page_dtor(pte); \ > > - tlb_remove_page((tlb), (pte)); \ > > +#define __pte_free_tlb(tlb, pte, addr) \ > > +do { \ > > + ptdesc_pte_dtor(page_ptdesc(pte)); \ > > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > > } while (0) > > > > #endif /* __ASM_SH_PGALLOC_H */ > > Looking at the patch which introduces tlb_remove_page_ptdesc() [1], it se= ems that > tlb_remove_page_ptdesc() already calls tlb_remove_page() with ptdesc_page= (pt), so > I'm not sure whether the above tlb_remove_page_ptdesc((tlb), (page_ptdesc= (pte))) > is correct. > > Shouldn't it just be tlb_remove_page_ptdesc((tlb), (pte))? As of this patchset all implementations of __pte_free_tlb() take in a struct page. Eventually we'll want it to be tlb_remove_page_ptdesc(tlb, pte= ), but for now the cast is necessary here.