From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6A3C77B73 for ; Wed, 19 Apr 2023 20:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B9C3900002; Wed, 19 Apr 2023 16:29:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 969816B0072; Wed, 19 Apr 2023 16:29:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830FF900002; Wed, 19 Apr 2023 16:29:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73C7B6B0071 for ; Wed, 19 Apr 2023 16:29:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 323CDA0423 for ; Wed, 19 Apr 2023 20:29:29 +0000 (UTC) X-FDA: 80699280858.14.8DEA6AA Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 2CA4CC0023 for ; Wed, 19 Apr 2023 20:29:26 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WIB0Mw6m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681936167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ri4M7wwnqfUyWg7ITQYtSCFlkjwgDD80RYs577YrqxA=; b=3ByTQQfu3yWW887guoYITmqaaXZYR5gxdqt6uoHc6xCOZK70ITeoftNQvocuuSy2lpL4mZ LlqvTA8vdc4XxxtybgNOtWYhLjcUWacm/8LrAUdPX9cjYmIMQaWi1fQZHVwdt1Abem3qVT PF95mSKQy+sQck0d32aq+qazDai9d64= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WIB0Mw6m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681936167; a=rsa-sha256; cv=none; b=qcOgBddCOSc6Rr6lqGDqo/UZu2lZFNn3BZAW1XOvwa+1uTFE3Ztk5mZM9/z0k4lxOgY2U1 y2V3ZCbviG0gWx08v+CigxdMFkx1730AYftj4MinVCZ8JEQhIkd0wRRxmtpQo7ekrRtoM5 +w04mH/XMm9DQffTh1qJjaEi//6mgpk= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-54f6a796bd0so15684717b3.12 for ; Wed, 19 Apr 2023 13:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681936166; x=1684528166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ri4M7wwnqfUyWg7ITQYtSCFlkjwgDD80RYs577YrqxA=; b=WIB0Mw6mTuaRsirvoZFjheEp9yY5Y/q9onOHwXnfWFMdFmYyli6xaVNh9nuRkFM8Bu OnXLT3OfefylOw1YM4VwkunQfq+Wm/ji1lKG5q5iuDSnqXz+pveEOmagYUHY70pV+qoa KvVDM5rfvXh7k0t2ztxy0CpMZU4jrTcGpdw3ugWQ7PYvTc5DIMuci51oMb3/89hTRu18 ASTMyUIpSKSpdVyzVJqnIsAfKfcTX+AN3kdlEImle/BVRj8WezpdfvQGOxxtdhWDpR5M v2CCX9NS0Q1nwilMdzeBzucKwgU44O+OvH3u0Wiv6qbWAvaUduq3fyhR1v2QD/zzuIcP d4gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681936166; x=1684528166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ri4M7wwnqfUyWg7ITQYtSCFlkjwgDD80RYs577YrqxA=; b=giCcu9LJ4hdqTkgs8n0vXVNHc/E9Ewt/04jQDEVAtwDRVEoJwMFn1P9EEueJ8C0Xpn 2VnCXnbPZ1LE8Kb70jsG+DHE1EYhsy5oacTDudubjrw+19i5UxWP3jDfopHkFU3IvLz1 CTbwDv03mS1YYvahwq3vAlhxoGDhOj6oP8oGGNrOCWHryzZOCmplPk8UcrzwUkXrGUaE 4FIoBTpyRU326AHOCcrVyg2uGAdl3ud484li9oUOnw1apUabn6cFRB9dwNY4RHrT79I9 FFO50117xp7OwASAgqHGx7yY5ZgzSDpn+ITlhcjDIX5ZfVf7mXY9zn5sf6YlZXmnTuJh brPQ== X-Gm-Message-State: AAQBX9cSFLSVg+KaHfEFOeTBHOTtk/rBqiHm7PUauzsmgSi0IohTCBur IK2/kbbKkcXib0x6VDBpUF835aF+5UG3ZOKd7Ag= X-Google-Smtp-Source: AKy350aNDMALBM0VAdPN5cwgCAJgGmI7MyMPzfpEMhO/TACZWqeGBJUZoGoWlGr6ZHAaYh0Tzxhzwi/dxg7Fov1Ofog= X-Received: by 2002:a81:53c2:0:b0:54e:84f6:6669 with SMTP id h185-20020a8153c2000000b0054e84f66669mr4502802ywb.49.1681936166163; Wed, 19 Apr 2023 13:29:26 -0700 (PDT) MIME-Version: 1.0 References: <20230417205048.15870-1-vishal.moola@gmail.com> <20230417205048.15870-5-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Wed, 19 Apr 2023 13:29:14 -0700 Message-ID: Subject: Re: [PATCH 4/33] mm: add utility functions for ptdesc To: Vernon Yang Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2CA4CC0023 X-Stat-Signature: igs5pqruiizqauy3tqb4pekwy1yooqk8 X-HE-Tag: 1681936166-23463 X-HE-Meta: U2FsdGVkX1+l+NEtvXJq3Jb179DrzT0GZSrS8juCGntpRi9eETpNGDkeM9J1EvvUW0HFo7ImySxocdQ2zI9OJ0hL9vbNbBIkNvzTaycRlvuuIXE2SCZM91lyHhXyBwwy1+ordDnpYiao4CW64+Dm6UPsfvpAHlWuextiaC8nVTk3Rcd8P7xVgGLWAz7Npk/3YBN6TsO+1vqVi57AdurvmMZtnuiA7o1ZZWL0BBUQZeBHhTkk0QkQAg5jm9zYBwsgvqp/tAiFxkkuhIxPAe4gwG3l/OEWh/QCLnYSUzp8hYR8X6RdnAn10nQEopZICsXTO1v1amXviyR5+ZHsWVIH0YaRwfIqVw3kudnNaKTnDKmBX/037AJVe3O/0Ytp5tD+u5ckWYrnlypZxtbm44C0JuM6XvvbpEFLOw3M02V/FZGfnTkdID1b3gP2jAHdswa3RJZIeXyWgQMQbsVsyMfLIekI1WijJaC/JosknqBRpZrWJiZjDxwcuYhez5CTg2wIV5LNDRL/dSVqbjApJRP1bj3iNHtBbpf/JGPlZcWyBsII7OoFwC2le8tM44CajcqhvL0PBDpiw3UMxJg3rR2m/oONrCjxAkqa37pjZ9kI5p/lkcwZopzRPdvMp2UZxFk2YOj9TFSq3F83FEinyGcbAzj/JTGE3etqusjrkgjV7pWl26rQ5NuJu+pmtDjCI35w0EBzU3J2qJqAc1QOc/PGDuOl+Pa2X/34V4ckCF5mJrwGQdBuR/mt/arJxeDjbu47DIrKM4QBzAcyKSL+fEArqI5Nv46SUa3fEW2LZAQvqh3PWmzcgpZlrxV7Hnf9HFulqyyvex4eeUnxrmFfq1BnW43UHiGh7S69uDhJAeBfVzVqReIwz7Qi3lvPXFcF6r790J5aiAAxhwFqt4AiJKHFhWRFwonz6j2a/OXvIodRY/sty6pkIsDP5F9wtRlVtZL5Z8hHa/lIOm8g0T+2ES5 RL7K6SaO PORglXQ5iVimGoLxkk1PbV4ZIRZhnQ/o0tXVd38pCKqDCl9hX1Wv2OZvqNLtvO/lo2143d8xW6T/P2jtPP921WONs78o8Uimai8OVr0jtmbmNOCRw9jaDwis0c7rZyRYqHUAqNGQnxvSu7Jp6C5MXS1Dqix6uYWD91LL0V1TGE6gyJcEt/q1PLWgrdQYRQdAUO7vMfx/UiyvgBdj7lADZsbTcn9O+j2/QEQ/pYc2zbZ6SYE6rFtIYfHmjxFeCONL+ejox7Yxmv2PS8wXqvKRzDdlIYKc/CmWMdbDK207fbA5sS4k47QOyMU9kB34Gh1F28hl57RKUjBdxo8yoX+nsEeZunNe7Q+llpXYRKKC2Yhy64gK1xKdxfw0xU/XBvg48dt86IO2VF7fUymSZm576wPr3pmrlr5gFk7vYsXcjotIsKdUf+3hOVssqnCGT06pejp61DDIyUszUy+jhgbfgcbKBlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 6:34=E2=80=AFAM Vernon Yang w= rote: > > On Mon, Apr 17, 2023 at 01:50:19PM -0700, Vishal Moola wrote: > > Introduce utility functions setting the foundation for ptdescs. These > > will also assist in the splitting out of ptdesc from struct page. > > > > ptdesc_alloc() is defined to allocate new ptdesc pages as compound > > pages. This is to standardize ptdescs by allowing for one allocation > > and one free function, in contrast to 2 allocation and 2 free functions= . > > > > Signed-off-by: Vishal Moola (Oracle) > > --- > > include/asm-generic/tlb.h | 11 ++++++++++ > > include/linux/mm.h | 44 +++++++++++++++++++++++++++++++++++++++ > > include/linux/pgtable.h | 13 ++++++++++++ > > 3 files changed, 68 insertions(+) > > > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > > index b46617207c93..6bade9e0e799 100644 > > --- a/include/asm-generic/tlb.h > > +++ b/include/asm-generic/tlb.h > > @@ -481,6 +481,17 @@ static inline void tlb_remove_page(struct mmu_gath= er *tlb, struct page *page) > > return tlb_remove_page_size(tlb, page, PAGE_SIZE); > > } > > > > +static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) > > +{ > > + tlb_remove_table(tlb, pt); > > +} > > + > > +/* Like tlb_remove_ptdesc, but for page-like page directories. */ > > +static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, stru= ct ptdesc *pt) > > +{ > > + tlb_remove_page(tlb, ptdesc_page(pt)); > > +} > > + > > static inline void tlb_change_page_size(struct mmu_gather *tlb, > > unsigned int page_si= ze) > > { > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index b18848ae7e22..ec3cbe2fa665 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -2744,6 +2744,45 @@ static inline pmd_t *pmd_alloc(struct mm_struct = *mm, pud_t *pud, unsigned long a > > } > > #endif /* CONFIG_MMU */ > > > > +static inline struct ptdesc *virt_to_ptdesc(const void *x) > > +{ > > + return page_ptdesc(virt_to_head_page(x)); > > +} > > + > > +static inline void *ptdesc_to_virt(struct ptdesc *pt) > > +{ > > + return page_to_virt(ptdesc_page(pt)); > > +} > > + > > +static inline void *ptdesc_address(struct ptdesc *pt) > > +{ > > + return folio_address(ptdesc_folio(pt)); > > +} > > + > > +static inline bool ptdesc_is_reserved(struct ptdesc *pt) > > +{ > > + return folio_test_reserved(ptdesc_folio(pt)); > > +} > > + > > +static inline struct ptdesc *ptdesc_alloc(gfp_t gfp, unsigned int orde= r) > > +{ > > + struct page *page =3D alloc_pages(gfp | __GFP_COMP, order); > > + > > + return page_ptdesc(page); > > +} > > + > > +static inline void ptdesc_free(struct ptdesc *pt) > > +{ > > + struct page *page =3D ptdesc_page(pt); > > + > > + __free_pages(page, compound_order(page)); > > +} > > + > > +static inline void ptdesc_clear(void *x) > > +{ > > + clear_page(x); > > +} > > + > > #if USE_SPLIT_PTE_PTLOCKS > > #if ALLOC_SPLIT_PTLOCKS > > void __init ptlock_cache_init(void); > > @@ -2970,6 +3009,11 @@ static inline void mark_page_reserved(struct pag= e *page) > > adjust_managed_page_count(page, -1); > > } > > > > +static inline void free_reserved_ptdesc(struct ptdesc *pt) > > +{ > > + free_reserved_page(ptdesc_page(pt)); > > +} > > + > > /* > > * Default method to free all the __init memory into the buddy system. > > * The freed pages will be poisoned with pattern "poison" if it's with= in > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > > index 7cc6ea057ee9..7cd803aa38eb 100644 > > --- a/include/linux/pgtable.h > > +++ b/include/linux/pgtable.h > > @@ -97,6 +97,19 @@ TABLE_MATCH(ptl, ptl); > > #undef TABLE_MATCH > > static_assert(sizeof(struct ptdesc) <=3D sizeof(struct page)); > > > > +#define ptdesc_page(pt) (_Generic((pt), = \ > > + const struct ptdesc *: (const struct page *)(pt), \ > > + struct ptdesc *: (struct page *)(pt))) > > + > > +#define ptdesc_folio(pt) (_Generic((pt), \ > > + const struct ptdesc *: (const struct folio *)(pt), \ > > + struct ptdesc *: (struct folio *)(pt))) > > + > > +static inline struct ptdesc *page_ptdesc(struct page *page) > > +{ > > + return (struct ptdesc *)page; > > +} > > Hi Vishal, > > I'm a little curious, why is the page_ptdesc() using inline functions ins= tead of macro? > If this is any magic, please tell me, thank you very much. No magic here, I was mainly basing it off Matthew's netmem series. I'm not too clear on when to use macros vs inlines myself :/. If there's a benefit to having it be a macro let me know and I can make that change in v2.