From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E0BCC63703 for ; Wed, 7 Dec 2022 23:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ED6E8E0005; Wed, 7 Dec 2022 18:45:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09D648E0001; Wed, 7 Dec 2022 18:45:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA80D8E0005; Wed, 7 Dec 2022 18:45:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DABAE8E0001 for ; Wed, 7 Dec 2022 18:45:37 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A912EAB672 for ; Wed, 7 Dec 2022 23:45:37 +0000 (UTC) X-FDA: 80217144714.13.51E6F24 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf18.hostedemail.com (Postfix) with ESMTP id 239B91C000E for ; Wed, 7 Dec 2022 23:45:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Be1pHwvM; spf=pass (imf18.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670456736; a=rsa-sha256; cv=none; b=x6ENOJ7QGJ28ZZBBf96IuR8PV3OgG7zPItzU9U+i11w/0qM8rwhh+PMkfq/dVgOSr76NSM 3azbmsfn3FdtsezZrI+/J068EO7qR/XS+QR7Zo0FhiPt5d4+sRtWEW8WH0zbLygpPsT/Pr p+xZchZYRmIUD+j+ApZxm1bBdaQG/2s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Be1pHwvM; spf=pass (imf18.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670456736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mXsz6/Icjh465llNxu4s0rXYIhAO+R+B34XNkGIo6eQ=; b=suqIDrQh3lVZH22hZeQTwqThch/Rkk2TJxHN/1KkpALiOiUntce6bMYciF9FdZQrXVmYK0 4K9s0AFY2ke6ZhW8JGAMd6KSWuSreArdoaYKz+kXBvOYoUUP5KWXaf1Z6eKrrmu4FVY5p2 4yikt310gaRYg8AqpxJ1eNDp1nKoF9w= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-3bf4ade3364so203873297b3.3 for ; Wed, 07 Dec 2022 15:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mXsz6/Icjh465llNxu4s0rXYIhAO+R+B34XNkGIo6eQ=; b=Be1pHwvM4e7ouSG+ZY6N9k/NiEQ4tzzDVuXyq4CEbwd9ADrS9FJ3QaPyXtXz2d1OdS qYzdxL6v4h/5A9aQJcky67nIla75qGdrJ85MwA1KqQc3qgPS4YtS4Vut3e6qnGU82G3o lQHWwLuJtztifl8vYx5gAgBC8BNMgctCbp72zj3JslJx5k3nQosHW4HKSGteEit76fR3 Yc0mGCeHk7bo4xicAjtUfwALdzwuGnKwQvDu1x0nLwq6Qb3WzoqCxfZ4zEUbgJXsd/oH bmeiO9/QSI7+8qvg60KDx7Ti9ptHefiR2pn2ij2Gs6XWpl2Ld/c0+UgyzbpAfe7ooJHE Ca0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mXsz6/Icjh465llNxu4s0rXYIhAO+R+B34XNkGIo6eQ=; b=b/uGejiY5jQDtRI5XHm1yX7hDHMm+8j4l+/oFbsPdfV0sjqr4QDRZUfvNyfCyF6gnv aYUg/v6kwYmR0miVnXmhofKE6y0h9Qi2GP1m/87Sam1K93dTr+a0crbtdc3kNxn6Df6N SNbu1cYUQPL22m8hXbwU3vKCInsPfCM5xn85wE27ZHGklIKIhxqRe2L4RleSWOMvranc ZIR+kkv0fNwneLM9r1PZZ1CjfMPdHUUOpPm/K7higienhyQtPNgUWi4dg5mLQE+egGLK 3rjWsHWGhLL+dYhd244+5IX7sUXws7egU7gC7WPwDUiexBV/odF+EWRGcvKsMXTZNA4k gIiQ== X-Gm-Message-State: ANoB5plh1HoOx3AHlJ8XsEFtWaGpgsHTv+nh/OZLroEKwWS/lSihuDZo HN79uplcG0hdoBtEcxtrprDJw6CrN0YesClekt8= X-Google-Smtp-Source: AA0mqf52bzfVlI6LIM25NDvI3hhBqrvEmEgMvsJj/HL3v965u91m6cU3HIkbbbsGBTFyKyJOp/lVfoCS00snfAfx8RU= X-Received: by 2002:a0d:cb43:0:b0:368:e8a:3b1d with SMTP id n64-20020a0dcb43000000b003680e8a3b1dmr21578440ywd.469.1670456735268; Wed, 07 Dec 2022 15:45:35 -0800 (PST) MIME-Version: 1.0 References: <20221207230152.22938-1-vishal.moola@gmail.com> <20221207230152.22938-2-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Wed, 7 Dec 2022 15:45:24 -0800 Message-ID: Subject: Re: [PATCH v2 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios To: Matthew Wilcox Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 239B91C000E X-Stat-Signature: ces566uxcw5i9s9p3ze1d4ytgjx17t91 X-HE-Tag: 1670456735-609909 X-HE-Meta: U2FsdGVkX18UFObvFC89sYjj3KIhTF26gvJgjUrpJkLSA0DRefKOHCbLC4OHss8BV5y1CUvImpWQG+ykSdpVCFQtoKytCRGXhVozwFB0q6mhB+0MAeungzf8eF9YPizIYga5t2zVdgBy1BaMPL5Uh1pb9fpt/pAQlfNDqWaziQXMsaNtSsszL0nNdz4+IHT5hqkDPoz3A0rSoi061QJoesNh8BqFNqmTReuSqVB4dsat0DpP/2Y9FQ8Ew2Y/ZxGe5Cot7qfNTccXeooJg1xkd3O7Lc5Drpn4a7C+ZipxY2RQTw4z+OTTGws22GZ2zirS+uaZ6zpUewkIg1qX7JZa3pF/CmWbevX2vKegTjEihjYuxjETtlFYTlg6tp3U7HhNmN+RL8Tap7NMK3Nl75joY6O9GTLBx9vQpbAWeiy9AKsSlEaRzhJtKV2NkHuU3OlejNcLBQl3j9YWTs9BmcDCe5RzBxj47RTrVh6eHGb7ys3QCmkAbk7bjSwwgBY3vqw5WGTGPsSkgevhjETWqyNwo5cssJ/2LsGazMifg4jjWPtWr6NSyx4NQV2bJORpUwhqa45V6sTz6ABSlB6nmOGXpQA61wjk6ZYBogO7Cm+97q0zssQItAjPUoBRjr6Ni3ol8wKT4eXYpcqSxElHd6RppVkUdm081lf5+c9JHH9T1fgvfpxtrwGqPujVwRgx0lw6GWe6FWac4Vx/4l3CDtIvbRHpjpPbIcpnGzCX/Jjaa7tgU1xfPzdadhD+lgxUh9VOV8HsIpmHg8L9ew92QLzsFqNnoku0lvSEITfV93scnqg0oWqSlMn3D3VA9d6EOZo1vCwKGi+AeVwvoEv4QEH3rBq7ktPHInU1af/fuCbHOEXdp6u9z5IV1JDfOmxnI5TrICNSumY72A6F9DplLTlWgb9nnbl2tkwsXnsodxN7EyAQHZN0Prb48e+cfyq2RsP1aEOdOA8T6VFIsWtw6cA Z68PfleE nHuLYTw97pTinA8znzOhQwrRjUt1HZCL3Gz2rA4gofDywxqa4FsFrIM1DDPpYEmbIt+ObfwkARFkx/LEIkboANra+8Lyp7/47itqVKEe+kDefVyrUohQDT0QTOeOp6yspWyIa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 7, 2022 at 3:09 PM Matthew Wilcox wrote: > > On Wed, Dec 07, 2022 at 03:01:50PM -0800, Vishal Moola (Oracle) wrote: > > @@ -424,28 +425,29 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > > page = vm_normal_page(vma, addr, ptent); > > if (!page || is_zone_device_page(page)) > > continue; > > + folio = page_folio(page); > > Maybe we should add a vm_normal_folio() first? That way we could get > rid of the 'struct page' in this function entirely. Yeah, I'll do that. Many other callers will benefit from it later as well. > > @@ -453,13 +455,13 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > > } > > > > /* > > - * Do not interfere with other mappings of this page and > > - * non-LRU page. > > + * Do not interfere with other mappings of this folio and > > + * non-LRU folio. > > */ > > - if (!PageLRU(page) || page_mapcount(page) != 1) > > + if (!folio_test_lru(folio)) > > Why has the test for folio_mapcount() disappeared? Oops, that page_mapcount() should have been replaced with a folio_mapcount(). It appears I accidentally removed it.