From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1392FC6FD1F for ; Tue, 26 Mar 2024 20:06:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C6D76B008A; Tue, 26 Mar 2024 16:06:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 776976B008C; Tue, 26 Mar 2024 16:06:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 665D76B0092; Tue, 26 Mar 2024 16:06:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53EAC6B008A for ; Tue, 26 Mar 2024 16:06:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D60A01A076B for ; Tue, 26 Mar 2024 20:06:33 +0000 (UTC) X-FDA: 81940272666.28.9344E7C Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf07.hostedemail.com (Postfix) with ESMTP id 0988440011 for ; Tue, 26 Mar 2024 20:06:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JLMpwwlB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711483592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hXt48dRidL8rW35RYbRjHW/tPWj+iNgp6Je58Y5ZAVY=; b=XMMXYsF9fVivdnhomhL6Z9dfEg7oQUe04TRyk5Wc6AggkJEkWpbr5i6JMf5CW0YjZhQDQl S5lnOSl8MFEcdDF4JinnXwaFXhtq7OIXIQtzfminUB+/RycmAQ0Y2mNKMm//AERzwQZqwT JI3/i1Pd2//u91G0qouBV6U50Ve0pxs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JLMpwwlB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711483592; a=rsa-sha256; cv=none; b=LAuCg0uQlYjH+UNKemkMV5wpgSNWXt5NijcD8gvWAq4Trr4MRrIsMP2Dj9xPuiBNOOOh/V GrjgzOKodKUU6SHTyQpYJdAkm5tV6g5A/VKKtcszXrBvpjXEzXcOXKSR5TrF8Y5bfnmZgh S8KDMLTItJNMz8JqFdHHuG6+/PDwk54= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-609f4155b76so64072337b3.1 for ; Tue, 26 Mar 2024 13:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711483591; x=1712088391; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hXt48dRidL8rW35RYbRjHW/tPWj+iNgp6Je58Y5ZAVY=; b=JLMpwwlBaPBScBfl9WEbd4cGIgoRXJj3oJA3Sy/+87GL+cI4R89Bq8rG7K4FHMgA0O aBYK3NaYYD/lUh4TIeeck5o89OO4SFqG6RQMwnccaaXuJjfj+2dDRtyLsGdPZD7bJmQc EQMAH/X3hEkQpIfdF6sgdYg/6rIRUyNB9YU3b4qsmyv61Qt5AFX2nNaNiVb4hyhg/K/1 T43mWw19FUF3THvjRAJVbCVeVlSNPxve5ZvFiQ5G5sTzvdydzDfbsv0WjBEpkiLPk6DE nn6zEijj1bxQQQaGEHESlyIHxIxnaYgaruinXfqfMXDxX7Lj966QAuPvloCoZCNAXbPW MxhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711483591; x=1712088391; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hXt48dRidL8rW35RYbRjHW/tPWj+iNgp6Je58Y5ZAVY=; b=LW4gSCChG+ze3eo5xMuO6T/kxSzBlWTs1ZecAjqLd6UJtkkv962fHF/+5mcwumFVcf X4MLgr4LEwsciKeRF2Sgf22sSV1QLvbs31Bi80C6TibT5c5tNcZcsGXQCBFptiX8yBK0 zbWkqG492jA5RPFirnrW1Ypba081CHbNPZS6tUfrw5vnwtJ0REAwps9UhSvjWOU4CKeN 33UZxGs12tiqqg/6J+Me2nequiPYE3+ynIJ4GWI5+8GdH75Mr2m12xtPRGU5OwUt7uHV /WBbyB1uRDvuV0qMIOu3fp6eAtrOpkNvkL7FM3uQr9NBntMzHBhXMTbrwf+TUzxcqNgc f+vw== X-Gm-Message-State: AOJu0Yylwj3Zr4YvT69tSnV9pUgTDHTGZYAVTTmDGJlOdYYEb6zFBMO6 xWBj3S+8S3PMwOm97NEBC4eCSEiz8U0aSCbS+6WtMDqHFZizulEbkTBQIk6+KoWnrt5aBHMTaBV +nIWr53N5niTUk6evcQX739QCCeU= X-Google-Smtp-Source: AGHT+IEMwWmrbf02ClLpAypBNG2HXYX9kuwZTxGsGtjCx6uDmGclNQ7+sDAByyPpBx+PAx6AdtVzd9BHPxNNj/j6dl0= X-Received: by 2002:a5b:5c7:0:b0:dc6:421a:3024 with SMTP id w7-20020a5b05c7000000b00dc6421a3024mr8790962ybp.43.1711483591039; Tue, 26 Mar 2024 13:06:31 -0700 (PDT) MIME-Version: 1.0 References: <20240325223339.169350-1-vishal.moola@gmail.com> <20240325223339.169350-5-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Tue, 26 Mar 2024 13:06:19 -0700 Message-ID: Subject: Re: [PATCH 4/5] mm: Make pgoff non-const in struct vm_fault To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: xre69bxobma1iig18r9pidk9r5pogyns X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0988440011 X-HE-Tag: 1711483591-648596 X-HE-Meta: U2FsdGVkX18DTq81uIUUu7lIrj9hLPRaEHJCjt/kmabdCKOfoU5PA9TdJGSGTBtV83/XrB/LShQaT7QImKz4lhy1Y0XoZ9UQiib3xN/8AOYKcsoSV3r4yR4O/RKL/lHkTB8W127UiufS7sFFVROXKtninVytleGVDG/PPUcwC1bab3UzQsxX7t8r+jicAU18ub1c5zSg+hjcvr94fSrwWRLDZyD47oiHVvcrNLHbFRODqozl72fyMROLhYXsg2yIbVoI0U6wOfZ4IwT1bFRlrnlQdDm6sgJvCwDaOTG9L1G1YmOQb2ZKcwIJIBtnJI/zH4eUJn3eiRGqgR+1Qhd2MaZ/+Y73jHSWEOpw2V8swN50VJ9ss0Ml300Y0+T2EqCgjv+MHozBXGUNDScKq1hSnlruIv9aavgg6qQH0t3DEoMXfeUHZ6udJLvykUrO7VRpfoZcu3rrybP3iOFt43I1ko8g6XLaJgrpxGSJ03/it4LECYdkDSKzOSXzIpOntI56dIaZ+VdHOwrBFcrpvN3diaaqzke0Bzu9P2ejua1l94ChbBALnM9BcGdafIoBIXXeR5uW3SATfiA4NOnxSUgWzAA/e1m+sRQat9OdJ9ejJgEA3yhgWuKrlq6lsoskZVUj3EFx/97kdUlFUUgbeJwPWVz4spUQkb8+w2UmcUt6xmOkzSg1Kld/TkCqgGht6tGIz6swz4VxNYEf8nfSuuECT18FWn/pDMUShXUIkZS2OsjWxgMJKyyqmOoT16t7UKxB7mPvbSrWqWhO7SELiMOOu5XPNMybLVoo0fJMX6ByUZIKBQNJQCapS4E/0CzomUH/R20rLIgw8dU8h8iXj43F5pgKEz5r/xnOX/HC7gOwVoO9f1RzfDYoF0+H5db+PJXqrfHu0BylwX1D+BdyGj+JEcyI1wVjf7OXlVvHE03dOR2hxB/m8QdbREvDxEjatZRtstVfVhuYmj8tJPb5GFQ J5JjKTpc cyAFzROjh/AMdi+dU0RiGiJ9Z5/TwYySyIBplrCdCnnS1m8i7nhdDK2t1KfTL7FjvtMLO+VLEThwqBRR9QRyJYk5eeQu+zz/wE021HMaRgxeO0Y0DEeMl9AOC3WU1MsuzvhONg8lz3mEKz15NTI/T4awYYb2xfOoHGC14bUL49Bd5pfJ1EPoCJagWtZY6D5nJdQkYoGnj5xYE4zGpS1RgQsdgTEo/OctxgJgbkTfyiQdKhLxq7DVhH/EE6f9enYe5pdeFPVHtSSVPy1NNAtSgXUu96FtuYEAbGtG4PTUERsdAfTLfcwDff8spOCa8ccgV+MQN2LuzZg/gYnn515HRrXGT5yZpJyjHtd4JKgELpMWd7r+cKZjFvP8hDT8zXZ/PzrIwQB0Z8YpIhpwhKDlYq/9e9trDhzMINkridN8HozHOeUdgSvQu6LpAgndSx0Pm6zNL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 7:38=E2=80=AFPM Matthew Wilcox wrote: > > On Mon, Mar 25, 2024 at 03:33:38PM -0700, Vishal Moola (Oracle) wrote: > > Hugetlb calculates addresses and page offsets differently from the rest= of > > mm. In order to pass struct vm_fault through the fault pathway we will = let > > hugetlb_fault() and __handle_mm_fault() set those variables themselves > > instead. > > I don't think this is a great idea. I'd rather not do patch 5 than do > patch 4+5. If you look at the history, commits 742d33729a0df11 and > 5857c9209ce58f show that drivers got into the bad habit of changing > address & pgoff, so they got made const to prevent that. > > So can we make hugetlbfs OK with using addresses & pgoffsets that aren't > aligned to HPAGE boundaries? Worth playing with for a bit to see how > deep that assumption runs. Hmmm, I'll take a look. I don't think there should be too many issues with that.