From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D95C25B75 for ; Tue, 21 May 2024 20:21:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E0626B0083; Tue, 21 May 2024 16:21:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 590D36B0085; Tue, 21 May 2024 16:21:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457386B0088; Tue, 21 May 2024 16:21:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2340F6B0083 for ; Tue, 21 May 2024 16:21:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AE968A0C4E for ; Tue, 21 May 2024 20:21:15 +0000 (UTC) X-FDA: 82143522510.11.BAD5CC6 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf26.hostedemail.com (Postfix) with ESMTP id DD10514000A for ; Tue, 21 May 2024 20:21:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jyCNnpZr; spf=pass (imf26.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716322873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nF59EhesBlSvJVRjJVmRFQWYvr+BIIbxdrHdVrQNg5M=; b=lteE6Z2LSVSR5EY1ZNze2SoSt9bn+PEiVe+hIU6ucobV982Y2ItRWrmBO8g0U8eLWRrcH1 +LlgCYNJXlQsOQaDYdINFBjO49YhgHppWlwKhZkmtDl8/MGQbURkqqxoSyuCqzeG4eXqI1 lB8wdqMBWnF3Ve0IxDTHxtx50cxqN7k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716322873; a=rsa-sha256; cv=none; b=F3Hn1dDGAB4Pr6egvYtn+o04uVjcEFgL+ctmCLrlNFJPXFL4MG+Mv9O4q8k3O/9SdbtLQX y9YOw521VGExmi1Iv5KWYQaxiloXSpDrk9jyFoic0Y0wi92jtgpHgyXnIgrIyV8HOpvk/8 wZkgsBcWtrujgCwZ8IQyX4xR9T+3aZM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jyCNnpZr; spf=pass (imf26.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-de462979e00so82851276.3 for ; Tue, 21 May 2024 13:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716322873; x=1716927673; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nF59EhesBlSvJVRjJVmRFQWYvr+BIIbxdrHdVrQNg5M=; b=jyCNnpZrNZGfTzd3hQxxszagEKjMwrIGl95zXFmZnhSKtE9YtJaLDlnYZnnVihWF4g qETfdD/sKZHKcXObckRwwCUaZ8CNKUdmAtJ4nQ+oKGDuFaJi27VNMK6fwDaFBX7MSglv HZZo25dK54WAGu9ZC4MG71ge/GN2eZBUlCtacFE8Ws0LvkWUqRXrNUxZhVSa0+bcsLfy NHHg0QqRxx1G7r9gdgcsmhJbFbfyg27VQaKkY4uk5ayQDFknH286Z7VkQim7oodHDfuG 4jWRG6HTSXOkC9mjET/hQvfDa3iGuuYikCtRF0++nWnsXWA8B/kBU/5fvVWry4J5j6mn GIgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716322873; x=1716927673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nF59EhesBlSvJVRjJVmRFQWYvr+BIIbxdrHdVrQNg5M=; b=bgjZZmJJtfBkrAYmgjQzNgmB4u6DStL8Yc8wKIQMQ4NvFpbHG0px2kR0TiL/v9n6mn mydYj85L6SKNIKEzaxtxB7qGFltmo4nDhn/GcbzBGeydfv9E/Av8O4rOxom8ao4mnuTP DUnjOfELy0tizKkX2X6epmyyP5hpdeNTCp8T2kU5hBCstC1zXspyC4TCLu7JMLYHJMtH XkcXCcCZXz4legr5Y25I3cqrNlYZ1GB65rTePBcU5FGXQeaNI9eORNz9s92WC3FJtWP5 DTw/EMfRRTz2P6wnY0TCxFxVbLfXJ4BgwSa8Fiu0Iab/asM5rUoQ3zMfS+C53rmnDYTp rSUw== X-Forwarded-Encrypted: i=1; AJvYcCW5NiX1y+4hNyrn2oYcKVvhYNB28GRc+zeOs0spPHBfiZVMpLNdAFy+ZslSEbJg4MkIyXI62CqD1Wv4GXyWyvccNEM= X-Gm-Message-State: AOJu0YxtB9DAIqUgrUewBPXBTT6MGlSsuaR83UO3Tm13Ug3IVqsIm2IL 4LM2M057UFnpUpDNbNaqzk40qo4X8uDb0tvLxSML4EINO3hNzUjNks1Jx/X21Iq+923eNM4bsGl IjQ+bHoGUwXOJydeuHLcJ7+IYpno= X-Google-Smtp-Source: AGHT+IHnb/uK1WwmjM/eWZJL7IdQQLaxHw/FYfgX6iT16uiKJcbZEAFTHpco3Piz7C8Gpc4De9wzNVbS7WU5kfqv5KY= X-Received: by 2002:a25:949:0:b0:dc2:41de:b744 with SMTP id 3f1490d57ef6-df4e0d38e46mr180952276.32.1716322872867; Tue, 21 May 2024 13:21:12 -0700 (PDT) MIME-Version: 1.0 References: <20240521130315.46072-1-wangkefeng.wang@huawei.com> In-Reply-To: <20240521130315.46072-1-wangkefeng.wang@huawei.com> From: Vishal Moola Date: Tue, 21 May 2024 13:21:01 -0700 Message-ID: Subject: Re: [PATCH v2] mm: refactor folio_undo_large_rmappable() To: Kefeng Wang Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand , Lance Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DD10514000A X-Rspam-User: X-Stat-Signature: uxaaj1c6zmjnsnbx3eba6rjn5emx6byk X-HE-Tag: 1716322873-545476 X-HE-Meta: U2FsdGVkX19GecnyCCqcy5IeNVgfM0novj0OaSFNUroawrVQHQ8POeyR+Gcpp7kKhUJ4uOWY9ft5juNfQmtN5B+DK9gc+Sp0qNpW/0dnJOjySBhuF0G7QA/tMJLmmQU+i+O//I+38MPHPA5KWzrVkHX7/IldDl0t/cJ5sRIKd/NIeod7GCL8RiikhAVAvb8Jd85cSsxSC77bCSMiT5yV3A0mieK9Z7jTKVUtSgHerY4wjyv/Sz5l1x/8EKx4dh8s5ucxr+MjKOnH8kACzvWEbewJ9IKNStzM31xBj+bVCxmwNMrKjuSz6MLc8VYD+5rQANKwK1+Pbr9gpS7yix6WK472ued4jgekaUccsw8xqvV5MJ83wzELquiGsjUcU/5SGwGtKtEUnDzfjXbZSggnZwTdHWDzS/w4KIQ5kbAMRfoZnIjuuTNeIX9h0v4USCe71uF50i/gMh81Mu/bamUVUn3zKCrC71Mbir7QBtLO+Ez3tz6cmg04AtBLvl6yyLwrcx64RYjZpD8VcMGNiMYGIPEwmqO17mo+P4PgZ1yUWLEKkE4INUZTnsb90dAXxfwjX9p5s87VtCb4/JouE2/XoubHcwzn0M7wOQ3XGhY81QsIIE9u0uCwiTvN8SL5sGEaEyvwJbZWjGx4t0VcJsy/nVUqDM676difQbk4dlsiBswWiquIGNiZIsil/AF81ygPxr/2pBJX47c8yEgU1K7pwsGaEeM2WPH7/PkO/9tY512UBxnVAXx4DI9C2IrQ091+yHNl+NM270ZjCe+CtSFKbljBGevdlPmmGDkiH3QopLVAv/L5K84MgzjYHhBeL/wjX+ZUNemTa5C+rmwcR5ghuxuJ8PXe0Ff4jqDApnbLzNl0b/mHPF3aKWOSvpTHNYTXEnAwpm+kFHmggKz8AzGl4aQPekYfs3UT1f4JSwG3Q4p1tER/e/6JrsgSqvO970kvdhEQXppXujow9hB7oX8 POx47r/3 XsX8C8rcZBYdVUJwvFwIDVtmoZzOtsODD3a+y6xFFku/Ogh+VwEdozX0uR0X1oxat6o+XD3tf1CtrxDwwbyrquhqvSfRcJ8+y3tsbw0j91hU9rcgFN+hbT5Pva4hlaThyucfMGRPslRlYNXNgSvNF4M0+KVj7fsb+g5eJM/FInpVOZJWban914akZ8YZTHjEGz7zfO0OUBVrUZuVQxy/Khsg0B9XnhFzCyrrnofbRj0gJwrP30+iMAujSFDAd51Zr8asUjjyEXCoazcVVWI39NfNSfdSti9kiQCUptTFpT/WMFBd3OQjaTyCN5b2ISrbl0GFq134cY/fGvz2EJuaxm1E8LDENZJ+vQMoFwwSuDWiVpsDJs3wWQmhBV93OJy4P28VGHriyLvgT8rZTus1aQice/kGkZLYR68ioICfEitvSgmaZ98hoHbDN1HPLiXQWawFX1kavHbXdKXJZT8x7YGCOQ09VHWcOhZqZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 5:38=E2=80=AFAM Kefeng Wang wrote: > > Folios of order <=3D 1 are not in deferred list, the check of order > is added into folio_undo_large_rmappable() from commit 8897277acfef > ("mm: support order-1 folios in the page cache"), but there is a > repeated check for small folio (order 0) during each call of the > folio_undo_large_rmappable(), so only keep folio_order() check > inside the function. > > In addition, move all the checks into header file to save a function > call for non-large-rmappable or empty deferred_list folio. > > Signed-off-by: Kefeng Wang Reviewed-by: Vishal Moola (Oracle)