From: Vishal Moola <vishal.moola@gmail.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Lance Yang <ioworker0@gmail.com>
Subject: Re: [PATCH v2] mm: refactor folio_undo_large_rmappable()
Date: Tue, 21 May 2024 13:21:01 -0700 [thread overview]
Message-ID: <CAOzc2pyZPyWREtUN9g1H8YTR_FimGXrfA8Oc502dL1_Zknkgtg@mail.gmail.com> (raw)
In-Reply-To: <20240521130315.46072-1-wangkefeng.wang@huawei.com>
On Tue, May 21, 2024 at 5:38 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Folios of order <= 1 are not in deferred list, the check of order
> is added into folio_undo_large_rmappable() from commit 8897277acfef
> ("mm: support order-1 folios in the page cache"), but there is a
> repeated check for small folio (order 0) during each call of the
> folio_undo_large_rmappable(), so only keep folio_order() check
> inside the function.
>
> In addition, move all the checks into header file to save a function
> call for non-large-rmappable or empty deferred_list folio.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
prev parent reply other threads:[~2024-05-21 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 13:03 Kefeng Wang
2024-05-21 20:21 ` Vishal Moola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOzc2pyZPyWREtUN9g1H8YTR_FimGXrfA8Oc502dL1_Zknkgtg@mail.gmail.com \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=ioworker0@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox