From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC6DCD1292 for ; Thu, 4 Apr 2024 19:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 456B36B0088; Thu, 4 Apr 2024 15:58:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 406E66B0095; Thu, 4 Apr 2024 15:58:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CE946B0099; Thu, 4 Apr 2024 15:58:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B57B6B0088 for ; Thu, 4 Apr 2024 15:58:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 97F87403C9 for ; Thu, 4 Apr 2024 19:58:31 +0000 (UTC) X-FDA: 81972911622.12.5E74CAD Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 1CE01C000F for ; Thu, 4 Apr 2024 19:58:28 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e6HblFjr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712260709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kF8Wk/bDbVdtjdnPC2cq8IfcTJuriUyNYfXhq+LTLmY=; b=0xMXSg0A/P+BCrS3lfIG9d2hU/+iotGkZXsVgn3dTSjk+j2VMZD+/21AtleHadVr2QKWFj j0lqUaqcG7B8PBDvmpIuilDjkh7va9utGKSkyhtkDjxvtuZI3RuZiGXdYc9Pz9Hfiqt4ik LqrToOq2M4iUsGjvPQpQZAK08Tfjz9o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e6HblFjr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712260709; a=rsa-sha256; cv=none; b=ahCCbriI7lMZ2zWe2VUoZ8Dm+Gm8PmWOqkGgPEFkXq2Upl88o3ArHFL7woy6ODy/1qSmE/ yqGlFFWJw+T7m0ZRiUD8S56ee1osXoMsG8Ps6IgeCH/uYvg5ZSF9hKAIKMbTO3YGHufAVi CL1U5Hobkvykb3jVztQsMDsplhRUJ98= Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso1216322276.0 for ; Thu, 04 Apr 2024 12:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712260708; x=1712865508; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kF8Wk/bDbVdtjdnPC2cq8IfcTJuriUyNYfXhq+LTLmY=; b=e6HblFjrAED1ZuYalvloB0M56pmlmBx4fN16Ym8hFvUIKrQ6n/TWUXunOvdo+oBLDa kyiBeM/JS0/YryFjJPZt3Ur+cU6HleILPVlIT7zciZbi8HcM+GCGA0R77qDW+wcl6W1J 07juywZv77jB6kbhedK8frTn230Eo3gVcn6AThlanVEKehJL3XCzHWIWZ0QTDhOOfH66 o+8aVGQWLjT7WyM7IexI39QnVGYeY+cwGAETxPGbZ0sJ399HY8DcJjSKRHVb6M1jgxo/ gWZeV+GiScXzVbqu1KplnaEoaETeiOl/iGBLsnlf16dLXmnsPr0sTtJEiz8HiP8bdV/9 SYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712260708; x=1712865508; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kF8Wk/bDbVdtjdnPC2cq8IfcTJuriUyNYfXhq+LTLmY=; b=bedgTw4qH0X/6yoJT+W2MO0qa4lNUdQi4X/CQXj5Vzm38ixaqwPcVk7rLX7wPQDvEs Mo0e9AUYk4LKqNEhiv2uXmToUILiu9dCgMKJR068esc2xdRTWM0f6NVnkwVGJ7i/k6MW luPFFDEFkNijDSgZ0JaRZxfqHApiD3PH/PZOo+3LFO7ZTvxURtyhLxo4cAN2HSt3tg27 3vg6Jg93zfY1QUu1tq3MDs7AeQUM0ig8cdNE0Skco/v99US9J7i7m6+pYot08BriUUcg WwBsbuB1B8318yynO4C/X4SlkPI1SiKsfx3+ZTJCI98U/iD3LDAhGT70J1HiKMYiI0iZ KBbw== X-Gm-Message-State: AOJu0YwPSkZ2Upywb3bDV3j5HjJDYd26BriTNCgZZ8LNnzqhda/YAE7r HaAgYflbirtjCKqw5E+XBboqEbL3ohXeW4DOigSgix6BZsXksysFQdypFY6IS1uIUd2Lr8nkHWT nmWfI6aMxj6d3XsBsd9mSrP8F6Edp+TH0 X-Google-Smtp-Source: AGHT+IFsA+6EV6N8rjDFyIqOC0X0Xqyy4CqN7MNHYXALp0/wE7JP2k0qUiaIy/+bSPzQHJE6TqEbdqSmhHs/n49sr2c= X-Received: by 2002:a25:bbc1:0:b0:dcc:623e:1b5d with SMTP id c1-20020a25bbc1000000b00dcc623e1b5dmr376005ybk.31.1712260708201; Thu, 04 Apr 2024 12:58:28 -0700 (PDT) MIME-Version: 1.0 References: <20240401202651.31440-1-vishal.moola@gmail.com> <20240401202651.31440-3-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Thu, 4 Apr 2024 12:58:17 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] hugetlb: Convert hugetlb_no_page() to use struct vm_fault To: Oscar Salvador Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, willy@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: td4owpg7ux7bif1fd3siz6n5tqd4pj7f X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1CE01C000F X-HE-Tag: 1712260708-679201 X-HE-Meta: U2FsdGVkX1/53YDcVEE41tpIggDAWpwqf70P1NTwkakIOa2qoIALoK+XBVqLsWgmovQdpkblCf4xn0eicXQAwh6Y2MknpjJOprichy+CVTUzOWMQF8+ic6w77fpNILiS7NpRtK2y8ch9KHI9EStSSVCVBqyGBnFGh/mpBe+ARK4HrLlRBOIIEVMznK3wlVCU+HLFpk2WuCw9E5QLmhj41nOuBkB5Lpw5DfkViaip9/V4wWpn+OZMewY3CxmbR3VuNs+bZkgTeNvGB8o1+t3zDJ+OB7CLnPN1XkC4xLDl7U1ysiCfE4VupsC6LcwHFHvAJC5vZWsK7lEn2LIefWL3Mj2ziXKKJkFJJhs3PpFEU+1EW66+PRrZqk5UrwUxSLht2cJZO20bwlVOuyWeqZVqd47mXAv1WcL0rif0Bmd2F9wDAOsaRF71GqOQ9NoAAJqR4gY+7dEPRNGOnq3nq2ppnkSO579XdVFbZ4HiBiwM5NWacZmTHTh5/tnGkIKBtOk0Q/DOQqsi8PhUM7C7eh5Eya2jjUpsW5ringSf5MevuietruEd9QrLgKVyVDKSiCZ3vRl3cxl64pa6XIz2Qhs3MYa4YgSvgkfUcIgxjU4KbtjHtmAwraXzD/uN+rMUkBN0iroJlM4ils1jhwzyFZjPLwkMxkeponIiHbZbMUl7IeBKFZWpyadOZhum4grb8eWrOTzeI56+pNpDjsLZfW4B54kmYtwuTot7IGBEyxUm5PgSlulzGeFyXwxeZpy3T1JfupWknVShKdFJEi+6uITVcnUJSPXWc0dCl/rJH7VqH5ZmZE2u9KrzxVcD+ndEv7ckU4pFBvj00ZsrBQsbdS5HQwSwRP9VOPOBDb33WRcs7Bfks0stfo5NqwOPFEHscilvRRBYDqipbbdKdQ+Tk1UWPjBHkcN6TZPXNiSvPt42BdRG9jvfFFzoZuxG86P0twOjX0NXBkDe7GTiIKf7ZWF SDwj4QYF 1HPKE14qbfOmuB9W5dXBV4I2eVViwZ4EW9HDWX7xBv/XxNGhjPAmpX1q48Vrd3rdJptlj7SPOsEx7o8vLXgA0M3tDJrtz60pMnIF9JqEEBl78IUxG5otl3EUQp+erfbIKOIvZHU+gKpjw4n38LAOZCRWRGPTPKHaI2N44nFlrNA+CPaKA6NkTOYFeX2rmKMFeI+rKmW9zQvLws23PdSFa4Cztyu7yIUJodBj+w9FkJMXMT04o2YK2rBzDWRek6qZKXMZplbG26YwAiKRrcCcCdTzSK9rny5xTsnyRn9FMT0O2fzhJ58CZ7t1P/Nn+ShKPeGtbt2e5xdbwR6NaDsn2dEueog7/pGZ7VKGPV+sOpH+4Vy/YbEHhk6HMXpZ+ZYHSPdDmggdmQBbhhLhNuX43yotwsrT1S5l4QV7Hgkp7mkfI6lpVkxfdVLD2qLw5EZHr4lNq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 5:49=E2=80=AFAM Oscar Salvador w= rote: > > On Mon, Apr 01, 2024 at 01:26:50PM -0700, Vishal Moola (Oracle) wrote: > > hugetlb_no_page() can use the struct vm_fault passed in from > > hugetlb_fault(). This alleviates the stack by consolidating 7 > > variables into a single struct. > > > > Signed-off-by: Vishal Moola (Oracle) > > --- > > mm/hugetlb.c | 59 ++++++++++++++++++++++++++-------------------------- > > 1 file changed, 29 insertions(+), 30 deletions(-) > > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 360b82374a89..aca2f11b4138 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -6189,9 +6189,7 @@ static bool hugetlb_pte_stable(struct hstate *h, = struct mm_struct *mm, > > > > static vm_fault_t hugetlb_no_page(struct mm_struct *mm, > > struct vm_area_struct *vma, > > - struct address_space *mapping, pgoff_t idx, > > - unsigned long address, pte_t *ptep, > > - pte_t old_pte, unsigned int flags, > > + struct address_space *mapping, > > AFAICS all this can be self-contained in vm_fault struct. > vmf->vma->mm and vmf->vma. > I mean, if we want to convert this interface, why not going all the way? > > Looks a bit odd some fields yes while some others remain. > > Or am I missing something? Mainly just minimizing code churn, we would either unnecessarily change multiple lines using vma or have to declare the variables again anyways (or have extra churn I didn't like).