From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96390C48BEB for ; Wed, 21 Feb 2024 16:49:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF3936B0072; Wed, 21 Feb 2024 11:49:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7CD36B0074; Wed, 21 Feb 2024 11:49:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F6226B0075; Wed, 21 Feb 2024 11:49:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B0F86B0072 for ; Wed, 21 Feb 2024 11:49:38 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EBE991C0C28 for ; Wed, 21 Feb 2024 16:49:37 +0000 (UTC) X-FDA: 81816397194.13.CE0DE04 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 2D31DC0012 for ; Wed, 21 Feb 2024 16:49:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GpHtabdD; spf=pass (imf22.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708534176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D7DFQDZc2t2UqTzC+tGr7AXfCBBtBVxZhziymIpi1W4=; b=Hur05SkYkguwQBlj1d1e6V10Wq+qw617M1DZeobh2x19Q06U9BdMeOU6RHyZSztrBrrj29 ozjm21k/EDyADiS+bnA7bWQFrNsiy9VCJ/XcQxRyd+347GdDSmxuWuJkfSG+DMiNGEMPoq G2oD8i8ED707KkpKykvmCtHcEBCJYFA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708534176; a=rsa-sha256; cv=none; b=0UTrV12IXoACYgqnxy7OWjBJokpN9i9JlEwRN3FELX60fetdnwkmrpmTtd1G1dQBrRPLdg kLNOgay+3OnGdRESKgBFjAdBeD8gcXBOffLY2oQwe4x/b2NvaCdwPlPnwye1UVkQexY9oU 5fbmJA0H2xkVJbsiWKCdLVUnS2dabv4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GpHtabdD; spf=pass (imf22.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-607fc3e69adso59437167b3.0 for ; Wed, 21 Feb 2024 08:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708534175; x=1709138975; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D7DFQDZc2t2UqTzC+tGr7AXfCBBtBVxZhziymIpi1W4=; b=GpHtabdDSPk8Ovps9C0romg/f6KDqo9TmSJBATbOu82KVPhgxqnNWWhsrN5cpNoQNk URDFYNfogpBvcZOXAqqWJw6vA7JGgZFAP+RogrVwBpxID98lY+Fl38lCkNaH9yjt9vrI iSooAUne5mSP1syTLeEyUtP4Vyp4aFJkuZkP1wIP6bQxqu4iAUsvXY/GoYHo/RRtb4tV jMcstR8zQDV+bkiOgoJcRzowB4nAyqZaxX+h1Ot/7K3dLkxMdrBGLIv/mn8Ql3QIRlQq GeDFmJfuBKn2Rd0bJAqro4K968cnSbb3+vnp3WaoMJ71ICZXMsJoKSx71PigRl5PCxJn LPgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708534175; x=1709138975; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D7DFQDZc2t2UqTzC+tGr7AXfCBBtBVxZhziymIpi1W4=; b=cfb5qVwe1DGKSwJwf1ynbyaFIKslYMIODdTlE+i3LFjSmf0LKN8RN7wG56CkaZS2+e uGc9fmNdGKKJ6ffDrMZvAzWrOU0V+itFLcykB0FfMJLgYN5HeVwdCyhu3HpwPsZyLCs9 WPMBr+atT15mAUWtWrWxGbvQpN3i86S2Jf20/jI395D9oMKQMkjr8mUuTCXFWtB2ruIP DfB51CjGvctz1FD4wdVtSqQ1uRSzx2dFmFerWd6tiX52/Fi0ncFDo41V51ckzUaKVo+c YoXLVShmgOrciGrS6KXGMzLZr0CSzP5KjiVENxPuswOvUaoJbitGjS8IwSqnW8qmJBgy Vnlw== X-Gm-Message-State: AOJu0YyXkTP4Fnm4Pm2bUGQuwSUKm9b0uQARCGxm1+a6lgeHRyUTf1HM 8DLBGubqJD4wfyhE3u0OtirutiL80AHMnIBN+aUzBA2Fm+iygLoN5/FbF1IlNv4V0c1ISejLrrB Sn47+Dw+SebEZjg17bFPwN9vPlfw= X-Google-Smtp-Source: AGHT+IH7+elu+0mtSRdBVbREWBEpZZtDDuKz0/jM/S5iPdGbP9NoFfxKFcp7qBJeMtcGNZPdKV5x2Ilr04mEKMcZj9c= X-Received: by 2002:a0d:d602:0:b0:607:782e:fe12 with SMTP id y2-20020a0dd602000000b00607782efe12mr21487087ywd.34.1708534175176; Wed, 21 Feb 2024 08:49:35 -0800 (PST) MIME-Version: 1.0 References: <20240220231424.126600-1-vishal.moola@gmail.com> <20240220231424.126600-2-vishal.moola@gmail.com> In-Reply-To: From: Vishal Moola Date: Wed, 21 Feb 2024 08:49:24 -0800 Message-ID: Subject: Re: [PATCH 1/3] mm/memory: Change vmf_anon_prepare() to be non-static To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: rcnwhem4x9kk469a6d44n98pj9ashu1o X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2D31DC0012 X-Rspam-User: X-HE-Tag: 1708534175-449487 X-HE-Meta: U2FsdGVkX19HTPrnZ/cY4EKYG4mE5KlKnFn1k6lkbeDBOatyWuZaIOEr4ZrZCPZgkxa/b75myUcleYNJKZS0n/qH5WHntmYKPoCGmRjVtMsg5AcaoNTldU9YdqBAUf+0W8PjNPOd2vQ+fuYuAFld4F3S2TY4Up4VfX2g/BD8mhAe1Z/wqbqudOtBBSX0dzYWnKdmnEplFuica1WdlKFKXyegD8SFo4NdOV2InrVAgTjIAwMyPDP2uGqXsRENiwHKDMBCkuO1aFxtoAIP6g8pH3BLy3mzpqt2p4nnSgy5ffjtrP4Ws/oo7hf1Oz3i2+b3LUagLQDlZJCSfait3V9MmIp6r8UQ/03NmRHKAbLDxkOcQe+2KskQM5hpJG6ShLi1xF/6+okJ1QYKw3C0SBoR0Z21zdG6ncQcc/HhpR7h1CpKRBsEyBvat6pqdSQE0iv1KFDXmib91smqzTheQVGy4YhO9ndvcpmRPk7LXT2jiTr1L2GWZ22CBkJ0hWIAz2MjuiC90sScMyYAXJeKVvjAgc82VJWnpSljhziIJKc//Fab0coWQuVdTCki378LKvmGCjGEPqRVs61nxF1UdbH758osRjtLW5SiSF3yXFBJOdDybJz3YQKJFzBdA058O8TkbsyXlQPRVdhPblzkEboeS4AcJ+C92EjTYs5dUzY7So9LJC9e2kjo+dbT1PZQy+TWjnyV+kWwp6Xdez/ngHj/Kdb6nanrdb0QuctRumeEZ16Gsa5Q5Tvq6JmZM70+g+sqjISQA28mxJlJAPCtqEbrCzeg8wlZX5u8PyRDfR9UwWey/H8q1LUhxpbHiNtULdfMCrWBsBG4l2c42JPJ0wRhQp3ZZfZwza0lMIg1VuDF4Ckes65bspOQNt7nIMZ30C2B0X+a4/bqsmITaRDdhX0WgcZy9gpoHLK/AhRLS8IFJ8RiS8XJmJowwXzPhTWFStFJId5LY3erpyComqB4Mvt gz4E8PyO 9Ws+XQVRV9mPR2Feu7jEESgQbVNd/rAgMpri2sGI+811gHubPs+J9v3UEvspV5weFx5dIewo4yWGJ8H5Cu6ddd2x6r/FLv77Mwd0w8EvA0DIE8GtrYKEzBGZTQSVu1/sh+oD/HTMxnYWW9zFavO1aR7fQAp8KZIBHp5TfuNjIL8DtSqOkU47yW0rxKivVq8G1ODslhgcHg1F7DRilXGqPHkz4k17hcxzHK153FrPrbH3oe2lK9XVB56h+reENJP/jJ3QCTiGijHCJ42d3+4S3ZMvX4WxSk6DLNjlxDodJ5DPUrcwDcHtgfJ3Rb+4VqpP5/cqw2FPFVWU7exF5M6W+0CqcIJ2o7on0bvwgBKnNSAnGqOgP63dttu83hMUQ0mqD/+oRC+m4oBD7vNff1O8UcRusvB7Z4FEg/9qOlFlmxMtI/UXYVlNRGdqUwmxghudPQOLLSMs2AY82MP+fu6aQbL2XLyll88htFDOnomAypPHMV75OlzGZxA3y94wxvhKNQZPB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000080, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 20, 2024 at 7:36=E2=80=AFPM Matthew Wilcox wrote: > > On Tue, Feb 20, 2024 at 03:14:22PM -0800, Vishal Moola (Oracle) wrote: > > In order to handle hugetlb faults under the VMA lock, hugetlb can use > > vmf_anon_prepare() to ensure we can safely prepare an anon_vma. Change > > it to be a non-static function so it can be used within hugetlb as well= . > > I think the prototype for this should probably live in mm/internal.h? That does make more sense, I'll move it for v2. > > +++ b/include/linux/hugetlb.h > > @@ -272,6 +272,7 @@ void hugetlb_vma_unlock_write(struct vm_area_struct= *vma); > > int hugetlb_vma_trylock_write(struct vm_area_struct *vma); > > void hugetlb_vma_assert_locked(struct vm_area_struct *vma); > > void hugetlb_vma_lock_release(struct kref *kref); > > +vm_fault_t vmf_anon_prepare(struct vm_fault *vmf); > > > > int pmd_huge(pmd_t pmd); > > int pud_huge(pud_t pud); > >