From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED1BC38A2D for ; Mon, 24 Oct 2022 19:36:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E35D940009; Mon, 24 Oct 2022 15:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 892DE940007; Mon, 24 Oct 2022 15:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75A32940009; Mon, 24 Oct 2022 15:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 66187940007 for ; Mon, 24 Oct 2022 15:36:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1A82DC0A44 for ; Mon, 24 Oct 2022 19:36:23 +0000 (UTC) X-FDA: 80056849446.08.CD39BC8 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf11.hostedemail.com (Postfix) with ESMTP id B979640023 for ; Mon, 24 Oct 2022 19:36:22 +0000 (UTC) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-369c2f83697so87248837b3.3 for ; Mon, 24 Oct 2022 12:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OhQpzoeVGEwmo14h6MNRUCVjD46EBvZeUnXF6FjYKqc=; b=LWqs5CgYoI2G7bwSrxm509BXkoJoj4h1+NAumrnw8GvlsTUUX0V7puTaejDjA+a+Se JZxLEhr98Isu6X1gDcr7CkjpAxT8QlsxaP3cMesu5io+uJ/hiaxizHNPmkvonW4ZrSM3 9FJelnA+mhjpIKDB4wzNLTg8Yl25Bz2AgN5mLB8NjrqH3r4M0xDO+raYYo0KOsCBYSik v9TQ8VEWW7hntj+Pu46z7CX8Gt3ApfbvP2i70kguAt+Ou14BtRsnM5RXks+7xrvrVctd Sdn2UK8OpZrhDItYKOmqTRxqsyQ+eocL2ZMu5oL7CUQlM4vOpL4lrxfytXhVZRRPAgrU MCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OhQpzoeVGEwmo14h6MNRUCVjD46EBvZeUnXF6FjYKqc=; b=kKjIETEUEADerEtBn30NDnZIznkxUvd2PKXbsV/Km/UaPdwCRsi7sqYGLLQn9E6WEf JIMyejCxjN0eB63Dq2HKbAhwM/3FRMG97d9fUL87R4JG5cv5kVlO6daI0C3Y3HyTwhbB BHe93FdpwLFyi+ESRxWqu+Iv0wciuW4p2+kuDPpJZOEgAVfdJzO2DhHQuzVnu9M3CTkm 58jRKAo7YFPCawp2hT/KO+wSUWVbpHCEQCFeQ4znZhJNy/gm+mBnatX5J8vX/bpiluqH A+dGJauyuhJZ2n5ag0miSTP1Zgl+Kq7IUtxgvKJ9q10zMGHdbGF5zrTzOhs0AlspUp4o iP5g== X-Gm-Message-State: ACrzQf2G67BwYy3rMXfRHPEXUYGpc0bvH+P7LsRB0VblbWAWSUCwiSCn Ux5iamzMiXaHwjOWR2gTy5c1HO2M3Vl8iye2rvs= X-Google-Smtp-Source: AMsMyM7XF706RQysgvnkUL+jiUes9sa+q4VpOE9nihO77SiOflxp7+5NwMrZHWz4l1+JriXP7Udvq8USTVKNN8z/wRE= X-Received: by 2002:a81:71c6:0:b0:36a:5682:2c44 with SMTP id m189-20020a8171c6000000b0036a56822c44mr14328584ywc.308.1666640181761; Mon, 24 Oct 2022 12:36:21 -0700 (PDT) MIME-Version: 1.0 References: <20221017202451.4951-1-vishal.moola@gmail.com> <20221017202451.4951-2-vishal.moola@gmail.com> In-Reply-To: <20221017202451.4951-2-vishal.moola@gmail.com> From: Vishal Moola Date: Mon, 24 Oct 2022 12:36:10 -0700 Message-ID: Subject: Re: [PATCH v3 01/23] pagemap: Add filemap_grab_folio() To: linux-fsdevel@vger.kernel.org Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666640182; a=rsa-sha256; cv=none; b=g81Qt1EgStyd8eytO1xDvd6cvg98b4ULWpazUXePjT6FRcXugCGxavaLQee+0naFr2d6Uh ZQA4L+OdsY2JQkXGEQ6Y9m0d4iM6e9Vzv8Oh0YbChF5E2ZVq4G3LMiGR7Y0njGtPCdVxv2 zW/eGXRPcXzHs3CsOFeZAyKfpaoInGY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LWqs5CgY; spf=pass (imf11.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666640182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OhQpzoeVGEwmo14h6MNRUCVjD46EBvZeUnXF6FjYKqc=; b=j0qIVG14MlRiF3EAtJhrrEg2H7aEr4Snr8gSP3+QVLpEGlExG5WTbNMCQ3khgTFiX/I+PL PoJ/QvI8M8azZjpBRsUAj5HyWB1yjeZ7+4YP/TAAff7jYqb5nOM8mVHbulqqCVH3i+le8n rYmIvHUwrWQaT29vrn4ZrA/Kkm8Lh1M= X-Stat-Signature: yftn4m8xupzphpi8hp9tbu5pkigo7z7p X-Rspamd-Queue-Id: B979640023 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LWqs5CgY; spf=pass (imf11.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666640182-32059 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 17, 2022 at 1:24 PM Vishal Moola (Oracle) wrote: > > Add function filemap_grab_folio() to grab a folio from the page cache. > This function is meant to serve as a folio replacement for > grab_cache_page, and is used to facilitate the removal of > find_get_pages_range_tag(). > > Signed-off-by: Vishal Moola (Oracle) > --- > include/linux/pagemap.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index bbccb4044222..74d87e37a142 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -547,6 +547,26 @@ static inline struct folio *filemap_lock_folio(struct address_space *mapping, > return __filemap_get_folio(mapping, index, FGP_LOCK, 0); > } > > +/** > + * filemap_grab_folio - grab a folio from the page cache > + * @mapping: The address space to search > + * @index: The page index > + * > + * Looks up the page cache entry at @mapping & @index. If no folio is found, > + * a new folio is created. The folio is locked, marked as accessed, and > + * returned. > + * > + * Return: A found or created folio. NULL if no folio is found and failed to > + * create a folio. > + */ > +static inline struct folio *filemap_grab_folio(struct address_space *mapping, > + pgoff_t index) > +{ > + return __filemap_get_folio(mapping, index, > + FGP_LOCK | FGP_ACCESSED | FGP_CREAT, > + mapping_gfp_mask(mapping)); > +} > + > /** > * find_get_page - find and get a page reference > * @mapping: the address_space to search > -- > 2.36.1 > Following up on the filemap-related patches (01/23, 02/23, 03/23, 04/23), does anyone have time to review them this week?