From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAF9CDB47E for ; Wed, 18 Oct 2023 21:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7CD58D016D; Wed, 18 Oct 2023 17:31:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C04D88D0016; Wed, 18 Oct 2023 17:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F318D016D; Wed, 18 Oct 2023 17:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 95A798D0016 for ; Wed, 18 Oct 2023 17:31:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 69230C0F5B for ; Wed, 18 Oct 2023 21:31:13 +0000 (UTC) X-FDA: 81359878026.02.10C266C Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf19.hostedemail.com (Postfix) with ESMTP id A587F1A0023 for ; Wed, 18 Oct 2023 21:31:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HQvxbX0P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697664671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CVV9GXKQ+N2qix8ALbC2Bb+IYqanWuQiRGi4P2zW/dQ=; b=L/IZTOGjpMKtZz4isjXDoodVaifPaKkN4tr9Wz7ukiKXiErsnflDDhO8mSmcGQB+DwEMVZ ryjN3eIQpYXnHVhNy6p1b92LONt1uahuqqt8aCH2HWHAdOu1ohf8T+hocJPVSpg8MoGa+s McGYZeQmVWLcMQwYmeX0zaJklVqaCcA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HQvxbX0P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697664671; a=rsa-sha256; cv=none; b=152+CYCtaUjCJZGc3l9GbX1e13N8w3HqbLt/dyPM2WMTuEK6gwK1sGZp3SpzBE+JtYrH9u ZdyN5e6FIzEy/0Ynw19gOfB5gnZ0y625T0DlvVsmRjl26jM2SHnPbE17Sj090iYuh7oqfc eYsEquTWUTtWspey1avGZQIn5Q1NwBY= Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-d9ac9573274so8155683276.0 for ; Wed, 18 Oct 2023 14:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697664671; x=1698269471; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CVV9GXKQ+N2qix8ALbC2Bb+IYqanWuQiRGi4P2zW/dQ=; b=HQvxbX0PXVNqXQsdPneYJeopDs1QkKBd6/yJLxbHEAcxSqgiihXEk0J4tQXCxL77uD OJ/vvDTwmqexM1pVTd9IHi4bRYl0mvaxpSDbt+txoGYkgcyJ0//HeavyzVsv/quZ6/d8 qcgqTe/zOuFPT5FWugSG7wZ6c+6hLBqcuSJImsvDhKjxdW9nVME9Dl4B9gcS2+ANtckX vlwdzZg5BBhEg8n3N/2BvzYRe3BXtCVlWzDzFdx2Q5/Q4c2GtNzi3ufULJ7MmjjLorVS mIKamVUP0g2TKqFmQSrZJ1A0cQg11qMTWojh+PxPo/vZAnHcTgCBOg1SHhw9XSfNSQ4J j5QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697664671; x=1698269471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CVV9GXKQ+N2qix8ALbC2Bb+IYqanWuQiRGi4P2zW/dQ=; b=LdOvIYXoDoUcGGYruoPNnNEOo91b5RiGpv62f2kCPPDt1cD69Boxunyk7JtDLkKyHU J8ZjWDrOf6V7vdGaneSQuFVMJnEbGiMbwBY5DrzTlxQJWNQbUCYDoBsdAVSJgbZBHrdO jqo10Em2VMcQDHkDd+O0A7khzqo+h/lo30Xl906X5dnnaUVZ7cwXYnhkwnuCbcwYdTjp SXmnrp3cZA71o9/GVIjC1+yyB9TNKRdZna2X7T3EaeVRWJFnpNIYvxom+AbpxjjLEvqT 6a3WgnwBDjFqaLA62g3MM7ayjN3eqFnJ3wQuD7Hq7NbVEli102UZtG1kcyhHG7fib9E9 89ag== X-Gm-Message-State: AOJu0YxiqyjRtgeqpSM4wt3+JZsGCdvT+zqZqw3scyEK9qBUQ/+teZEC MjKKRD1CC3xfKpqBGpjH2pfJeAhT1pmgaEksriA= X-Google-Smtp-Source: AGHT+IGBKNb83HmO9xOIkZ+1W9AKH7k/4bolm/iWgmyRR57YGXN5rYVAZ2QOTHznIt8x1XiLwSlHK3MeeGZkQ95vYmA= X-Received: by 2002:a25:8f90:0:b0:d9b:90bf:e74b with SMTP id u16-20020a258f90000000b00d9b90bfe74bmr612637ybl.7.1697664670622; Wed, 18 Oct 2023 14:31:10 -0700 (PDT) MIME-Version: 1.0 References: <00000000000085670f060802a9bd@google.com> <20231018134858.e0c6445045f5f6c3954f6a62@linux-foundation.org> In-Reply-To: <20231018134858.e0c6445045f5f6c3954f6a62@linux-foundation.org> From: Vishal Moola Date: Wed, 18 Oct 2023 14:30:59 -0700 Message-ID: Subject: Re: [syzbot] [mm?] [fs?] general protection fault in folio_flags To: Andrew Morton Cc: syzbot , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: e5gnpojsyx1dzbyo57anqd37myrp83tz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A587F1A0023 X-HE-Tag: 1697664671-171301 X-HE-Meta: U2FsdGVkX19sxlxv3DJSRqCsHgItmeR/YMVzmbOe93965YzVkWUnvvaWqoXehLNc2GBfTSxGcy9PyCXsjaVzlESJ2NKDDImQ7RT9RInUpndMt6Un9Zd8HILb8mOmDXvsCHKKU/wMq8IJmtaFX7VNsy4si248zIhVQN8Nl4RWDMwQw941pZVyBX8TOcuX/XvP+zD8rKg+YaK9gI9kZxzmaP+hNOvMKUIh8tO86WW1e/muwepNWpRud/62AHwNuQ6XlKackq1igNVQyeBIx84VHlOznzHCOPoYHCDRwNtlfBRuCrrEhDTV/Ts6Wq5H/kY/LTgke9CfRHjgIfdD0Y2/ltaLEFiNCbtXsKtPa7RbsUD5n9xnOeCHBjwJj4wPKw05lqKntLzFYKrTwRkIUeh/aIg/EHuurT7sK5jxVZ0ZWrhJHxTgj/sdXIafCQJ+QFoSp0JufUQfyUeYY+vt/O1eMqDIkR2p40+PKhQr8BBhqS26AJgMdO73LoF5JmXCOMuEsdsVxsvb7JehdQffw1LviiCsS3ViS/lhdtqlPWCzJmvMUy+wZU+vF1EnGUqFIfofsofcJ/MYquQW0KkZP9OlE2xI0u7NhYfmpDOQfoArCXq6q7Jb2S3yQsXi6vaqe5GuDLLY692Cg1Xy+CQOylP0HZnq4gcCsS4xIFCe3SiMz3fA2gaDBRGzbe6P7QA3ujgeYG1m6V5R9kwUg3tiW97MWr6UfMXo1wWfNxnlFqvmEZss/LFhzybfpoOizna0+e3Ldi4AyqAqvO6pSOQ0l/Tu24q8YkMoZ9rc1/jCCDpIobMB0aJLGjEV35o4vCmQA3yBwK/grxBctLDfAkhm9pZt3KezCTMG3zyteRNT1RqAh7vW4hOs+6W615fCAL9fE1YXB7brSHZSobizDGZ9jdjxE7z1xmyn6KLG+0Fh0Ps53krsCUQ4tahIJQ/fhehu8JldLZXK0WoJslGtc1SoKkI TQRgqTnx RMapAJSC77ufcRtzd00t2dnB2ytyEV+WdmN4ByYF6PC+9xI3Mam/EpKI6DdkzM0ZRMjHE9wrFIL8khl2Tz1NwrN18xhJBvAzlfHAp/8JAUBwJ+v8jFUTBdwUQQ3dpMqEaFPKj2cmSEHjq1SEDhsEbWHtQ2/5yCqVOwgFajt896sPPTi8GPT8lAi2XXU6uryjeC/u1it7m/6w2aSxZXKxaKT3EJ/aGE73m5DbjOS0+RqamcgSTW9EitO1ViUBzJciVYFquMZgAkMsIQmjUnYbz2OPMT49VqcKfEpN534ewkLAUTgz5VviGq8ntGvezOfUzQ2zWyGoyv+2rtL+Gj+NxwLX6QPtFY3sMIQaKH3gX8SN9+Fdwm0NZsPRV9l9ozLN1YvNEGSsFpZSZl8UokDDU9AEYHYtpwFIOF/iwRkpQrJ9vZueHhFCEv3Kc8IpOKX2jo+o7GUKZsvICLuqli3IWII2s/Ma/7lF+c28wgnC+iKtDOnT8ark5QcNSI3w2I98I+ndwSs6nzgN5HfogCmQDnUrE/DIsKs7Ylgs6rkT7PvPGHdY4975vHfcTwiLQwEQ+a0USvQlkOiFaLCgeEATYSZHygURVuTke1EsJtnk5WTdyAL6LbxSxhFP1DYglZTsCAYTc8MnDI7n5td6kQbiirx3mJpilClFITRP6++ZozhtoGpZ/Ex60RJshVozcswdmmsIsnGacTUp78f8pwW7ImVhyDoQjaFkhjq0wHRygaAYYF7mLYP9iBAjyQpnulmWqhiBpxD9YOGgJJA7pioY10e6XxU6yPrnZMGe3oFIUEUdhD1TJbqC37hJPIicKPz9qKWQAtxU+0kT4X3tEdkeRy+OkgyRH9oy1dcespUAm59mwkJJD+QpoHpOzZSryHzUnLwLSzfg1S8Yer7DWjccYzBmcWrWJCd+8hULYNZMC5QT+UhxlzFUFm2APLxbZ8kel15XTjZ2igarfORCdAVKuCplk++ja HjhxurbY qieloNZAMQrEvU8+3qwI3SE/AhTSoqTYfFaPoGURMsj5qS0p+39xjnW1vOIil4S3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 1:49=E2=80=AFPM Andrew Morton wrote: > > On Wed, 18 Oct 2023 12:29:47 -0700 syzbot wrote: > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 2dac75696c6d Add linux-next specific files for 20231018 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D13858275680= 000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=3D6f8545e1ef7= a2b66 > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D1e2648076cadf= 48ad9a1 > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for= Debian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D17543ee56= 80000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D101f5fe5680= 000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/2375f16ed327/d= isk-2dac7569.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/c80aee6e2e6c/vmli= nux-2dac7569.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/664dc23b738d= /bzImage-2dac7569.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the co= mmit: > > Reported-by: syzbot+1e2648076cadf48ad9a1@syzkaller.appspotmail.com > > Thanks. > > > general protection fault, probably for non-canonical address 0xdffffc00= 00000000: 0000 [#1] PREEMPT SMP KASA > > KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] > > CPU: 1 PID: 5710 Comm: syz-executor155 Not tainted 6.6.0-rc6-next-20231= 018-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS= Google 09/06/2023 > > RIP: 0010:PageTail include/linux/page-flags.h:286 [inline] > > RIP: 0010:folio_flags.constprop.0+0x21/0x150 include/linux/page-flags.h= :313 > > Code: 84 00 00 00 00 00 0f 1f 00 41 54 55 53 48 89 fb e8 14 2f a4 ff 48= 8d 7b 08 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <80> 3c 02 00 = 0f 85 00 01 00 00 48 8b 6b 08 31 ff 83 e5 01 48 89 ee > > RSP: 0018:ffffc90004367968 EFLAGS: 00010247 > > RAX: dffffc0000000000 RBX: fffffffffffffffe RCX: ffffffff81b7e126 > > RDX: 0000000000000000 RSI: ffffffff81e49d1c RDI: 0000000000000006 > > RBP: 0000000020200000 R08: 0000000000000005 R09: 0000000000000000 > > R10: 0000000000000000 R11: 1ffffffff1976fb9 R12: ffff88801675b900 > > R13: ffff888025f9f680 R14: fffffffffffffffe R15: 1ffff9200086cf3d > > FS: 00007f2f2a17c6c0(0000) GS:ffff8880b9900000(0000) knlGS:00000000000= 00000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 00007f2f2a17cd58 CR3: 000000001bfa0000 CR4: 00000000003506f0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > folio_test_head include/linux/page-flags.h:790 [inline] > > folio_test_large include/linux/page-flags.h:811 [inline] > > folio_order include/linux/mm.h:1079 [inline] > > collapse_pte_mapped_thp+0x42d/0x13b0 mm/khugepaged.c:1512 > > Vishal, could you please take a look? Yes of course. This looks to be caused by filemap_lock_folio() returning an ERR_PTR() which wasn't an issue prior as find_lock_page()/pagecache_get_page() was checking that before returning a page. #syz test: https://github.com/VMoola/kernel.git 34d60af8cb66d6f582c1aeade01689e94e8a0092 > > madvise_collapse+0x875/0xaf0 mm/khugepaged.c:2761 > > madvise_vma_behavior+0x1fe/0x1d00 mm/madvise.c:1086 > > madvise_walk_vmas+0x1cf/0x2c0 mm/madvise.c:1260 > > do_madvise+0x333/0x660 mm/madvise.c:1440 > > __do_sys_madvise mm/madvise.c:1453 [inline] > > __se_sys_madvise mm/madvise.c:1451 [inline] > > __x64_sys_madvise+0xaa/0x110 mm/madvise.c:1451 > > do_syscall_x64 arch/x86/entry/common.c:51 [inline] > > do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82 > > entry_SYSCALL_64_after_hwframe+0x63/0x6b > > RIP: 0033:0x7f2f2a1dc7a9 > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 01 1a 00 00 90 48 89 f8 48 89= f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 = ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007f2f2a17c238 EFLAGS: 00000246 ORIG_RAX: 000000000000001c > > RAX: ffffffffffffffda RBX: 00007f2f2a266318 RCX: 00007f2f2a1dc7a9 > > RDX: 0000000000000019 RSI: 000000000060005f RDI: 0000000020000000 > > RBP: 00007f2f2a266310 R08: 00007ffe616d77f7 R09: 00007f2f2a17c6c0 > > R10: 0000000000000000 R11: 0000000000000246 R12: b635773f07ebbeef > > R13: 000000000000006e R14: 00007ffe616d7710 R15: 00007ffe616d77f8 > > > > ... > >