From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA89C001B3 for ; Tue, 27 Jun 2023 19:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 168408E0001; Tue, 27 Jun 2023 15:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F1468D0001; Tue, 27 Jun 2023 15:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAD4A8E0001; Tue, 27 Jun 2023 15:56:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D6CA58D0001 for ; Tue, 27 Jun 2023 15:56:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7ED6080844 for ; Tue, 27 Jun 2023 19:56:40 +0000 (UTC) X-FDA: 80949585360.04.E987E2F Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 6BA1F4000A for ; Tue, 27 Jun 2023 19:56:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=f28I8lHA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687895797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zdquro6/1dmVZnYjtrQgFcMxkU4TUJVZmkWoLqAkDfs=; b=zsh/jTG1YF6hdCmWHvol1+Ao6iG0KB3Y896faS/osamXfXtlSg8QJhPH4xGZwp91Cb52lO Kb91SuLZPnADBOuFurZYss+XV3La1ojqsDwmNVx/CSkW9KjDLRBYn+LMU4NOZdpQCn2RK3 0XxvNpUATW7HLBNhy5MnzjBsSB65QKA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=f28I8lHA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687895797; a=rsa-sha256; cv=none; b=NkgdfncH6t+4V6KJw1oWhy+LS9z1HMK1xWmV+oq2MTzcbDtW7tC2xCDs1e7S7MB5xrTM4/ ujxiMi00lrsFVh/LKfz696Jswcn9DSu3zOcRsvvswHSYZ/PHRr+doG0Dr/rYLfb4P9fSnS MGd7Sgg9rs23CVB18uzOtMHRBTIo1ME= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-57703895bd5so1987667b3.2 for ; Tue, 27 Jun 2023 12:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687895796; x=1690487796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zdquro6/1dmVZnYjtrQgFcMxkU4TUJVZmkWoLqAkDfs=; b=f28I8lHAi89ozlaNg/BctKdKMs3ZV6m8KXjBDM6pClsFtWadf95y0x4g3i//E8BwZz W+z8+saIIFbmoUgBUaIpSnUEoRcLDnuqLYQnOFRS+j34fc48uptWzZzEtuGsHAJp24eW schrHDJX1LmM4MqcKy9Kl1+LnP3eq11QJcl+8rxobGaBQBGKgLHNc4OHDPWjyNPyHr8O 3NCVuR4QFNH+Qpn6H6NXaags2ruLb1/5mkhPFAz5CmyBZqkztlzk4kjRiIcxN74282q0 ok16c0PiSUSoXbXu9Py6nAmtPZ8zTkEwR31ZaDkNSc5taFwAdZNAWg6IT3kt5o5vZVZ6 A8Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687895796; x=1690487796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zdquro6/1dmVZnYjtrQgFcMxkU4TUJVZmkWoLqAkDfs=; b=hDut2vzkyCjFG66D2UmrMrwP1V/DGeiMmb3yXo81EMsZK1Ka9QcsoU+dbgvAi6yo4p H/efWccNpmecTJ37Hnln3qZFiMx6bNS+/uYeSRYqxsdGGHN29v6sXes+PU5oTAO42aWh lqAact2QUE3q1r6yN9l+Chn2UdbOQeNOO420KGRqMEZy/SFdSwx7YM5wnINLF7xqpiyY CokVC1hpFG9efZbaisYUmGRU11UeSp6ldCxunmtQEA60aLN5nu/2j9Ff+AglwX89EwiD z9cZO40PAuFbIZGt1CUyFx5yy4DdsLaO0d4887gn9rH79AKKIFVoFexy+NgTT6+yqkq+ gjDA== X-Gm-Message-State: AC+VfDyvyf+Njj6N50y0ZHthTZdGlfk6ijmGan1xghOTMkHggPy6AtCa RjSN/BG3SSk7AxfpG0RTfd0AyliLryxX0UMGUpA= X-Google-Smtp-Source: ACHHUZ5reIcGnTN97W0IND8v2qM1C2Qu4uLolES6NdKMr/CmT1WqgUFXujo/fo7+ykti4Dwr2zsHLXj/ugW36Uy1oLg= X-Received: by 2002:a0d:de45:0:b0:576:e678:21d6 with SMTP id h66-20020a0dde45000000b00576e67821d6mr4351768ywe.12.1687895796450; Tue, 27 Jun 2023 12:56:36 -0700 (PDT) MIME-Version: 1.0 References: <20230622205745.79707-1-vishal.moola@gmail.com> <20230622205745.79707-27-vishal.moola@gmail.com> <13bab37c-0f0a-431a-8b67-4379bf4dc541@roeck-us.net> In-Reply-To: From: Vishal Moola Date: Tue, 27 Jun 2023 12:56:25 -0700 Message-ID: Subject: Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs To: Guenter Roeck Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Dinh Nguyen , Mike Rapoport , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6BA1F4000A X-Stat-Signature: oy7udx7nr7sqpqg8fmcr5aw5g4poo5oc X-Rspam-User: X-HE-Tag: 1687895797-117618 X-HE-Meta: U2FsdGVkX1+7GR95sikT2TgcQll9z3R6MAwhHPwfi3GZ4fisFIuGMr+VelPO/P9WdInL8+eWMsAvr1U0KLAtxfPe6ZJVdIgqmfkIgvtgeDsRW/Jf2sEMkIec50PXQgL0hH0d3WKxK3wiAdyMAI2r/lRfbptCPEX084Qp67Mvip9hNZ+41QA/ahbsqYvPYdzszc9iG0n0B9bU39vgYvMeZaXRZliHm6n25yPLauG6MFRKXIwCjQYj1VXxiNeYHlDUJYJIjMjG3dkUjJB0XcGzd8MAPCFl9O9h++reoMvaLke3xpLsQim63hecmhBQ86AqdTRp4ad5gMkcVW5dJU7zumbI9J0+uBS7BRctfjjNU/yCTk2u7XWfDi2uw2sLm4mSfGVa6updNO55PCoMQdjQr9b5kvE4YeyAFr5M5lPBJRuEOCqVBP/8no8N5L+Jz681o3eVvoVn08ucJhm4PygXwHhhfAp7BOwm92p3zlPJOH+T+Tm5dOxaLZe24rc76IZv0sx4PlzWULxSjAiVmG0Ej7GrJO6zE+M4O9YOafqvOUmT/Qq4kZ0rOt1ovA8BO17iqPUR9VT5BA8zMKk5wRYl9OkgQJlb+wzDTFtYhVlp/hTZBY4QN4cf9CD6jYXP0uD4vGnTqb/NGfN6HssP+4TAFxInLPSZr3xpoXwuJU+Fk70jpLFQ8LLoyzxsZHpskgkOMhV6cc+xOfP92KkYilGWP+NXx5iORaWfc1+KtsCfrItLv2BxKFxgCeg0bTq6LJD6F8072Taheinhuc3cCgKdXaA1rjwwjV9GejC23aI3hY1OMtRpRHdKtg2kQHLFe9f8DXJG4n/ek/BSn8Hd+mesbisckh66lm7NE6CLAKQLFi+mHdLJ7CbvUTvvoYo5XbNrL2Xvht5eQ5mwHUp7p2Frt2eulUS+sDvpvINmcX9UchwtCLt8poWHxKk/z5VlVLdLOlXqQ9KgD7xmq0EGcDO nyidzmWH W7iSjZuga4bSyRCgEtx3eeNVD/EZcaPlcUTt0fuvce9xFyFqphWpmcrMdC/Di5CSxSTLmJboT31tNXYOib7sIG4bDY+iZpCMjPD5b7t/CgkXJpPZo8nVQHilT22doT6xP0ptjYI8IF6Ofk2nPGzBfbvMkpzG7K0CEXGgnOMoNGCzMAGSTqq51Xfo8Dong5eBd4i/zfcrENC77iw3bvp+Qx7W8mRsZNv//CYXhU0XXgKm5UAiPx6/23uuPiFxnKhJ5ZUJ+uvtvIY42MmmLIYiKdin8IPrlwJ6wRgPCIkMTQLn8MGdX1Uz3pK3ZZbKvqu0XXo4tTYcD+Vag0WtwozKgMvFtQdQBHJh66SKInVpKvDSnNTBxCFslltt5IDGzusQgdGBzhb6ZPDHopL6YVC2NR5dgwaW9+GL5mUlm9+FjmvvDgvFi1NHzGa9k+Fu6JGgIli5QIRnKndldoHgHXTP/wnAAsAHLGoV7VdWxNfOo9uj1eIMF9dWld6bcDbE6YwCr2KDXLg09tb9+cDNG0s/BPfDZsxSKyJfy1fn85YZ/JNDuOkkMgYtX7tFS43FWnoH+TLzHcM1Rmzu32sg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 12:14=E2=80=AFPM Guenter Roeck = wrote: > > On 6/27/23 12:10, Guenter Roeck wrote: > > On 6/27/23 10:42, Vishal Moola wrote: > >> On Mon, Jun 26, 2023 at 10:47=E2=80=AFPM Guenter Roeck wrote: > >>> > >>> On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote= : > >>>> Part of the conversions to replace pgtable constructor/destructors w= ith > >>>> ptdesc equivalents. > >>>> > >>>> Signed-off-by: Vishal Moola (Oracle) > >>>> Acked-by: Mike Rapoport (IBM) > >>> > >>> This patch causes all nios2 builds to fail. > >> > >> It looks like you tried to apply this patch on its own. This patch dep= ends > >> on patches 01-12 of this patchset to compile properly. I've cross-comp= iled > >> this architecture and it worked, but let me know if something fails > >> when its applied on top of those patches (or the rest of the patchset)= . > > > > > > No, I did not try to apply this patch on its own. I tried to build yest= erday's > > pending-fixes branch of linux-next. > > > > A quick check shows that the build fails with next-20230627. See log belo= w. Ah it looks like this one slipped into -next on its own somehow? Stephen, p= lease drop this patch from -next; it shouldn't be in without the rest of the patchset which I intend to have Andrew take through the mm tree. > Guenter > > --- > > $ git describe > next-20230627 > $ git describe --match 'v*' > v6.4-12601-g53cdf865f90b > > Build reference: v6.4-12601-g53cdf865f90b > Compiler version: nios2-linux-gcc (GCC) 11.4.0 > Assembler version: GNU assembler (GNU Binutils) 2.40 > > Building nios2:allnoconfig ... failed > -------------- > Error log: > :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] > In file included from mm/memory.c:86: > mm/memory.c: In function 'free_pte_range': > arch/nios2/include/asm/pgalloc.h:33:17: error: implicit declaration of fu= nction 'pagetable_pte_dtor'; did you mean 'pgtable_pte_page_dtor'? [-Werror= =3Dimplicit-function-declaration] > 33 | pagetable_pte_dtor(page_ptdesc(pte)); = \ > | ^~~~~~~~~~~~~~~~~~ > include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free= _tlb' > 666 | __pte_free_tlb(tlb, ptep, address); = \ > | ^~~~~~~~~~~~~~ > mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' > 194 | pte_free_tlb(tlb, token, addr); > | ^~~~~~~~~~~~ > arch/nios2/include/asm/pgalloc.h:33:36: error: implicit declaration of fu= nction 'page_ptdesc' [-Werror=3Dimplicit-function-declaration] > 33 | pagetable_pte_dtor(page_ptdesc(pte)); = \ > | ^~~~~~~~~~~ > include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free= _tlb' > 666 | __pte_free_tlb(tlb, ptep, address); = \ > | ^~~~~~~~~~~~~~ > mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' > 194 | pte_free_tlb(tlb, token, addr); > | ^~~~~~~~~~~~ > arch/nios2/include/asm/pgalloc.h:34:17: error: implicit declaration of fu= nction 'tlb_remove_page_ptdesc'; did you mean 'tlb_remove_page_size'? [-Wer= ror=3Dimplicit-function-declaration] > 34 | tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))= ); \ > | ^~~~~~~~~~~~~~~~~~~~~~ > include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free= _tlb' > 666 | __pte_free_tlb(tlb, ptep, address); = \ > | ^~~~~~~~~~~~~~ > mm/memory.c:194:9: note: in expansion of macro 'pte_free_tlb' > 194 | pte_free_tlb(tlb, token, addr); > | ^~~~~~~~~~~~ > cc1: some warnings being treated as errors > make[3]: *** [scripts/Makefile.build:243: mm/memory.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [scripts/Makefile.build:477: mm] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [Makefile:2022: .] Error 2 > make: *** [Makefile:226: __sub-make] Error 2