From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF40FC433FE for ; Fri, 18 Nov 2022 07:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3B26B0071; Fri, 18 Nov 2022 02:28:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 162F66B0072; Fri, 18 Nov 2022 02:28:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051946B0073; Fri, 18 Nov 2022 02:28:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EE0826B0071 for ; Fri, 18 Nov 2022 02:28:33 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C8E851A1030 for ; Fri, 18 Nov 2022 07:28:33 +0000 (UTC) X-FDA: 80145735306.11.B499F6A Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf12.hostedemail.com (Postfix) with ESMTP id 784D740008 for ; Fri, 18 Nov 2022 07:28:33 +0000 (UTC) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-37063f855e5so41969217b3.3 for ; Thu, 17 Nov 2022 23:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fIq4B8jpHjtTC9rO6U/0HlBjNi37g7n6MUt5O1wpmQg=; b=dm0GlyXu/u1A7mUk7Kpzb+S9xN11ABAeHAmQ2R3TECYaO4UN8w7kl4nBwhGUMUASxx te6IE0BM0UWzsm64/VfhthqpIEX8zbzCz/09hxY4uBcInKWKdv2uBzWA29Yn0SxS03Kg S9JZQaZVmf2WCVlkinYCE/wuUriZmhJqhpazgkslkUvfx+zfWDqooBKhJV7X6Tvr1Ymq BjbjUu7DaLLtzdykxn8SzyctnXGsiB/6VL3bdhJCpEsKpVsVPAICFrMO4rPrxSaqN1Gm MBStvVruu7+oqD1a8AvZqm+CRqsJjq9Bci/HjCkvO4W6XOL1U3iv4KHZiZHGXFBtElZC k6uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fIq4B8jpHjtTC9rO6U/0HlBjNi37g7n6MUt5O1wpmQg=; b=5acdGqjdi6G2+gan3EO9Hiiq1g30xnJRdHUdlOWq8DQZs0RBcpxbiJ8XUE+NaQ7s6q VX8MOHo4suOb8OdPWYIbXukCB4uyoYTZ6lPx+Y8iXC5T5M+Xuv6MfZcGaaJizG0Twawf CH8CdRZDwk8fR4YwIbcV+l5q6tWjo/G4NxhVKN0rVoYbmVZUvfWmsl775Kc5I0Cftddo VyqCF/WuDhBW/etu4cS3vG2MFuUGg5lPP8Ujd95eO7aFvJY2b261N+iUsGo+KHl9XD41 4G2H13pju0yjDtP6MsTQhlD62i3CaObtkeyAM+ZqaYWkJb8P5gM4mmoyVDk9jqQGhZz8 KnAA== X-Gm-Message-State: ANoB5pmO4D/5UiRobfcMIIIWdCJScEnx6DwhqNk9weUXsH4QAnF3mbrp U0rIs7bFzlQDBBKPr35AOvGdrW6nZPunwdfHYEPCC3Na8jE= X-Google-Smtp-Source: AA0mqf73sdMy68XJbQb5H8Jg1dOLOXOpr9ua8cw7FhlPmjQN4idUvFlr60RJSMN1hAftvDfbKPSOXxzi93FI47+WTgY= X-Received: by 2002:a81:c206:0:b0:38d:c23a:c541 with SMTP id z6-20020a81c206000000b0038dc23ac541mr5412773ywc.109.1668756512447; Thu, 17 Nov 2022 23:28:32 -0800 (PST) MIME-Version: 1.0 References: <20221118021410.24420-1-vishal.moola@gmail.com> <20221118021410.24420-2-vishal.moola@gmail.com> In-Reply-To: <20221118021410.24420-2-vishal.moola@gmail.com> From: Vishal Moola Date: Thu, 17 Nov 2022 23:28:21 -0800 Message-ID: Subject: Re: [PATCH v2 1/4] ext4: Convert move_extent_per_page() to use folios To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, naoya.horiguchi@nec.com, tytso@mit.edu Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668756513; a=rsa-sha256; cv=none; b=ZaJkVWYuh1sXr3s2GFHet66NpQtu3UHdBlMbNv/tDpVS7cwGGZl+v740Clm4rAfc+ctC+F J54C/mif3iX7l0RQ7eaRqBgdeATdxqrqD4Q5NGaAHwerXGIbwC8Ji3S2M67VaBRW+B9VFL L1MZ+RR3DJdSj+NqUdwr27tkaJqbOEU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dm0GlyXu; spf=pass (imf12.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668756513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fIq4B8jpHjtTC9rO6U/0HlBjNi37g7n6MUt5O1wpmQg=; b=GrQFgUQ6KMb5a2asksCO6TMd25jmBp9DJpyj25HJe1JLnjZSYlMrOeJ8n5NSQ/LGFudIBg yTs2pMwT9rhgvmjaT8/P/Vse8zQ7Xd+jLCz2MYk2/gXTJGf9LGg6eUDeIuzxttbGftAQIe vDftscQzQTQ8ZWt2BEszn2iDXjRkldY= Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dm0GlyXu; spf=pass (imf12.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 784D740008 X-Rspam-User: X-Stat-Signature: zj4n4gufdwq4ipcn7xnccaptm3bgcwq1 X-HE-Tag: 1668756513-205629 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 6:14 PM Vishal Moola (Oracle) wrote: > > Converts move_extent_per_page() to use folios. This change removes > 5 calls to compound_head() and is in preparation for the removal of > the try_to_release_page() wrapper. > > Signed-off-by: Vishal Moola (Oracle) > --- > fs/ext4/move_extent.c | 52 ++++++++++++++++++++++++++----------------- > 1 file changed, 31 insertions(+), 21 deletions(-) > > diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c > index 044e34cd835c..aa67eb240ca6 100644 > --- a/fs/ext4/move_extent.c > +++ b/fs/ext4/move_extent.c > @@ -253,6 +253,7 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, > { > struct inode *orig_inode = file_inode(o_filp); > struct page *pagep[2] = {NULL, NULL}; > + struct folio *folio[2] = {NULL, NULL}; > handle_t *handle; > ext4_lblk_t orig_blk_offset, donor_blk_offset; > unsigned long blocksize = orig_inode->i_sb->s_blocksize; > @@ -313,6 +314,13 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, > * hold page's lock, if it is still the case data copy is not > * necessary, just swap data blocks between orig and donor. > */ > + folio[0] = page_folio(pagep[0]); > + folio[1] = page_folio(pagep[1]); > + > + VM_BUG_ON_FOLIO(!folio_test_large(folio[0]), folio[0]); > + VM_BUG_ON_FOLIO(!folio_test_large(folio[1]), folio[1]); > + VM_BUG_ON_FOLIO(folio_nr_pages(folio[0]) != folio_nr_pages(folio[1]), folio[1]); Looks like I got my assertions backward. We want to BUG if the folios are large, or if they are different sizes. Disregard v2, its fixed in v3.